From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77D42C433EF for ; Mon, 7 Mar 2022 07:45:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 90BA110E1B6; Mon, 7 Mar 2022 07:45:57 +0000 (UTC) Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by gabe.freedesktop.org (Postfix) with ESMTPS id 44E5110E1B6 for ; Mon, 7 Mar 2022 07:45:56 +0000 (UTC) Received: by mail-ed1-x530.google.com with SMTP id y12so5072228edt.9 for ; Sun, 06 Mar 2022 23:45:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=20HpXxzlv/vha1hiIrDHeYxMIE/fbI8WuKBWDXwYios=; b=SO8pZ8Et6UYbq9D5Caz72K7EMuCPV6WzZEySUBg6vOLJ3RLL5ZpDe1ab27oo65gGly bWpRjyLCFsftzpTBWdtEpdmjbuP2SkfWNw4XYOrF1SR+/OSxvBLrHSCwp8DpMRBrAcFG BjmPI3NCbrEEjT8V8XaW4ZWzmuENsGAWyVYERDLlTUNP0zfdXyS6GTWIJk/Ihuje9yUP z3uWYgc2C40w0Qkpr+AqW5oMaMH2NP8xWKzvXcHVsmxW8vNyp5kBvGdMNyb4VJlCSBnY ez3eVDhTt63jax86S2nZmqX+aNdw4RXUZIaOFH2lEcC4hiAuy1bhsEYfkcsuMBEuVKsg jzOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=20HpXxzlv/vha1hiIrDHeYxMIE/fbI8WuKBWDXwYios=; b=c9a5YCgOqDLhQRo652kne3DPgrnbWiT+c+fmJk1k7F3IdFnGYZK4f3lccCOu4ahy6U qxS8kjeRltoWwotYwJ8yFOXCOswT429nbsdSoOEpeozYPOFtI6Q8s7ek+Gi0Z0DQJJR6 TkSYKUK7dla9eaJqllU4fEg3mknZ7a9ESlVaWLvCTPvl4TfdvcJIlkaEnbG9ALOxM1kf OOnWcvsS2BiN6RxkB1adsDlGxAD3fngCq2ZvfgvRcbnLicdRSjz9/bPgcEkp6rnIwTQO R2UoP2rSHbZwEZ2go/jsOq3VMEfxxnu706hWLxNFOiMKtXZrpsQpeH+nMyibXzL/9ai/ dJeA== X-Gm-Message-State: AOAM531QPAdDRMtIu02HVZTlzUWFLh0rkOOmtN77jMDiBtaQQ4DJ5+MT sWfTW82maPa140F1Z13BS6M= X-Google-Smtp-Source: ABdhPJzISQUfWFp+eOqXqsrKSwMT27ucuh1rOFO+ZGjpmRKTDCqVPTVeAglPHPPbX3GqrHhdZpwMDg== X-Received: by 2002:a05:6402:cb:b0:410:8094:872b with SMTP id i11-20020a05640200cb00b004108094872bmr10075317edu.378.1646639154668; Sun, 06 Mar 2022 23:45:54 -0800 (PST) Received: from orome (p200300e41f032400f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f03:2400:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id f20-20020a056402355400b00415c7147a20sm5891707edd.26.2022.03.06.23.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Mar 2022 23:45:53 -0800 (PST) Date: Mon, 7 Mar 2022 08:45:52 +0100 From: Thierry Reding To: Dmitry Osipenko Subject: Re: [PATCH 2/2] ARM: tegra: Move panels to AUX bus Message-ID: References: <20211220104855.428290-1-thierry.reding@gmail.com> <20211220104855.428290-3-thierry.reding@gmail.com> <47a01cd9-c3ee-912b-fa9d-73449990a7d9@gmail.com> <1cded859-d3ce-f285-3b02-5d81fbfdeafc@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MBBniTf9y8n83j9B" Content-Disposition: inline In-Reply-To: <1cded859-d3ce-f285-3b02-5d81fbfdeafc@gmail.com> User-Agent: Mutt/2.2.1 (c8109e14) (2022-02-19) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Graichen , Douglas Anderson , dri-devel@lists.freedesktop.org, Jon Hunter , Laurent Pinchart , linux-tegra@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --MBBniTf9y8n83j9B Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 06, 2022 at 08:59:13PM +0300, Dmitry Osipenko wrote: > 22.12.2021 22:30, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > 20.12.2021 13:48, Thierry Reding =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > >> From: Thierry Reding > >> > >> Move the eDP panel on Venice 2 and Nyan boards into the corresponding > >> AUX bus device tree node. This allows us to avoid a nasty circular > >> dependency that would otherwise be created between the DPAUX and panel > >> nodes via the DDC/I2C phandle. > >> > >> Signed-off-by: Thierry Reding > >> --- > >> arch/arm/boot/dts/tegra124-nyan-big.dts | 15 +++++++++------ > >> arch/arm/boot/dts/tegra124-nyan-blaze.dts | 15 +++++++++------ > >> arch/arm/boot/dts/tegra124-venice2.dts | 14 +++++++------- > >> 3 files changed, 25 insertions(+), 19 deletions(-) > >> > >> diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts b/arch/arm/boot/d= ts/tegra124-nyan-big.dts > >> index 1d2aac2cb6d0..fdc1d64dfff9 100644 > >> --- a/arch/arm/boot/dts/tegra124-nyan-big.dts > >> +++ b/arch/arm/boot/dts/tegra124-nyan-big.dts > >> @@ -13,12 +13,15 @@ / { > >> "google,nyan-big-rev1", "google,nyan-big-rev0", > >> "google,nyan-big", "google,nyan", "nvidia,tegra124"; > >> =20 > >> - panel: panel { > >> - compatible =3D "auo,b133xtn01"; > >> - > >> - power-supply =3D <&vdd_3v3_panel>; > >> - backlight =3D <&backlight>; > >> - ddc-i2c-bus =3D <&dpaux>; > >> + host1x@50000000 { > >> + dpaux@545c0000 { > >> + aux-bus { > >> + panel: panel { > >> + compatible =3D "auo,b133xtn01"; > >> + backlight =3D <&backlight>; > >> + }; > >> + }; > >> + }; > >> }; > >> =20 > >> mmc@700b0400 { /* SD Card on this bus */ > >> diff --git a/arch/arm/boot/dts/tegra124-nyan-blaze.dts b/arch/arm/boot= /dts/tegra124-nyan-blaze.dts > >> index 677babde6460..abdf4456826f 100644 > >> --- a/arch/arm/boot/dts/tegra124-nyan-blaze.dts > >> +++ b/arch/arm/boot/dts/tegra124-nyan-blaze.dts > >> @@ -15,12 +15,15 @@ / { > >> "google,nyan-blaze-rev0", "google,nyan-blaze", > >> "google,nyan", "nvidia,tegra124"; > >> =20 > >> - panel: panel { > >> - compatible =3D "samsung,ltn140at29-301"; > >> - > >> - power-supply =3D <&vdd_3v3_panel>; > >> - backlight =3D <&backlight>; > >> - ddc-i2c-bus =3D <&dpaux>; > >> + host1x@50000000 { > >> + dpaux@545c0000 { > >> + aux-bus { > >> + panel: panel { > >> + compatible =3D "samsung,ltn140at29-301"; > >> + backlight =3D <&backlight>; > >> + }; > >> + }; > >> + }; > >> }; > >> =20 > >> sound { > >> diff --git a/arch/arm/boot/dts/tegra124-venice2.dts b/arch/arm/boot/dt= s/tegra124-venice2.dts > >> index 232c90604df9..6a9592ceb5f2 100644 > >> --- a/arch/arm/boot/dts/tegra124-venice2.dts > >> +++ b/arch/arm/boot/dts/tegra124-venice2.dts > >> @@ -48,6 +48,13 @@ sor@54540000 { > >> dpaux@545c0000 { > >> vdd-supply =3D <&vdd_3v3_panel>; > >> status =3D "okay"; > >> + > >> + aux-bus { > >> + panel: panel { > >> + compatible =3D "lg,lp129qe"; > >> + backlight =3D <&backlight>; > >> + }; > >> + }; > >> }; > >> }; > >> =20 > >> @@ -1080,13 +1087,6 @@ power { > >> }; > >> }; > >> =20 > >> - panel: panel { > >> - compatible =3D "lg,lp129qe"; > >> - power-supply =3D <&vdd_3v3_panel>; > >> - backlight =3D <&backlight>; > >> - ddc-i2c-bus =3D <&dpaux>; > >> - }; > >> - > >> vdd_mux: regulator-mux { > >> compatible =3D "regulator-fixed"; > >> regulator-name =3D "+VDD_MUX"; > >> > >=20 > > You should add stable tag for 5.15 and also add separate patch to update > > the new arch/arm/boot/dts/tegra124-nyan-big-fhd.dts which we have in > > -next now. >=20 > Thierry, are you going to address this review comment? I see in > linux-next that you picked up this incomplete version of the patch. Ah, shoot. I've got this in my local tree but forgot to squash this in with the other changes. I'll send out a follow-up. Thierry --MBBniTf9y8n83j9B Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmIluC0ACgkQ3SOs138+ s6Hapg/+NGPAEvdFBjFdPYhfiDgTO07O1AQbF0rxyPzn9krpXjCqy1J48/25oHbc MZKHu49En/pAiYOgkmUElH62j1M9JqKOA0p3z+O74NnYirfSRom8yDVNeTP8xrtg RxZq3Nlx+vMnv5AZzA/ue16+LrebWWkUg3RFMl8IQxL38UbtOZ20Uct7S4+FlZbv S63eY+Y4lizPJFE07DI4/T83+7kPPOCt6rTOtyizgdCB7gO/ydK6w/akcapOwdkQ sXlFFi/dAyNLonUU4Hm5rb3xUytjnZmGXIOn8ygt3K/qQnlVcFRkvRGJaJhC5hV9 S7HCzLx9F5A9U7vUvrBBu3Mn8RpWbIujW54kVdPteJYIbgSuTTFk/27Bi6TJD+ex e8WKTLejjqdyKb5TfKDyRwacpEXeLMpqrrQ96htz7shAudn+k9J8Bf0LCvdwg5gc 4ngTY+7d5wRrG28uSvVZMuLBqWseVQt/CVItWdfIwUc3Ngto1buVqzTYapYeuSRv uFeZtlVjwwM4lyPVqxD8kXBjcnNgL50z/hl53N0tJFSFR8KdvdE21v/G9v/WF8bp cSpuZb1/zjLMYxtXK4s22KaiJlPKrf7bGm2ClmKB390QWS3xnKtOuWk3wZ8Ogj2I KwJA5fd6FzZnClqq4G9NpF37ta0E1oOn6WgVAtmSRVNJJ16atl8= =RTqv -----END PGP SIGNATURE----- --MBBniTf9y8n83j9B--