Re: [PATCH 01/25] drm/edid: use else-if in CTA extension parsing

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Fri, May 06, 2022 at 01:10:08PM +0300, Jani Nikula wrote:
> Only one of the conditions can be true.
> 
> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/drm_edid.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 47d121e99201..efc1999b9573 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -5473,16 +5473,16 @@ static void drm_parse_cea_ext(struct drm_connector *connector,
>  
>  		if (cea_db_is_hdmi_vsdb(db))
>  			drm_parse_hdmi_vsdb_video(connector, data);
> -		if (cea_db_is_hdmi_forum_vsdb(db) ||
> -		    cea_db_is_hdmi_forum_scdb(db))
> +		else if (cea_db_is_hdmi_forum_vsdb(db) ||
> +			 cea_db_is_hdmi_forum_scdb(db))
>  			drm_parse_hdmi_forum_scds(connector, data);
> -		if (cea_db_is_microsoft_vsdb(db))
> +		else if (cea_db_is_microsoft_vsdb(db))
>  			drm_parse_microsoft_vsdb(connector, data);
> -		if (cea_db_is_y420cmdb(db))
> +		else if (cea_db_is_y420cmdb(db))
>  			drm_parse_y420cmdb_bitmap(connector, data);
> -		if (cea_db_is_vcdb(db))
> +		else if (cea_db_is_vcdb(db))
>  			drm_parse_vcdb(connector, data);
> -		if (cea_db_is_hdmi_hdr_metadata_block(db))
> +		else if (cea_db_is_hdmi_hdr_metadata_block(db))
>  			drm_parse_hdr_metadata_block(connector, data);
>  	}
>  	cea_db_iter_end(&iter);
> -- 
> 2.30.2

-- 
Ville Syrjälä
Intel