From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1C51CCA473 for ; Fri, 24 Jun 2022 14:35:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E267A10E65C; Fri, 24 Jun 2022 14:35:55 +0000 (UTC) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by gabe.freedesktop.org (Postfix) with ESMTPS id F081410EACE for ; Fri, 24 Jun 2022 14:35:53 +0000 (UTC) Received: (Authenticated sender: paul.kocialkowski@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 4A7C120002; Fri, 24 Jun 2022 14:35:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1656081352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z/XGzdtFqcVGB8e2YIX6omwGWK/S08DpKJpbNqUDcSE=; b=oieKVySo+sXGflMfukphC5meksFzkcoxcCg02IWYya5zyd/f0S4Usb8zkYwGr7rm6JdrFC vyyLSKtZuEuWjXhUGMKNBmul8KodDjqTLW3NvI/U2874+2Mq6nvRKOTJvE3I9c37M+JhdK vh+FDeqsdq6F1J/eDWBugMuH/x8mT9SeIviWKF/G/ugZbnGfcL+oXc8PPBp2BVOZ26kTVg bU8bPNDn1M3NVD3as3V5+60E7VBlMwZBs8eVayHCeMMx/Sz6omPGCTApidz0c4xT4VZCxe yZKL1ifCuUDQsLuZ2rYyHEVrl052J89MHKHyYsedoWXmzfG3hOx9y2YaGeKcag== Date: Fri, 24 Jun 2022 16:35:51 +0200 From: Paul Kocialkowski To: Dan Carpenter Subject: Re: [PATCH] drm: logicvc: fix error code in logicvc_layer_init() Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9rmVoEPHcjZhZxQy" Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --9rmVoEPHcjZhZxQy Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue 14 Jun 22, 15:08, Dan Carpenter wrote: > Return -EINVAL if logicvc_layer_formats_lookup() fails. Don't return > success. >=20 > Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller= ") > Signed-off-by: Dan Carpenter Thanks for the fix! Acked-by: Paul Kocialkowski Paul > --- > drivers/gpu/drm/logicvc/logicvc_layer.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c b/drivers/gpu/drm/lo= gicvc/logicvc_layer.c > index bae1c7f99569..9c94b67afbed 100644 > --- a/drivers/gpu/drm/logicvc/logicvc_layer.c > +++ b/drivers/gpu/drm/logicvc/logicvc_layer.c > @@ -489,6 +489,7 @@ static int logicvc_layer_init(struct logicvc_drm *log= icvc, > if (!formats) { > drm_err(drm_dev, "Failed to lookup formats for layer #%d\n", > index); > + ret =3D -EINVAL; > goto error; > } > =20 > --=20 > 2.35.1 >=20 --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --9rmVoEPHcjZhZxQy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmK1y8cACgkQ3cLmz3+f v9Hc+Af/T9/8gpMFxU6r6DJMRLFfZzthyHv1domnxFjanb7l02hKHLHGfQlLumy4 ho9uZ0vjKUTHqM1XmQk7gH968MRWCAxJu+085dSlcnruMfwKb1VH4T/6IQVLp6jx Sa1aNuJ5BbJTGfD36fDDd6SxnBQ4meJ6HnEgwV7ObfCoeTbVoIePttk8G9u6zKvS o1je62yimInw6xi2wMjxKh848pa2wyOUhDKIwu95TMG2kSucJ+KfJ5o2EdLmBIX9 So7VeHnXiqE65uDyBMhN7XhKCqANSYBdybuYp2jD/Fi7V1zVf9mSbaEEa9/V99hl tzd+yGe0c1uII7wVYXMgwR5LwyhQjQ== =EFB/ -----END PGP SIGNATURE----- --9rmVoEPHcjZhZxQy--