From: Sam Ravnborg <sam@ravnborg.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Thierry Reding <thierry.reding@gmail.com>,
dri-devel@lists.freedesktop.org, kernel@pengutronix.de
Subject: Re: [PATCH 2/3] drm/panel-novatek-nt35510: Emit an error message if power off fails
Date: Sat, 9 Jul 2022 10:51:37 +0200 [thread overview]
Message-ID: <YslBmR3+v4UTGTL3@ravnborg.org> (raw)
In-Reply-To: <20220708094922.1408248-3-u.kleine-koenig@pengutronix.de>
Hi Uwe,
On Fri, Jul 08, 2022 at 11:49:21AM +0200, Uwe Kleine-König wrote:
> Returning an error code from a mipi_dsi remove callback fails, this is
> silently ignored. (mipi_dsi_drv_remove() propagates the return value to
> device_remove() which ignores it.) So emit an error code in the driver
> remove function and return 0.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed and applied to drm-misc (drm-misc-next).
Sam
next prev parent reply other threads:[~2022-07-09 8:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 9:49 [PATCH 0/3] drm/mipi-dsi: Make remove callback return void Uwe Kleine-König
2022-07-08 9:49 ` [PATCH 1/3] drm/panel: simple: Make panel_simple_remove() " Uwe Kleine-König
2022-07-09 8:51 ` Sam Ravnborg
2022-07-08 9:49 ` [PATCH 2/3] drm/panel-novatek-nt35510: Emit an error message if power off fails Uwe Kleine-König
2022-07-09 8:51 ` Sam Ravnborg [this message]
2022-07-08 9:49 ` [PATCH 3/3] drm/mipi-dsi: Make remove callback return void Uwe Kleine-König
2022-07-09 8:50 ` Sam Ravnborg
2022-07-09 16:28 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YslBmR3+v4UTGTL3@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox