From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 965B4C28D13 for ; Thu, 25 Aug 2022 08:52:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F068111A91C; Thu, 25 Aug 2022 08:52:07 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3B0F311A694; Thu, 25 Aug 2022 08:51:48 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 564422B3; Thu, 25 Aug 2022 10:51:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1661417506; bh=hqjjTfpHavt0j/vu7b/diKsDIw1QdqTc5yyTW7GYfo8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z8pStjaw+wTHpUqjfkrNYv4yhEOMiZpey4BovUqFDdUKaiJRG3zr27mJb+3KOVnqv SeSwIWuxOsniVY0CtkTuJBrvvODxoS4qbCjAnkQGfS00GuyUS1Limb9dDBRxhVsFoW HVOrzfbF2aIEGVjQzg6fMImib3ZqHBM+/31mCM9o= Date: Thu, 25 Aug 2022 11:51:40 +0300 From: Laurent Pinchart To: Rob Herring Subject: Re: [PATCH] dt-bindings: display: Add missing (unevaluated|additional)Properties on child nodes Message-ID: References: <20220823145649.3118479-11-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220823145649.3118479-11-robh@kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof Kozlowski , Neil Armstrong , David Airlie , Liviu Dudau , dri-devel@lists.freedesktop.org, Jernej Skrabec , Andrzej Hajda , Mihail Atanassov , linux-samsung-soc@vger.kernel.org, Kyungmin Park , Krzysztof Kozlowski , "James \(Qian\) Wang" , linux-arm-msm@vger.kernel.org, Alim Akhtar , devicetree@vger.kernel.org, Jonas Karlman , Andre Przywara , Abhinav Kumar , Sean Paul , linux-arm-kernel@lists.infradead.org, Seung-Woo Kim , linux-kernel@vger.kernel.org, Robert Foss , Dmitry Baryshkov , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Rob, Thank you for the patch. On Tue, Aug 23, 2022 at 09:56:42AM -0500, Rob Herring wrote: > In order to ensure only documented properties are present, node schemas > must have unevaluatedProperties or additionalProperties set to false > (typically). > > Signed-off-by: Rob Herring Reviewed-by: Laurent Pinchart > --- > Documentation/devicetree/bindings/display/arm,komeda.yaml | 1 + > Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml | 1 + > Documentation/devicetree/bindings/display/msm/gpu.yaml | 1 + > .../bindings/display/samsung/samsung,exynos7-decon.yaml | 1 + > .../devicetree/bindings/display/samsung/samsung,fimd.yaml | 1 + > 5 files changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/arm,komeda.yaml b/Documentation/devicetree/bindings/display/arm,komeda.yaml > index 9f4aade97f10..3ad3eef89ca8 100644 > --- a/Documentation/devicetree/bindings/display/arm,komeda.yaml > +++ b/Documentation/devicetree/bindings/display/arm,komeda.yaml > @@ -58,6 +58,7 @@ properties: > patternProperties: > '^pipeline@[01]$': > type: object > + additionalProperties: false > description: > clocks > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > index 3a8614e0f627..84aafcbf0919 100644 > --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > @@ -51,6 +51,7 @@ properties: > properties: > port@0: > $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > description: | > For LVDS encoders, port 0 is the parallel input > For LVDS decoders, port 0 is the LVDS input > diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml > index 3397bc31d087..0179c816fa6d 100644 > --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml > +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml > @@ -81,6 +81,7 @@ properties: > > zap-shader: > type: object > + additionalProperties: false > description: | > For a5xx and a6xx devices this node contains a memory-region that > points to reserved memory to store the zap shader that can be used to > diff --git a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml > index 969bd8c563a5..dec1c9058876 100644 > --- a/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml > +++ b/Documentation/devicetree/bindings/display/samsung/samsung,exynos7-decon.yaml > @@ -37,6 +37,7 @@ properties: > > i80-if-timings: > type: object > + additionalProperties: false > description: timing configuration for lcd i80 interface support > properties: > cs-setup: > diff --git a/Documentation/devicetree/bindings/display/samsung/samsung,fimd.yaml b/Documentation/devicetree/bindings/display/samsung/samsung,fimd.yaml > index 5d5cc220f78a..7593938601bb 100644 > --- a/Documentation/devicetree/bindings/display/samsung/samsung,fimd.yaml > +++ b/Documentation/devicetree/bindings/display/samsung/samsung,fimd.yaml > @@ -40,6 +40,7 @@ properties: > > i80-if-timings: > type: object > + additionalProperties: false > description: | > Timing configuration for lcd i80 interface support. > The parameters are defined as:: -- Regards, Laurent Pinchart