From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6A34ECAAD3 for ; Thu, 1 Sep 2022 09:20:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EBA8110E666; Thu, 1 Sep 2022 09:20:12 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id D12CC10E665; Thu, 1 Sep 2022 09:20:09 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E3D6061994; Thu, 1 Sep 2022 09:20:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BB8BC4347C; Thu, 1 Sep 2022 09:20:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662024008; bh=EWqzcyYFAAZgRuUDRZ4hmWQW7ga969a7SKJ0NU4vaig=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LCg8ESXJFXk6FSWXh23YIeMZMMdafEZmH5ceI5fvAJULr8fBzAEo93FBV4jL/QSLo zyZT7MvpuAtmdkdgR8I7Hl1a+IEmeBXTAB5SEHhxi7STHwD6PBquNfz5Y5qvhR4Ll/ XWMFAvutHjbj5P/AupdVhgqnTnALt6bsrB/X8ZL/sqPaQRAzXB69sw2j3AdnRR+4Lf 6ITCrgerelEltpf1g2D0xpEVVo3jXY2DLklvjEG2zY7FupceQnuYHDIr7j1QJGP6za ipDj4rr7/P8VihQbE+s2p4+pM8c2yAUdki4XKb1x8T1ICBnbKdJhKViphsTR//oAO9 9alvZCVsF3svA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1oTgMp-0006Zq-W7; Thu, 01 Sep 2022 11:20:08 +0200 Date: Thu, 1 Sep 2022 11:20:07 +0200 From: Johan Hovold To: Dmitry Baryshkov Subject: Re: [RFC PATCH 0/3] drm/msm/dp: several fixes for the IRQ handling Message-ID: References: <20220901091527.1992208-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220901091527.1992208-1-dmitry.baryshkov@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, David Airlie , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Abhinav Kumar , dri-devel@lists.freedesktop.org, Stephen Boyd , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Sep 01, 2022 at 12:15:24PM +0300, Dmitry Baryshkov wrote: > Johan Hovold has reported that returning a probe deferral from the > msm_dp_modeset_init() can cause issues because the IRQ is not freed > properly. This (compile-tested only) series tries to fix the issue by > moving devm_request_irq() to the probe callback. Please try to reproduce the issue yourself before posting untested RFCs. We're all short on time. Johan