From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5562DC32771 for ; Wed, 28 Sep 2022 12:24:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0588410E4ED; Wed, 28 Sep 2022 12:24:44 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id A90FD10E4EC; Wed, 28 Sep 2022 12:24:38 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 48445B82038; Wed, 28 Sep 2022 12:24:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3412C433C1; Wed, 28 Sep 2022 12:24:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664367876; bh=dBwYyIOq7xKF2yq5mWzeWyI6QLDHI+INr6nNI1xPzAo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VpuW2ZIyPzbpYaGo3QDSDvBrtWqXtDUC+j3uR7J3Bojq4/w5XMcNNuN1MTSMm3AH1 M2soWfAHndJq5YYyEMVkglILBCy85fKd4Vx9y27d5Vyn1ux+VVMARTqmWpJOwxvpk/ kr/XrqEokc8BN4DvN/MWjY/22JOzvDwwuxsdc2zG2URG8BAZqAUsKk39G0enec/fS4 yl2hygFdXnojRHQiXobCPhN7bRw9QNyH5lIo3ce7pnw+xCYp6sOOWl4ax3V5F5fT5w 1aNnSi49wg8Wt3RUx4GL2iK5R5+zaryKXyjRN+f2UNvpsELPgLjLmDDxc806OLwZhh XHlVMPz+GExoA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1odW7E-0001cB-VT; Wed, 28 Sep 2022 14:24:41 +0200 Date: Wed, 28 Sep 2022 14:24:40 +0200 From: Johan Hovold To: Abhinav Kumar Subject: Re: [PATCH v2 09/10] drm/msm/dp: drop modeset sanity checks Message-ID: References: <20220913085320.8577-1-johan+linaro@kernel.org> <20220913085320.8577-10-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Neil Armstrong , Jernej Skrabec , linux-kernel@vger.kernel.org, Jonas Karlman , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Steev Klimaszewski , freedreno@lists.freedesktop.org, Douglas Anderson , Robert Foss , Stephen Boyd , Laurent Pinchart , Andrzej Hajda , Manivannan Sadhasivam , Dmitry Baryshkov , Kuogee Hsieh , Sean Paul , Johan Hovold Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Sep 27, 2022 at 11:42:53AM -0700, Abhinav Kumar wrote: > On 9/27/2022 12:14 AM, Johan Hovold wrote: > > On Mon, Sep 26, 2022 at 11:17:20AM -0700, Abhinav Kumar wrote: > >> On 9/13/2022 1:53 AM, Johan Hovold wrote: > >>> Drop the overly defensive modeset sanity checks of function parameters > >>> which have already been checked or used by the callers. > >>> > >>> Reviewed-by: Dmitry Baryshkov > >>> Signed-off-by: Johan Hovold > >> > >> The change LGTM, hence > >> > >> Reviewed-by: Abhinav Kumar > >> > >> I think we can use below fixes tag so that we can pick up this entire > >> series for the fixes cycle. > >> > >> Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") > > > > Perhaps that's a requirement for drm, but I wouldn't add a Fixes tag for > > this otherwise as it's not a bug. > > > > You also have to watch out for Sasha and his autosel scripts which will > > probably try to backport this to stable if it finds a Fixes tag. > Discussed with Rob on IRC, we will apply everything except the last two > patches of this series in the -fixes and take these two for the next > kernel rev push. So the fixes go in 6.0 and the two follow-on cleanups in 6.1? Or did you mean 6.1 and 6.2? Johan