From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3AA99E77199 for ; Wed, 8 Jan 2025 18:22:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A764E10E00D; Wed, 8 Jan 2025 18:22:36 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; secure) header.d=ffwll.ch header.i=@ffwll.ch header.b="imuo4rL/"; dkim-atps=neutral Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5461110E00D for ; Wed, 8 Jan 2025 18:22:36 +0000 (UTC) Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-aa684b6d9c7so22070166b.2 for ; Wed, 08 Jan 2025 10:22:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; t=1736360495; x=1736965295; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=vyXJyoTUz/O+MekoAhD1dI1UuPy1klDP8U3mVYcAA7E=; b=imuo4rL/2qooYdr9o3719sWLvRqIdzfOsnhwFkktBa9Dy2/2Vpx0DYmZtencKI2xqk WI90dcLxA+5qGMXbuFhfWblaPhGtSCiD+viAKZurILhbcfS264t+8r5z4BTebf+cetgX a8Uju+c41Ojh5UKST2MBLBlu+a8x2udYOsD/s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736360495; x=1736965295; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vyXJyoTUz/O+MekoAhD1dI1UuPy1klDP8U3mVYcAA7E=; b=xUc8WJQY5UTUkgyEwKwkHM7g9aAF4c+FvemN+zTWBcR8bfUrJWpqMqAPR7Pt+x/D3I QpvAo9g6IfBxlERz1NDAAV8pKe0MJxUa6nlIZMJuLGDRYt9LrcXLC6yJT2dCD6bdwoOh fxSEPDanHip9aYFstRQeEMXsro3DtIUr/rQr0MIMTLgELKbXmCHpnNDXvMa/FtlM/ojp k0NmEMVdoQ2VPq9tYE6eXzN89D3VBSdVzB0W7EyMjuyPUCwivup4vpvxdtH0fmQR2C0h /gH2D4wdDdFS9z4eASTU9gYFCnL3GR9STANyO31cg+gdLcFjLC2sppMbT4OnOaT5LoMX bSPg== X-Forwarded-Encrypted: i=1; AJvYcCVwXP1P3fdO+c7YwoWQkmT9dhdDVVywb5m8O7CnsQlu2pYXq7P2E9eeJtwiFH6vE5aEbporsw9eRFk=@lists.freedesktop.org X-Gm-Message-State: AOJu0YxjFMpNPmRNOnirWuiuGvffinrTJlWiFWCv7LlqwR4pRczaJofc Wd6Z0uVTKzckWTezagpJkSPP/1CtsJzZNPT42dwbdng3NOQqVVzwvIvMw7txUkR5Ae7WOd5Eoso o X-Gm-Gg: ASbGncuwVrcVn3Yy3X9LNic16h3Vw2m34KCLctD52BRGVIbg6TXVHet4R2bCAwdiIp7 CkRk2WsvQP+5SdKiCjdPNwzx6fgFpGhUHcC6SK7QmTz3z+XP5XG67wdTZhPWP0kMlRozzL2zwt7 TsqMFEPdHjmIfrbV8t1F7xqy9aTHUpW8Y76f7GkSbeOErtroUAoIF7FpO5+cV+PQtyehKWZzs5f 3F3RKFg250R9i/c4IfdY1w7Q1BIx+joQ/k8EK/+9igL89KNBxnaVc5OW0a1mel7/h2q X-Google-Smtp-Source: AGHT+IFozYJT06qw76DGVvnYOd+8i9OFhvq0LrKuiLg44EMhHZJky3qMfsIaLpjOif5j1Ah+kYp2VQ== X-Received: by 2002:a5d:64eb:0:b0:385:f349:fffb with SMTP id ffacd0b85a97d-38a8732c439mr3473025f8f.45.1736358986935; Wed, 08 Jan 2025 09:56:26 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:5485:d4b2:c087:b497]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c89e2d2sm54271834f8f.71.2025.01.08.09.56.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 09:56:26 -0800 (PST) Date: Wed, 8 Jan 2025 18:56:24 +0100 From: Simona Vetter To: Dmitry Baryshkov Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Chandan Uddaraju , Jeykumar Sankaran , Jordan Crouse , Sravanthi Kollukuduru , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Archit Taneja , Rajesh Yadav , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Simona Vetter Subject: Re: [PATCH 3/6] drm/msm/dpu: don't use active in atomic_check() Message-ID: Mail-Followup-To: Dmitry Baryshkov , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Chandan Uddaraju , Jeykumar Sankaran , Jordan Crouse , Sravanthi Kollukuduru , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Archit Taneja , Rajesh Yadav , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org References: <20241222-drm-dirty-modeset-v1-0-0e76a53eceb9@linaro.org> <20241222-drm-dirty-modeset-v1-3-0e76a53eceb9@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241222-drm-dirty-modeset-v1-3-0e76a53eceb9@linaro.org> X-Operating-System: Linux phenom 6.12.3-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Dec 22, 2024 at 07:00:43AM +0200, Dmitry Baryshkov wrote: > The driver isn't supposed to consult crtc_state->active/active_check for > resource allocation. Instead all resources should be allocated if > crtc_state->enabled is set. Stop consulting active / active_changed in > order to determine whether the hardware resources should be > (re)allocated. > > Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") > Reported-by: Simona Vetter > Closes: https://lore.kernel.org/dri-devel/ZtW_S0j5AEr4g0QW@phenom.ffwll.local/ > Signed-off-by: Dmitry Baryshkov This is well-contained enough that I feel like I can actually review this without making a fool of myself :-) Reviewed-by: Simona Vetter > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 4 ---- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3 +-- > 2 files changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > index 7191b1a6d41b3a96f956d199398f12b2923e8c82..65e33eba61726929b740831c95330756b2817e28 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > @@ -1264,10 +1264,6 @@ static int dpu_crtc_atomic_check(struct drm_crtc *crtc, > > DRM_DEBUG_ATOMIC("%s: check\n", dpu_crtc->name); > > - /* force a full mode set if active state changed */ > - if (crtc_state->active_changed) > - crtc_state->mode_changed = true; > - > if (cstate->num_mixers) { > rc = _dpu_crtc_check_and_setup_lm_bounds(crtc, crtc_state); > if (rc) > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > index 83de7564e2c1fe14fcf8c4f82335cafc937e1b99..d1ccdca6044353f110bf5b507788efe368f223a3 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > @@ -793,12 +793,11 @@ static int dpu_encoder_virt_atomic_check( > crtc_state->mode_changed = true; > /* > * Release and Allocate resources on every modeset > - * Dont allocate when active is false. > */ > if (drm_atomic_crtc_needs_modeset(crtc_state)) { > dpu_rm_release(global_state, drm_enc); > > - if (!crtc_state->active_changed || crtc_state->enable) > + if (crtc_state->enable) > ret = dpu_rm_reserve(&dpu_kms->rm, global_state, > drm_enc, crtc_state, topology); > if (!ret) > > -- > 2.39.5 > -- Simona Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch