From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C92D8C28B28 for ; Wed, 12 Mar 2025 15:51:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 41D9F10E79D; Wed, 12 Mar 2025 15:51:18 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="NvnDz5JN"; dkim-atps=neutral Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id E941110E79D for ; Wed, 12 Mar 2025 15:51:15 +0000 (UTC) Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-2ff69365e1dso48040a91.3 for ; Wed, 12 Mar 2025 08:51:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741794675; x=1742399475; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=s6kcU/jqWnvmgUYRTSnCwjipLLOVfnhjvRKH7bJe2iA=; b=NvnDz5JNDOTs4nWcafWkRXIhZ1/BQkOyJLLr7QqA148wTaOAZgP3jFXCIO9cA7SKc6 Vts4ToZa4bChnd8WiQO5sGV9u/KG6lbBWWK2MFkISQmA1XsT0eNGtDdC4qK0bLsIdzmB hI1lOSkXix/cpga/YBR/FPc5FCO+YVWMmJYYw1fq69mnwHwH0PnYZEyIPlZgJhBhQTlL Xxwg5sGuluOnXvjV6iAcCICWMjAQ40v7HPrruZ1AWW1k0uonVsLG7G+2hGiiSoW/AMOe li5r29QYCn/VwjV5KJxeI6bng/JkkpKtC54Y0BZNpAGyOcmuT4niN0QJ/uhSa82LuhWn gA4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741794675; x=1742399475; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=s6kcU/jqWnvmgUYRTSnCwjipLLOVfnhjvRKH7bJe2iA=; b=QqpPsT0RdRZc9MNGtJDOcEaSwFpDGeVZv3eiBG7qmzwremhMlnuzMWPFFo4x7Kd0Xl DTDJ24KvsjclmljZyBfCXinir+ANm2vuv5qrz1YjjMxp7aNscG9qy+vCpfitz08agYN6 Y/UJmJMcUDxLnKjIPhvdGjL6UCfP7GYLfJv7BS64AXxi9ukkDJJ149d4HK4pnOra6hE+ e7YhEoGU4uzPtz7c0J4bJHZoGKPgstxmVUOZpSnZxC3ou5TYAHdo5bS9VQLjhKKlUPqV RXw93i36QvwzBfy3pKJmyBM7Vn2G+SvA9orMdL0PxsDFgy3v+qEQFu1la6yDmMgqqXZA +bng== X-Forwarded-Encrypted: i=1; AJvYcCUEkekNgb36PqEwT+6V26nQ9+niSkzo8PKIqjkgfqbk+e7oFWdPz1ijMKrBB5cLr6/9vdeKNE6VCvc=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yxnn9qNF5yLBimi1oksxvBmoWdzuP+F5p1Uxpa9Le7fxofp5DVP 3USK67Z2p6302Gq9SpenHlnk7G3iShslbvFc7a5sfU35XF7wOylP X-Gm-Gg: ASbGncsAasHC+/DxpLGBqMAwMq27vGMfVFAHqd/QPoTHIUHmHkaYOCLvjso/2KmNpvy awqn2S+F8hInQh41sgco7ce4Dl8+Dc8wLraQw88NuIwua01KnXsEs9M/MsIq9XDRnkx63Uw3f6A BWcC6KdiG+BSM8vBu7SQGxTX9Ufu6IgAFnPAniHE8ptrUvnGX7xcupmLdp82O2VJu1zNZBGFqBZ BoPxXm9am7lWvSqLcBhOVFt4yA2Tm+3de8ZG44kZVwtLannma1bhdBEcKKv40ciSsNrR7+IUemJ fwzDavYMrJznZI/a3ugsS2bE6Bc+wglKtuKQ+FIigwLI X-Google-Smtp-Source: AGHT+IGK1wYMGzHFc5cibW/rOHObEUL/txoAjaO3YQm2mzlBBY39pOgAZq4ZVPE3dzf2E+KcMNlzyw== X-Received: by 2002:a17:90a:a009:b0:301:1d03:93cd with SMTP id 98e67ed59e1d1-3011d039a52mr3747173a91.24.1741794675252; Wed, 12 Mar 2025 08:51:15 -0700 (PDT) Received: from localhost ([216.228.125.130]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-301182181c3sm1955502a91.5.2025.03.12.08.51.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Mar 2025 08:51:14 -0700 (PDT) Date: Wed, 12 Mar 2025 11:51:12 -0400 From: Yury Norov To: "H. Peter Anvin" Cc: Kuan-Wei Chiu , David Laight , Andrew Cooper , Laurent.pinchart@ideasonboard.com, airlied@gmail.com, akpm@linux-foundation.org, alistair@popple.id.au, andrew+netdev@lunn.ch, andrzej.hajda@intel.com, arend.vanspriel@broadcom.com, awalls@md.metrocast.net, bp@alien8.de, bpf@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211@lists.linux.dev, dave.hansen@linux.intel.com, davem@davemloft.net, dmitry.torokhov@gmail.com, dri-devel@lists.freedesktop.org, eajames@linux.ibm.com, edumazet@google.com, eleanor15x@gmail.com, gregkh@linuxfoundation.org, hverkuil@xs4all.nl, jernej.skrabec@gmail.com, jirislaby@kernel.org, jk@ozlabs.org, joel@jms.id.au, johannes@sipsolutions.net, jonas@kwiboo.se, jserv@ccns.ncku.edu.tw, kuba@kernel.org, linux-fsi@lists.ozlabs.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, linux-serial@vger.kernel.org, linux-wireless@vger.kernel.org, linux@rasmusvillemoes.dk, louis.peens@corigine.com, maarten.lankhorst@linux.intel.com, mchehab@kernel.org, mingo@redhat.com, miquel.raynal@bootlin.com, mripard@kernel.org, neil.armstrong@linaro.org, netdev@vger.kernel.org, oss-drivers@corigine.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, rfoss@kernel.org, richard@nod.at, simona@ffwll.ch, tglx@linutronix.de, tzimmermann@suse.de, vigneshr@ti.com, x86@kernel.org Subject: Re: [PATCH v3 00/16] Introduce and use generic parity16/32/64 helper Message-ID: References: <4732F6F6-1D41-4E3F-BE24-E54489BC699C@zytor.com> <5A790652-1B22-4D13-AAC5-5D9931E90903@zytor.com> <20250307195310.58abff8c@pumpkin> <80771542-476C-493E-858A-D2AF6A355CC1@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <80771542-476C-493E-858A-D2AF6A355CC1@zytor.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Mar 11, 2025 at 03:24:14PM -0700, H. Peter Anvin wrote: > On March 11, 2025 3:01:30 PM PDT, Yury Norov wrote: > >On Sun, Mar 09, 2025 at 11:48:26PM +0800, Kuan-Wei Chiu wrote: > >> On Fri, Mar 07, 2025 at 12:07:02PM -0800, H. Peter Anvin wrote: > >> > On March 7, 2025 11:53:10 AM PST, David Laight wrote: > >> > >On Fri, 07 Mar 2025 11:30:35 -0800 > >> > >"H. Peter Anvin" wrote: > >> > > > >> > >> On March 7, 2025 10:49:56 AM PST, Andrew Cooper wrote: > >> > >> >> (int)true most definitely is guaranteed to be 1. > >> > >> > > >> > >> >That's not technically correct any more. > >> > >> > > >> > >> >GCC has introduced hardened bools that intentionally have bit patterns > >> > >> >other than 0 and 1. > >> > >> > > >> > >> >https://gcc.gnu.org/gcc-14/changes.html > >> > >> > > >> > >> >~Andrew > >> > >> > >> > >> Bit patterns in memory maybe (not that I can see the Linux kernel using them) but > >> > >> for compiler-generated conversations that's still a given, or the manager isn't C > >> > >> or anything even remotely like it. > >> > >> > >> > > > >> > >The whole idea of 'bool' is pretty much broken by design. > >> > >The underlying problem is that values other than 'true' and 'false' can > >> > >always get into 'bool' variables. > >> > > > >> > >Once that has happened it is all fubar. > >> > > > >> > >Trying to sanitise a value with (say): > >> > >int f(bool v) > >> > >{ > >> > > return (int)v & 1; > >> > >} > >> > >just doesn't work (see https://www.godbolt.org/z/MEndP3q9j) > >> > > > >> > >I really don't see how using (say) 0xaa and 0x55 helps. > >> > >What happens if the value is wrong? a trap or exception?, good luck recovering > >> > >from that. > >> > > > >> > > David > >> > > >> > Did you just discover GIGO? > >> > >> Thanks for all the suggestions. > >> > >> I don't have a strong opinion on the naming or return type. I'm still a > >> bit confused about whether I can assume that casting bool to int always > >> results in 0 or 1. > >> > >> If that's the case, since most people prefer bool over int as the > >> return type and some are against introducing u1, my current plan is to > >> use the following in the next version: > >> > >> bool parity_odd(u64 val); > >> > >> This keeps the bool return type, renames the function for better > >> clarity, and avoids extra maintenance burden by having just one > >> function. > >> > >> If I can't assume that casting bool to int always results in 0 or 1, > >> would it be acceptable to keep the return type as int? > >> > >> Would this work for everyone? > > > >Alright, it's clearly a split opinion. So what I would do myself in > >such case is to look at existing code and see what people who really > >need parity invent in their drivers: > > > > bool parity_odd > >static inline int parity8(u8 val) - - > >static u8 calc_parity(u8 val) - - > >static int odd_parity(u8 c) - + > >static int saa711x_odd_parity - + > >static int max3100_do_parity - - > >static inline int parity(unsigned x) - - > >static int bit_parity(u32 pkt) - - > >static int oa_tc6_get_parity(u32 p) - - > >static u32 parity32(__le32 data) - - > >static u32 parity(u32 sample) - - > >static int get_parity(int number, - - > > int size) > >static bool i2cr_check_parity32(u32 v, + - > > bool parity) > >static bool i2cr_check_parity64(u64 v) + - > >static int sw_parity(__u64 t) - - > >static bool parity(u64 value) + - > > > >Now you can refer to that table say that int parity(uXX) is what > >people want to see in their drivers. > > > >Whichever interface you choose, please discuss it's pros and cons. > >What bloat-o-meter says for each option? What's maintenance burden? > >Perf test? Look at generated code? > > > >I personally for a macro returning boolean, something like I > >proposed at the very beginning. > > > >Thanks, > >Yury > > Also, please at least provide a way for an arch to opt in to using the builtins, which seem to produce as good results or better at least on some architectures like x86 and probably with CPU options that imply fast popcnt is available. Yeah. And because linux/bitops.h already includes asm/bitops.h the simplest way would be wrapping generic implementation with the #ifndef parity, similarly to how we handle find_next_bit case. So: 1. Kuan-Wei, please don't invent something like ARCH_HAS_PARITY; 2. This may, and probably should, be a separate follow-up series, likely created by corresponding arch experts. Thanks, Yury