From: Danilo Krummrich <dakr@kernel.org>
To: Mel Henning <mhenning@darkrefraction.com>
Cc: Karol Herbst <kherbst@redhat.com>, Lyude Paul <lyude@redhat.com>,
Faith Ekstrand <faith.ekstrand@collabora.com>,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO
Date: Thu, 20 Mar 2025 19:37:05 +0100 [thread overview]
Message-ID: <Z9xgUY8YBTRuVHdm@pollux> (raw)
In-Reply-To: <Z9xb5SABWcwYnV-x@pollux>
On Thu, Mar 20, 2025 at 07:18:13PM +0100, Danilo Krummrich wrote:
> Hi Mel,
>
> On Wed, Mar 12, 2025 at 05:36:14PM -0400, Mel Henning wrote:
> > +int
> > +nouveau_abi16_ioctl_get_zcull_info(ABI16_IOCTL_ARGS)
> > +{
> > + struct nouveau_drm *drm = nouveau_drm(dev);
> > + struct nvkm_device *device = drm->nvkm;
> > + struct drm_nouveau_get_zcull_info *out = data;
> > +
> > + if (device->has_zcull_info) {
> > + *out = device->zcull_info;
>
> This needs copy_to_user().
Sorry, had the wrong context, drm_ioctl() should already take care of that.
next prev parent reply other threads:[~2025-03-20 18:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 21:36 [PATCH 0/2] drm/nouveau: ZCULL support Mel Henning
2025-03-12 21:36 ` [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO Mel Henning
2025-03-20 18:18 ` Danilo Krummrich
2025-03-20 18:37 ` Danilo Krummrich [this message]
2025-03-20 19:57 ` Ben Skeggs
2025-03-20 20:01 ` Danilo Krummrich
2025-03-25 23:40 ` M Henning
2025-03-27 12:56 ` Danilo Krummrich
2025-03-27 18:26 ` M Henning
2025-03-28 11:04 ` Danilo Krummrich
2026-02-05 0:43 ` Dave Airlie
2026-02-05 10:58 ` Danilo Krummrich
2025-03-21 22:06 ` M Henning
2025-03-27 13:51 ` Danilo Krummrich
2025-03-27 18:03 ` M Henning
2025-03-28 11:09 ` Danilo Krummrich
2026-02-05 1:16 ` Dave Airlie
2026-02-05 2:13 ` John Hubbard
2026-02-05 10:46 ` Danilo Krummrich
2025-03-12 21:36 ` [PATCH 2/2] drm/nouveau: DRM_NOUVEAU_SET_ZCULL_CTXSW_BUFFER Mel Henning
2025-03-20 18:34 ` Danilo Krummrich
2025-03-21 23:00 ` M Henning
2025-03-27 13:58 ` Danilo Krummrich
2025-03-27 19:01 ` M Henning
2025-03-28 11:48 ` Danilo Krummrich
2025-08-01 2:15 ` M Henning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9xgUY8YBTRuVHdm@pollux \
--to=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=faith.ekstrand@collabora.com \
--cc=kherbst@redhat.com \
--cc=lyude@redhat.com \
--cc=mhenning@darkrefraction.com \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox