From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29F56C7619A for ; Thu, 23 Mar 2023 12:47:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5A24710E1E4; Thu, 23 Mar 2023 12:47:11 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0FE0310E1E4 for ; Thu, 23 Mar 2023 12:47:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679575629; x=1711111629; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=30e+iacdeNDPi27w7ie3RbTMuGmuD+8WwfFs1tSEjl4=; b=jWjfCOBYmRWAdjKDtv5tnZ/SCAx3qehKa4plFgvMoXH55Pv2+Zh9YNDQ MH1P6Uv6GI54R31qVl9xTf7U+iUbJZAHikt8FUlrRtk+N8No5WOes9Ejz i9H+lXF3VkRc6p96TRP+inqXQa277jI2ipJt9NXqR2UE6pKjluorFMb2B yG8gHyFWRFQOwVRHZEznc0DJ8+gLkaMSTkekqoJOf47qNr+TcHrtR+AFE v2sahliIz3lBu4ycOa4bql9pLv3/mbx5bhGj+BNeMXv3z+oqAwxmeCix9 543TthXeV9c8BDFAaG8iFph3zu5zOnA9nQH0Kvb1hY1PjF1iZfzaJjaZ7 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="341013534" X-IronPort-AV: E=Sophos;i="5.98,283,1673942400"; d="scan'208";a="341013534" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2023 05:47:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="682292594" X-IronPort-AV: E=Sophos;i="5.98,283,1673942400"; d="scan'208";a="682292594" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP; 23 Mar 2023 05:46:58 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pfKLG-007VoD-1R; Thu, 23 Mar 2023 14:46:54 +0200 Date: Thu, 23 Mar 2023 14:46:54 +0200 From: Andy Shevchenko To: Dmitry Baryshkov Subject: Re: [PATCH v14 03/10] drm/display: Add Type-C switch helpers Message-ID: References: <20230322104639.221402-1-treapking@chromium.org> <20230322104639.221402-4-treapking@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heikki Krogerus , Andrzej Hajda , "Rafael J . Wysocki" , dri-devel@lists.freedesktop.org, Douglas Anderson , Laurent Pinchart , Krzysztof Kozlowski , Guenter Roeck , Marek Vasut , chrome-platform@lists.linux.dev, Robert Foss , YueHaibing , Javier Martinez Canillas , Jernej Skrabec , linux-acpi@vger.kernel.org, Andi Shyti , devicetree@vger.kernel.org, Sakari Ailus , =?iso-8859-1?Q?N=EDcolas_F_=2E_R_=2E_A_=2E?= Prado , Jonas Karlman , Jani Nikula , Allen Chen , Stephen Boyd , Pin-yen Lin , Rob Herring , Hsin-Yi Wang , Xin Ji , AngeloGioacchino Del Regno , Neil Armstrong , Thomas Zimmermann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Daniel Scally , Prashant Malani Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Mar 23, 2023 at 12:38:49AM +0200, Dmitry Baryshkov wrote: > On Wed, 22 Mar 2023 at 12:47, Pin-yen Lin wrote: ... > > +config DRM_DISPLAY_DP_TYPEC_HELPER > > + bool > > + default y > > + depends on DRM_DISPLAY_HELPER > > + depends on DRM_DISPLAY_HELPER=TYPEC || TYPEC=y > > If it is a select'able option, it doesn't make sense to use "depends" > here. Select will override depends. He-he, not so easy. This will help to find configurations that miss these dependencies. Arnd taught me that. IIRC the ASoC subsystem has a lot of such cases. > > + help > > + DRM display helpers for USB Type-C Displayport Alternate mode. -- With Best Regards, Andy Shevchenko