dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	Lihao Gu <lihao.gu@intel.com>,
	Andi Shyti <andi.shyti@linux.intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Intel GFX <intel-gfx@lists.freedesktop.org>,
	DRI Devel <dri-devel@lists.freedesktop.org>,
	Chris Wilson <chris@chris-wilson.co.uk>,
	Fei Yang <fei.yang@intel.com>, Carl Zhang <carl.zhang@intel.com>,
	Matt Roper <matthew.d.roper@intel.com>
Subject: Re: [PATCH v17 1/1] drm/i915: Allow user to set cache at BO creation
Date: Tue, 6 Jun 2023 13:14:53 +0200	[thread overview]
Message-ID: <ZH8VLY8a9d7i96cw@ashyti-mobl2.lan> (raw)
In-Reply-To: <168604992363.24014.14317865195655387952@jlahtine-mobl.ger.corp.intel.com>

> > > > To comply with the design that buffer objects shall have immutable
> > > > cache setting through out their life cycle, {set, get}_caching ioctl's
> > > > are no longer supported from MTL onward. With that change caching
> > > > policy can only be set at object creation time. The current code
> > > > applies a default (platform dependent) cache setting for all objects.
> > > > However this is not optimal for performance tuning. The patch extends
> > > > the existing gem_create uAPI to let user set PAT index for the object
> > > > at creation time.
> > > > The new extension is platform independent, so UMD's can switch to using
> > > > this extension for older platforms as well, while {set, get}_caching are
> > > > still supported on these legacy paltforms for compatibility reason.
> > > > However, since PAT index was not clearly defined for platforms prior to
> > > > GEN12 (TGL), so we are limiting this externsion to GEN12+ platforms
> > > > only. See ext_set_pat() in for the implementation details.
> > > > 
> > > > Note: The documentation related to the PAT/MOCS tables is currently
> > > > available for Tiger Lake here:
> > > > https://www.intel.com/content/www/us/en/docs/graphics-for-linux/developer-reference/1-0/tiger-lake.html
> > > > 
> > > > BSpec: 45101
> > > > 
> > > > Mesa support has been submitted in this merge request:
> > > > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22878
> > > > 
> > > > The media driver is supported by the following commits:
> > > > https://github.com/intel/media-driver/commit/92c00a857433ebb34ec575e9834f473c6fcb6341
> > > > https://github.com/intel/media-driver/commit/fd375cf2c5e1f6bf6b43258ff797b3134aadc9fd
> > > > https://github.com/intel/media-driver/commit/08dd244b22484770a33464c2c8ae85430e548000
> 
> Andi, let's still get these corrected before merging once the media-driver
> revert is completed.

Sure!

At least this doesn't need a new version to be respinned.

Please, Carl, link the new pull request and I will update the
commit log.

Andi

  reply	other threads:[~2023-06-06 11:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-06 10:00 [PATCH v17 0/1] drm/i915: Allow user to set cache at BO creation Andi Shyti
2023-06-06 10:00 ` [PATCH v17 1/1] " Andi Shyti
2023-06-06 10:10   ` Tvrtko Ursulin
2023-06-06 10:18     ` Andi Shyti
2023-06-06 11:12       ` Joonas Lahtinen
2023-06-06 11:14         ` Andi Shyti [this message]
2023-06-07  3:40           ` Zhang, Carl
2023-06-07  5:11             ` Andi Shyti
2023-06-07  5:21               ` Zhang, Carl
2023-06-09  9:59                 ` Andi Shyti
2023-06-09 15:12                   ` Yang, Fei
2023-06-11 14:43                     ` Zhang, Carl
2023-06-07 15:01   ` Andi Shyti
2023-06-07 15:46   ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZH8VLY8a9d7i96cw@ashyti-mobl2.lan \
    --to=andi.shyti@linux.intel.com \
    --cc=carl.zhang@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fei.yang@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=jordan.l.justen@intel.com \
    --cc=lihao.gu@intel.com \
    --cc=matthew.d.roper@intel.com \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).