From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 143AFC001DF for ; Wed, 2 Aug 2023 10:00:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4A49710E1EB; Wed, 2 Aug 2023 10:00:42 +0000 (UTC) X-Greylist: delayed 557 seconds by postgrey-1.36 at gabe; Wed, 02 Aug 2023 10:00:40 UTC Received: from honk.sigxcpu.org (honk.sigxcpu.org [24.134.29.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4DF5310E1EB for ; Wed, 2 Aug 2023 10:00:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id A27B5FB03; Wed, 2 Aug 2023 11:51:20 +0200 (CEST) Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ut6geAuGSTlo; Wed, 2 Aug 2023 11:51:19 +0200 (CEST) Date: Wed, 2 Aug 2023 11:51:17 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: David Heidelberg Subject: Re: [PATCH] dt-bindings: mxsfb: Exclude i.MX8MQ from power-domains requirement Message-ID: References: <20230730184120.94984-1-david@ixit.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230730184120.94984-1-david@ixit.cz> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Conor Dooley , devicetree@vger.kernel.org, Liu Ying , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Rob Herring , dri-devel@lists.freedesktop.org, Krzysztof Kozlowski , kernel@puri.sm Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On Sun, Jul 30, 2023 at 09:41:20PM +0300, David Heidelberg wrote: > i.MX8MQ uses as secondary compatible fsl,imx6sx-lcdif, which triggers > requirement of power-domains, thou it's not required. > > Fixes: f62678a77d58 ("dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property") > > Signed-off-by: David Heidelberg > --- > .../devicetree/bindings/display/fsl,lcdif.yaml | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > index fc11ab5fc465..2d868276b0f9 100644 > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > @@ -129,8 +129,15 @@ allOf: > - fsl,imx8mp-lcdif > - fsl,imx93-lcdif > then: > - required: > - - power-domains > + if: > + properties: > + compatible: > + not: > + contains: > + const: fsl,imx8mq-lcdif > + then: > + required: > + - power-domains We currently enable the mipi power domain for the mipi dphy and nwl bridge only but not for LCDIF itself assuming it's not needed (as there's other outputs LCDIF can drive). I *think* this is correct but maybe Marek or Liu can confirm? Cheers, -- Guido > > examples: > - | > -- > 2.40.1 >