From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DATE_IN_PAST_12_24, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82312C433DB for ; Fri, 12 Mar 2021 11:52:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32B7864EF0 for ; Fri, 12 Mar 2021 11:52:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32B7864EF0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=crapouillou.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 80DAF6F5D2; Fri, 12 Mar 2021 11:52:08 +0000 (UTC) Received: from aposti.net (aposti.net [89.234.176.197]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1263D6F5D2 for ; Fri, 12 Mar 2021 11:52:07 +0000 (UTC) Date: Thu, 11 Mar 2021 13:40:47 +0000 From: Paul Cercueil Subject: Re: [PATCH v2 5/5] drm/ingenic: Add option to alloc cached GEM buffers To: Christoph Hellwig Message-Id: In-Reply-To: <20210311123040.GD1739082@infradead.org> References: <20210307202835.253907-1-paul@crapouillou.net> <20210307202835.253907-6-paul@crapouillou.net> <20210311123040.GD1739082@infradead.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Zimmermann , David Airlie , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, od@zcrc.me, dri-devel@lists.freedesktop.org, Sam Ravnborg Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Le jeu. 11 mars 2021 =E0 12:30, Christoph Hellwig a = =E9crit : > On Sun, Mar 07, 2021 at 08:28:35PM +0000, Paul Cercueil wrote: >> With the module parameter ingenic-drm.cached_gem_buffers, it is = >> possible >> to specify that we want GEM buffers backed by non-coherent memory. > = > Shouldn't there be a way to discover this through a DT property? Good question. My original way of thinking was that as this feature = speeds up only software rendering, this is really = application-dependent: a modern desktop where everything is rendered = via the GPU wouldn't benefit much from it. With that in mind, it is = fine as a module option. On the other hand... the "software rendering is faster with = non-coherent buffers" really is a SoC property, since it is only true = for some generations of Ingenic SoCs and not others. So it would make = sense to have a DT property for it. -Paul _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel