From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6BBCEE49AA for ; Mon, 21 Aug 2023 12:35:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BF7F310E23D; Mon, 21 Aug 2023 12:35:37 +0000 (UTC) X-Greylist: delayed 464 seconds by postgrey-1.36 at gabe; Mon, 21 Aug 2023 12:35:35 UTC Received: from mail.8bytes.org (mail.8bytes.org [IPv6:2a01:238:42d9:3f00:e505:6202:4f0c:f051]) by gabe.freedesktop.org (Postfix) with ESMTP id 00E0210E23D; Mon, 21 Aug 2023 12:35:35 +0000 (UTC) Received: from 8bytes.org (pd9fe95be.dip0.t-ipconnect.de [217.254.149.190]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.8bytes.org (Postfix) with ESMTPSA id 14D6D28194F; Mon, 21 Aug 2023 14:27:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=8bytes.org; s=default; t=1692620870; bh=FixGPDbY1JGUzoXJGnGCpBH8LX7vfPyc85NTwmVIvZk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1GNfM2qXUHu69LlGLcBH8KY7o7o7XmY+SCrGkW/UUIs2KGTpDHXZZbMpPGz6QSYZs UPnFUxDcsVEY3pjS1DruthDw9f83ySojUQCSB+rWg+GUD0/AhHwU/y7CvGp4ChZNfv PF0U1t4Yrw0S3cKVt3Z1VBJMi6C4Yubn+JBgQ0h8akaCgHt2/SoukE6zqp52PyQtal mSBFlaAtIaUSfX6biqD/5UJPh1qGAUoCalqefQ1b2bqiPcVjHwugqG0e+YrG5Eef+K UDBnBPokoAbTS28F+RA/gZgu4I/tGuWG+hC4PlSSGwOqv9iwEYEE1WLsVZflD78r+Z CJt+ubMPFXzmw== Date: Mon, 21 Aug 2023 14:27:47 +0200 From: Joerg Roedel To: Robin Murphy Subject: Re: [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device() Message-ID: References: <0-v1-98d20e768c66+7-of_dma_lock_jgg@nvidia.com> <78114fd6-9b83-92ba-418f-6cc7bda9df9b@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <78114fd6-9b83-92ba-418f-6cc7bda9df9b@arm.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Emma Anholt , Kevin Tian , dri-devel@lists.freedesktop.org, Mikko Perttunen , Vikash Garodia , Chen-Yu Tsai , Thierry Reding , ath10k@lists.infradead.org, Andrzej Hajda , Marijn Suijten , Frank Rowand , Marek Szyprowski , Samuel Holland , Takashi Iwai , Sinan Kaya , Vinod Koul , Jernej Skrabec , iommu@lists.linux.dev, Andy Gross , Jason Gunthorpe , Russell King , Bryan O'Donoghue , ath11k@lists.infradead.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, Jaroslav Kysela , Joerg Roedel , Will Deacon , linux-arm-msm@vger.kernel.org, Kalle Valo , Chen-Yu Tsai , etnaviv@lists.freedesktop.org, Maxime Ripard , Abhinav Kumar , dmaengine@vger.kernel.org, Mark Brown , linux-tegra@vger.kernel.org, Mauro Carvalho Chehab , Sean Paul , linux-arm-kernel@lists.infradead.org, Jeff Johnson , Bjorn Andersson , Stanimir Varbanov , linux-wireless@vger.kernel.org, Liam Girdwood , linux-sunxi@lists.linux.dev, Konrad Dybcio , Rob Herring , Dmitry Baryshkov , Lu Baolu , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Aug 21, 2023 at 12:06:40PM +0100, Robin Murphy wrote: > The solution is to drop those locking patches entirely and rethink the whole > thing. Agreed, that was exactly what I thought when looking at this patch. I dropped the original 10 patches and the 4 fixes on-top from the IOMMU tree. This needs more investigation and adaption of the actual API users before it can be reconsidered. Regards, Joerg