From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A13D1C48BC3 for ; Tue, 20 Feb 2024 08:14:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DEC3A10E19C; Tue, 20 Feb 2024 08:14:04 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="hWAqPqIF"; dkim-atps=neutral Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id DAFC410E19C; Tue, 20 Feb 2024 08:14:03 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D89F8CE140C; Tue, 20 Feb 2024 08:14:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15A99C433F1; Tue, 20 Feb 2024 08:14:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708416841; bh=KMaiaCUm3bZGBK7I5/F1KQ3UkBMCQjLFXyGs6MrrrZU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hWAqPqIFYAZcp/X5cbUN4fXO8zQJX/f6D4UJtzxFT6y6m5gyG3oKuoyLyKCf6r6Np bHxHY+ewlI5Loa2rf5avoXxV7CrD6+ALSzIiHSWDVhHYjfzr8O7AlZOYCQ+5MF7fqv 5avMiRaq3S3N4IBGWssZdSlZbpiZED8r8rwXL3dA/xuPMaO3XXoym7jDw5qlYD75+r qTCuA0UYbEVEQ/dDDyvoTExr1WLTNadhOWBz6MI+2wm5we1NzvkYcklutzMXfXStn5 qRtBEHp4ZmitTxwcP/I3jc0w5avu3ifpbqNlHzrJDtbU055PBcjgSF0W1JJZxS9Vnc 7ap2cwluTBrzw== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rcLGJ-000000002QZ-0PDo; Tue, 20 Feb 2024 09:13:59 +0100 Date: Tue, 20 Feb 2024 09:13:59 +0100 From: Johan Hovold To: Rob Clark Cc: dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Rob Clark , Robin Murphy , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , Bjorn Andersson , Jordan Crouse , open list Subject: Re: [PATCH] drm/msm: Wire up tlb ops Message-ID: References: <20240213172340.228314-1-robdclark@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Feb 15, 2024 at 07:28:53AM -0800, Rob Clark wrote: > On Wed, Feb 14, 2024 at 11:34 PM Johan Hovold wrote: > > > > On Tue, Feb 13, 2024 at 09:23:40AM -0800, Rob Clark wrote: > > > From: Rob Clark > > > > > > The brute force iommu_flush_iotlb_all() was good enough for unmap, but > > > in some cases a map operation could require removing a table pte entry > > > to replace with a block entry. This also requires tlb invalidation. > > > Missing this was resulting an obscure iova fault on what should be a > > > valid buffer address. > > > > > > Thanks to Robin Murphy for helping me understand the cause of the fault. > > > > > > Cc: Robin Murphy > > > Fixes: b145c6e65eb0 ("drm/msm: Add support to create a local pagetable") > > > > Sounds like you're missing a > > > > Cc: stable@vger.kernel.org > > > > here? Or is there some reason not to backport this fix (to 5.9 and later > > kernels)? > > No reason, I just expected the Fixes tag was sufficient No, you should still mark patches intended for stable with an explicit CC-stable tag (as per the documentation). The fact that Sasha and his AI tries to catch fixes which the author and maintainer failed to tag as a fallback should not be relied upon. It also makes it harder for the stable team and others to determine what the intention with a fix was. Johan