From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29ABDC531DF for ; Tue, 20 Aug 2024 10:16:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A7CDC10E6A0; Tue, 20 Aug 2024 10:16:23 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="UAU9dh1E"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id 861DA10E6A0 for ; Tue, 20 Aug 2024 10:16:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724148982; x=1755684982; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=WT51twTaR9ldXwxgDFR3gWRncIayJMQMu6eY6+ge2zQ=; b=UAU9dh1ELItkbAgnRgMxQQN2fQYXMip5WaJNmZuFrQQDCUEHJlUU7SN0 gnuejz9DL4y3ybzebxl5xD8BBcqOQADbZp5AlLEAioQCFNH2L9wDdGFa6 8YRE+O6bXY+bmcT4xv1aPEyqTgjyKPOmyANpBnUw13fxBvuIVOoqxaK6Y gfk8sLBIqVZDRo+WjbsVaSVd9nIuORnYREfjBNoUFYbWufGSMqqLPc5P6 K1FhlFjO7PM+HduL+LRftSMJXUKnPNUImP8JmHxI8RzIjgSPFaN4bkhGi 1qv3RNdQ10Bs+AXVXuGgXEkOnpTvoBO1WeDDE1xSxb93I7Tm40U4TKMLS A==; X-CSE-ConnectionGUID: X09bqg6TQZmxsiJvGL5Yhw== X-CSE-MsgGUID: JPa8/7mlRP66BYRdYQhAbA== X-IronPort-AV: E=McAfee;i="6700,10204,11169"; a="47833058" X-IronPort-AV: E=Sophos;i="6.10,161,1719903600"; d="scan'208";a="47833058" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2024 03:16:22 -0700 X-CSE-ConnectionGUID: /kffWbRHSBaK1HncF991ag== X-CSE-MsgGUID: mDUg9YbGQk+CBo7MXYrpGg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,161,1719903600"; d="scan'208";a="91402041" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2024 03:16:13 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1sgLuL-0000000HGD8-4AYP; Tue, 20 Aug 2024 13:16:09 +0300 Date: Tue, 20 Aug 2024 13:16:09 +0300 From: Andy Shevchenko To: Stephen Boyd Cc: chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, patches@lists.linux.dev, devicetree@vger.kernel.org, Douglas Anderson , Pin-yen Lin , Andrzej Hajda , Benson Leung , Conor Dooley , Daniel Vetter , David Airlie , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, Guenter Roeck , Jernej Skrabec , Jonas Karlman , Krzysztof Kozlowski , Laurent Pinchart , Lee Jones , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Prashant Malani , Robert Foss , Rob Herring , Thomas Zimmermann , Tzung-Bi Shih , Alexandre Belloni , Daniel Scally , Greg Kroah-Hartman , Heikki Krogerus , Ivan Orlov , linux-acpi@vger.kernel.org, linux-usb@vger.kernel.org, Mika Westerberg , "Rafael J . Wysocki" , Sakari Ailus , Vinod Koul Subject: Re: [PATCH v3 05/17] usb: typec: Add device managed typec_switch_register() Message-ID: References: <20240819223834.2049862-1-swboyd@chromium.org> <20240819223834.2049862-6-swboyd@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240819223834.2049862-6-swboyd@chromium.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Aug 19, 2024 at 03:38:19PM -0700, Stephen Boyd wrote: > Simplify driver error paths by adding devm_typec_switch_register() which > will unregister the typec switch when the parent device is unbound. > Cc: Heikki Krogerus > Cc: Greg Kroah-Hartman > Cc: > Cc: Pin-yen Lin As per previous patches. ... > + ptr = devres_alloc(devm_typec_switch_unregister, sizeof(*ptr), GFP_KERNEL); > + if (!ptr) > + return ERR_PTR(-ENOMEM); > + > + switch_dev = typec_switch_register(parent ,desc); > + if (!IS_ERR(switch_dev)) { > + *ptr = switch_dev; > + devres_add(parent, ptr); > + } else { > + devres_free(ptr); > + } devm_add_action_or_reset() ? -- With Best Regards, Andy Shevchenko