From: Simona Vetter <simona.vetter@ffwll.ch>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: dri-devel@lists.freedesktop.org,
"Daniel Vetter" <daniel@ffwll.ch>,
"Marty E . Plummer" <hanetzer@startmail.com>,
"Rob Herring" <robh@kernel.org>,
"Clément Péron" <peron.clem@gmail.com>,
"Nicolas Boichat" <drinkcat@chromium.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Faith Ekstrand" <faith.ekstrand@collabora.com>,
"Daniel Stone" <daniels@collabora.com>,
"Liviu Dudau" <Liviu.Dudau@arm.com>,
"Steven Price" <steven.price@arm.com>,
"Robin Murphy" <robin.murphy@arm.com>,
kernel@collabora.com, "Heiko Stuebner" <heiko@sntech.de>,
"Tatsuyuki Ishi" <ishitatsuyuki@gmail.com>,
"Chris Diamand" <chris.diamand@foss.arm.com>,
"Ketil Johnsen" <ketil.johnsen@arm.com>,
"Maxime Ripard" <mripard@kernel.org>
Subject: Re: [PATCH v6 10/14] drm/panthor: Add the scheduler logical block
Date: Tue, 3 Sep 2024 21:43:48 +0200 [thread overview]
Message-ID: <Ztdm9EdoguXKxGMV@phenom.ffwll.local> (raw)
In-Reply-To: <20240229162230.2634044-11-boris.brezillon@collabora.com>
On Thu, Feb 29, 2024 at 05:22:24PM +0100, Boris Brezillon wrote:
> - Add our job fence as DMA_RESV_USAGE_WRITE to all external objects
> (was previously DMA_RESV_USAGE_BOOKKEEP). I don't get why, given
> we're supposed to be fully-explicit, but other drivers do that, so
> there must be a good reason
Just spotted this: They're wrong, or they're userspace is broken and
doesn't use the dma_buf fence import/export ioctl in all the right places.
For gl this simplifies things (but setting write fences when you're only
reading is still bad, and setting fences on buffers you don't even touch
is worse), for vulkan this is just bad.
I think you want a context creation flag for userspace that's not broken,
which goes back to USAGE_BOOKKEEP for everything.
-Sima
--
Simona Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2024-09-03 19:43 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 16:22 [PATCH v6 00/14] drm: Add a driver for CSF-based Mali GPUs Boris Brezillon
2024-02-29 16:22 ` [PATCH v6 01/14] drm/panthor: Add uAPI Boris Brezillon
2024-10-16 13:16 ` Erik Faye-Lund
2024-10-16 13:47 ` Boris Brezillon
2024-10-16 14:07 ` Erik Faye-Lund
2024-10-16 13:50 ` Erik Faye-Lund
2024-10-16 14:02 ` Robin Murphy
2024-10-16 14:05 ` Erik Faye-Lund
2024-10-16 14:18 ` Boris Brezillon
2024-10-17 8:51 ` Erik Faye-Lund
2024-10-17 10:08 ` Boris Brezillon
2024-10-17 10:15 ` Erik Faye-Lund
2024-10-17 18:34 ` Mihail Atanassov
2024-02-29 16:22 ` [PATCH v6 02/14] drm/panthor: Add GPU register definitions Boris Brezillon
2024-02-29 16:22 ` [PATCH v6 03/14] drm/panthor: Add the device logical block Boris Brezillon
2024-02-29 16:22 ` [PATCH v6 04/14] drm/panthor: Add the GPU " Boris Brezillon
2024-02-29 16:22 ` [PATCH v6 05/14] drm/panthor: Add GEM " Boris Brezillon
2024-02-29 16:22 ` [PATCH v6 06/14] drm/panthor: Add the devfreq " Boris Brezillon
2024-02-29 16:22 ` [PATCH v6 07/14] drm/panthor: Add the MMU/VM " Boris Brezillon
2024-02-29 16:22 ` [PATCH v6 08/14] drm/panthor: Add the FW " Boris Brezillon
2024-02-29 16:22 ` [PATCH v6 09/14] drm/panthor: Add the heap " Boris Brezillon
2024-02-29 16:22 ` [PATCH v6 10/14] drm/panthor: Add the scheduler " Boris Brezillon
2024-03-28 15:38 ` Nathan Chancellor
2024-03-28 15:51 ` Boris Brezillon
2024-09-03 19:43 ` Simona Vetter [this message]
2024-09-04 7:09 ` Boris Brezillon
2024-09-04 9:22 ` Simona Vetter
2024-09-04 8:45 ` Simona Vetter
2024-02-29 16:22 ` [PATCH v6 11/14] drm/panthor: Add the driver frontend block Boris Brezillon
2024-02-29 16:22 ` [PATCH v6 12/14] drm/panthor: Allow driver compilation Boris Brezillon
2024-02-29 16:22 ` [PATCH v6 13/14] dt-bindings: gpu: mali-valhall-csf: Add support for Arm Mali CSF GPUs Boris Brezillon
2024-02-29 16:22 ` [PATCH v6 14/14] drm/panthor: Add an entry to MAINTAINERS Boris Brezillon
2024-03-01 9:21 ` [PATCH v6 00/14] drm: Add a driver for CSF-based Mali GPUs Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ztdm9EdoguXKxGMV@phenom.ffwll.local \
--to=simona.vetter@ffwll.ch \
--cc=Liviu.Dudau@arm.com \
--cc=boris.brezillon@collabora.com \
--cc=chris.diamand@foss.arm.com \
--cc=daniel@ffwll.ch \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@chromium.org \
--cc=faith.ekstrand@collabora.com \
--cc=hanetzer@startmail.com \
--cc=heiko@sntech.de \
--cc=ishitatsuyuki@gmail.com \
--cc=kernel@collabora.com \
--cc=ketil.johnsen@arm.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=peron.clem@gmail.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox