From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA2ABD2F7D8 for ; Thu, 17 Oct 2024 00:26:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3948710E08A; Thu, 17 Oct 2024 00:26:51 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="IKwO1TkJ"; dkim-atps=neutral Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) by gabe.freedesktop.org (Postfix) with ESMTPS id 75C3910E133 for ; Thu, 17 Oct 2024 00:26:50 +0000 (UTC) Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-7ea999a79a2so400893a12.2 for ; Wed, 16 Oct 2024 17:26:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729124810; x=1729729610; darn=lists.freedesktop.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=PC4Hs0E5dBLkCnCinTPyvf/aLxRI0UAFEABy+KMCotw=; b=IKwO1TkJe+Wi+aYQIlBP3YMbSXxPFV0pSF+tgtdYl+JFnCjVJMs6euloEPqB3xiznP RMhZewZT243ttTL80bGdySDtpx38+5+tQ7yZ80aLRu8O3m2aCGThIIbkp6X7PZJsxp43 ZjTzwmjha0+0adVpaqOMNoke7oxmrnvM+Zoxx6R0dgkTSfZ0OFm8tbFB9ViqPnyybXDg LJszCrl2yEPiL6fQ7yxZ1h4pueOSGDRFAXN9jyJFNSJL1vgGc/ceghnmdGTGE8Gf37JM ImSCqbzRSB+qfAs5vyeKrQZWunjPKs2WrLHJxImmMjgmINrgJGRKtYxyVen1QgvS2yIV w2pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729124810; x=1729729610; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PC4Hs0E5dBLkCnCinTPyvf/aLxRI0UAFEABy+KMCotw=; b=sKOYIEKPci0WEGx4USOaONLXhm55s4HFkhhQrJPHEbcgAjnjCHQQRS8AdcrghuVPFx ChZYaFdbZQLhSpCEd1OkIQRmtbRwcWuxQbWHYlST68DLpCk0K5/tsE6PQC7IfU4LfKzh VlaB7U9kJRN7KbSkA30n9WpU2S57XaUg5NVWAhINoE48TI/nm/em2DgANFRY1gAyy/8h b/qjPKs8vtwe84Fbh83WCRGiEoetFAaCEW+kmrRh6SgwA05U4ddGmvBaWqoZseD5NJsQ Pfy9jtScQTCMyKqvs+MpxY8wqAq56DWP2dPJQ+/qOdNxWpkWP/LSJ8JLxPh5ae+XW0bM ZsVw== X-Forwarded-Encrypted: i=1; AJvYcCVbocIRETnVoAng8NoDuRTXQr9bTfJjDicnsu5ZXHFCEFhyvOdEFsld8fnu3z6eqh2fOSYVulE4zpk=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yzw/YAaof87t+GeYcMAkl+6PlFhHpPfvz9nNCR9XqGlvZYw94hF nV21IrEU4vXeFQSj5FIjC8uA7yQkJD7TvV61LBrwVwNn3LluzManzxuNTQ3/9KY1lSN1PzrIVlG P5Q== X-Google-Smtp-Source: AGHT+IHcZEDYoFZqO9vMeq+B+EvG4lcuq/J99qdXry7nLvP1k/6cQ8eP6ZnNUNNOwC4IGrsVzTHyGmuCdRY= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:9d:3983:ac13:c240]) (user=seanjc job=sendgmr) by 2002:a63:ef50:0:b0:7ea:7907:7076 with SMTP id 41be03b00d2f7-7eaa6c965a9mr6883a12.6.1729124809640; Wed, 16 Oct 2024 17:26:49 -0700 (PDT) Date: Wed, 16 Oct 2024 17:26:47 -0700 In-Reply-To: <20241015152157.2955229-1-arnd@kernel.org> Mime-Version: 1.0 References: <20241015152157.2955229-1-arnd@kernel.org> Message-ID: Subject: Re: [PATCH] i915: fix DRM_I915_GVT_KVMGT dependencies From: Sean Christopherson To: Arnd Bergmann Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Paolo Bonzini , Arnd Bergmann , Maxime Ripard , Geert Uytterhoeven , Imre Deak , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Oct 15, 2024, Arnd Bergmann wrote: > From: Arnd Bergmann > > Depending on x86 and KVM is not enough, as the kvm helper functions > that get called here are controlled by CONFIG_KVM_X86, which is > disabled if both KVM_INTEL and KVM_AMD are turned off. > > ERROR: modpost: "kvm_write_track_remove_gfn" [drivers/gpu/drm/i915/kvmgt.ko] undefined! > ERROR: modpost: "kvm_page_track_register_notifier" [drivers/gpu/drm/i915/kvmgt.ko] undefined! > ERROR: modpost: "kvm_page_track_unregister_notifier" [drivers/gpu/drm/i915/kvmgt.ko] undefined! > ERROR: modpost: "kvm_write_track_add_gfn" [drivers/gpu/drm/i915/kvmgt.ko] undefined! > > Change the dependency to CONFIG_KVM_X86 instead. > > Fixes: ea4290d77bda ("KVM: x86: leave kvm.ko out of the build if no vendor module is requested") > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/i915/Kconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig > index 46301c06d18a..985cb78d8256 100644 > --- a/drivers/gpu/drm/i915/Kconfig > +++ b/drivers/gpu/drm/i915/Kconfig > @@ -118,9 +118,8 @@ config DRM_I915_USERPTR > config DRM_I915_GVT_KVMGT > tristate "Enable KVM host support Intel GVT-g graphics virtualization" > depends on DRM_I915 > - depends on X86 > + depends on KVM_X86 Can GVT-g even work on non-Intel CPUs? I.e. would it make sense to take a dependency on KVM_INTEL? > depends on 64BIT > - depends on KVM > depends on VFIO > select DRM_I915_GVT > select KVM_EXTERNAL_WRITE_TRACKING > -- > 2.39.5 >