From: Ben Skeggs <skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [RFC PATCH 0/3] drm/nouveau/dispnv04 overlay and primary fb format fixes
Date: Sat, 20 May 2017 15:47:44 +1000 [thread overview]
Message-ID: <a0dd895d-02f8-4d80-3a75-549f80e7b00a@gmail.com> (raw)
In-Reply-To: <20170520025749.9291-1-imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
On 05/20/2017 12:57 PM, Ilia Mirkin wrote:
> This came out of some debugging I was doing to figure out how BE mode works
> on this hardware. Among other things, it came out that we're not exposing
> 16-bpp mode support and that the ARGB8888 mode that we do expose is broken.
> Also the overlay logic was pretty broken, I must have only tested with very
> "normal" overlay buffer sizes with modetest before.
>
> That said, this code has only received literal testing on a NV34/G5 PPC combo.
> I was poking at various registers on a NV34/x86 to make modetest display the
> correct data though. That's where e.g. the pitch mask comes from.
>
> I haven't at all tested on my NV05 or NV1x hardware. Should probably do that
> before we push this out. But since I've already been sitting on these patches
> for a few weeks, thought I'd get them out there.
The patches look fine to me, but I can wait to merge them until you've
tested the older HW if you prefer.
Ben.
>
> Ilia Mirkin (3):
> drm/nouveau/overlay: improve error detection, fix pitch setting
> drm/nouveau/overlay: add NV21 support
> drm/nouveau/dispnv04: fix exposed format list
>
> drivers/gpu/drm/nouveau/dispnv04/crtc.c | 36 +++++++++++-
> drivers/gpu/drm/nouveau/dispnv04/overlay.c | 89 +++++++++++++++++++-----------
> 2 files changed, 93 insertions(+), 32 deletions(-)
>
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
prev parent reply other threads:[~2017-05-20 5:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-20 2:57 [RFC PATCH 0/3] drm/nouveau/dispnv04 overlay and primary fb format fixes Ilia Mirkin
2017-05-20 2:57 ` [RFC PATCH 1/3] drm/nouveau/overlay: improve error detection, fix pitch setting Ilia Mirkin
2017-05-20 2:57 ` [RFC PATCH 3/3] drm/nouveau/dispnv04: fix exposed format list Ilia Mirkin
[not found] ` <20170520025749.9291-1-imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
2017-05-20 2:57 ` [RFC PATCH 2/3] drm/nouveau/overlay: add NV21 support Ilia Mirkin
2017-05-20 5:47 ` Ben Skeggs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0dd895d-02f8-4d80-3a75-549f80e7b00a@gmail.com \
--to=skeggsb-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).