From: "Christian König" <christian.koenig@amd.com>
To: Dave Airlie <airlied@gmail.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 1/2] drm/ttm: init mem->bus in common code.
Date: Tue, 11 Aug 2020 10:53:27 +0200 [thread overview]
Message-ID: <a1839a2a-75e5-5a3d-fa24-2ae684d11d1b@amd.com> (raw)
In-Reply-To: <CAPM=9tzgiwR3kLKo92ncAL+D7dxJbSNVA6BUF8Pic7-NM_8vDg@mail.gmail.com>
Am 11.08.20 um 10:49 schrieb Dave Airlie:
> On Tue, 11 Aug 2020 at 18:42, Christian König
> <ckoenig.leichtzumerken@gmail.com> wrote:
>> I've totally missed those and still don't see any reference in any inbox
>> to the original mail or patch #2 in this series.
> I forgot to cc you on the original posting, but they should be on dri-devel
>
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.freedesktop.org%2Fseries%2F80517%2F&data=02%7C01%7Cchristian.koenig%40amd.com%7C9ba8068c644a495b35a308d83dd37b82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637327326072901891&sdata=YoLRGkStydOIQEZUL7rq1Om58uSNu6wj7bYy7yEshbw%3D&reserved=0
Reviewed-by: Christian König <christian.koenig@amd.com> for both.
>> But this patch at least looks like it makes a lot of sense.
>>
>> BTW: Does anybody know why we separate base and offset here? That
>> distinction seems to be superfluous as well.
> I think base is only used for premapped objects,
Yeah, but take a look how it is used. As far as I know we don't have a
single case where we don't do "mem->bus.base + mem->bus.offset".
If that's true (needs double checking) then why the heck do we have two
fields for this?
Regards,
Christian.
>
> Dave.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-08-11 8:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 7:46 [PATCH 1/2] drm/ttm: init mem->bus in common code Dave Airlie
2020-08-11 7:46 ` [PATCH 2/2] drm/ttm: drop bus.size from bus placement Dave Airlie
2020-08-11 8:02 ` [PATCH 1/2] drm/ttm: init mem->bus in common code Dave Airlie
2020-08-11 8:42 ` Christian König
2020-08-11 8:49 ` Dave Airlie
2020-08-11 8:53 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1839a2a-75e5-5a3d-fa24-2ae684d11d1b@amd.com \
--to=christian.koenig@amd.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox