From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mukesh Ojha Subject: Re: [PATCH] gpu: v3d: fix a missing check of pm_runtime_get_sync Date: Wed, 27 Mar 2019 20:39:22 +0530 Message-ID: References: <20190324231602.2436-1-kjlu@umn.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190324231602.2436-1-kjlu@umn.edu> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Kangjie Lu Cc: pakki001@umn.edu, Eric Anholt , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On 3/25/2019 4:46 AM, Kangjie Lu wrote: > pm_runtime_get_sync could fail and thus deserves a check. > > The patch adds such a check and return its error code upstream > if it indeed failed. > > Signed-off-by: Kangjie Lu Reviewed-by: Mukesh Ojha -Mukesh > --- > drivers/gpu/drm/v3d/v3d_drv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c > index f0afcec72c34..99daad11fac2 100644 > --- a/drivers/gpu/drm/v3d/v3d_drv.c > +++ b/drivers/gpu/drm/v3d/v3d_drv.c > @@ -101,6 +101,8 @@ static int v3d_get_param_ioctl(struct drm_device *dev, void *data, > return -EINVAL; > > ret = pm_runtime_get_sync(v3d->dev); > + if (ret < 0) > + return ret; > if (args->param >= DRM_V3D_PARAM_V3D_CORE0_IDENT0 && > args->param <= DRM_V3D_PARAM_V3D_CORE0_IDENT2) { > args->value = V3D_CORE_READ(0, offset);