From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8483C4332F for ; Tue, 5 Oct 2021 23:04:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CA92611C3 for ; Tue, 5 Oct 2021 23:04:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8CA92611C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 574286E471; Tue, 5 Oct 2021 23:04:58 +0000 (UTC) Received: from so254-9.mailgun.net (so254-9.mailgun.net [198.61.254.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 50F646E471 for ; Tue, 5 Oct 2021 23:04:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1633475096; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=uG0DDsxj9ZrKdIW3DNhGgroyzNQbGUiq4kmEFJgIQnA=; b=ZHW9sMDmBO5WzsLLmLVRx0m3f8VV5OK21IK4m9E2docClsc883APBjwUVziPgNT2yoRHERY+ 3tqUTj4HGw10ga7o+E4Kr8Pjf9SyipYMyN8VozZhPEWv+uVv0GJh31aN/JOWk3n1l6hu7nU/ 6ToFeXxz16Nqn24Ek82AiRu3CCM= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-east-1.postgun.com with SMTP id 615cda099ebaf35aaa7a3f1e (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 05 Oct 2021 23:04:41 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 42482C4360C; Tue, 5 Oct 2021 23:04:41 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: khsieh) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5212FC4338F; Tue, 5 Oct 2021 23:04:40 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 05 Oct 2021 16:04:40 -0700 From: khsieh@codeaurora.org To: Stephen Boyd Cc: Bjorn Andersson , Abhinav Kumar , Daniel Vetter , David Airlie , Dmitry Baryshkov , Rob Clark , Sean Paul , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sankeerth Billakanti Subject: Re: [PATCH] drm/msm/dp: Shorten SETUP timeout In-Reply-To: References: <20211005023750.2037631-1-bjorn.andersson@linaro.org> Message-ID: X-Sender: khsieh@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2021-10-05 15:36, Stephen Boyd wrote: > Quoting Bjorn Andersson (2021-10-05 14:40:38) >> On Tue 05 Oct 11:45 PDT 2021, Stephen Boyd wrote: >> >> > Quoting Bjorn Andersson (2021-10-04 19:37:50) >> > > Found in the middle of a patch from Sankeerth was the reduction of the >> > > INIT_SETUP timeout from 10s to 100ms. Upon INIT_SETUP timeout the host >> > > is initalized and HPD interrupt start to be serviced, so in the case of >> > > eDP this reduction improves the user experience dramatically - i.e. >> > > removes 9.9s of bland screen time at boot. >> > > >> > > Suggested-by: Sankeerth Billakanti >> > > Signed-off-by: Bjorn Andersson >> > > --- >> > >> > Any Fixes tag? BTW, the delay design is pretty convoluted. I had to go >> > re-read the code a couple times to understand that it's waiting 100ms >> > times the 'delay' number. Whaaaaat? >> > >> >> I assume you're happy with the current 10s delay on the current >> devices, so I don't think we should push for this to be backported. >> I have no need for it to be backported on my side at least. >> > > Sure. Fixes tag != backported to stable trees but it is close. > >> > Reviewed-by: Stephen Boyd >> dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 1); <== to 100ms This patch will prevent usb3 from working due to dp driver initialize phy earlier than usb3 which cause timeout error at power up usb3 phy when both edp and dp are enabled. I had prepared a patch (drm/msm/dp: do not initialize combo phy until plugin interrupt) to fix this problem. Unfortunately, my patch is depend on Bjorn's patch (PATCH v3 3/5] drm/msm/dp: Support up to 3 DP controllers). I will submit my patch for review once Bjorn's patches merged in. Therefore I would think this patch should go after both Bjorn's patches and my patch.