From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B16FAC433EF for ; Mon, 4 Oct 2021 23:33:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C1636139E for ; Mon, 4 Oct 2021 23:33:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7C1636139E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A4A946EAB6; Mon, 4 Oct 2021 23:33:45 +0000 (UTC) Received: from m43-7.mailgun.net (m43-7.mailgun.net [69.72.43.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id 179CD6EAB6 for ; Mon, 4 Oct 2021 23:33:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1633390424; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=xKw3S4eVAnAe0PZH7ljLCajrK3JGrlSAHfv8BQOXCQQ=; b=RFiIpfVt5pabNYZ4BMJFvJ0BEkbUvPsBEDISj0/7J8NfZF1vvVzhjncPzpgDUfTDfPf2IKkB XhllFWcFXt9oQzzhi/ujEaRFxtSnWLD9j9f0j+O0YWAV6QmGA6OtoSDsapyBXQeihwPu380C FyqxqKO4DLq5e1EhJo+jIvW3L2Q= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-west-2.postgun.com with SMTP id 615b8f400d9325367bc6aaad (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 04 Oct 2021 23:33:20 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 7D63CC43617; Mon, 4 Oct 2021 23:33:20 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id 91DDAC4360C; Mon, 4 Oct 2021 23:33:19 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 04 Oct 2021 16:33:19 -0700 From: abhinavk@codeaurora.org To: Dan Carpenter Cc: Rob Clark , Jordan Crouse , Sean Paul , David Airlie , Daniel Vetter , Dmitry Baryshkov , Viresh Kumar , Bjorn Andersson , Kalyan Thota , Xu Wang , Jonathan Marek , Yangtao Li , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] drm/msm: potential error pointer dereference in init() In-Reply-To: <20211004103806.GD25015@kili> References: <20211004103806.GD25015@kili> Message-ID: X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2021-10-04 03:38, Dan Carpenter wrote: > The msm_iommu_new() returns error pointers on failure so check for that > to avoid an Oops. > > Fixes: ccac7ce373c1 ("drm/msm: Refactor address space initialization") > Signed-off-by: Dan Carpenter Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > index ae48f41821cf..ad247c06e198 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > @@ -908,6 +908,10 @@ static int _dpu_kms_mmu_init(struct dpu_kms > *dpu_kms) > return 0; > > mmu = msm_iommu_new(dpu_kms->dev->dev, domain); > + if (IS_ERR(mmu)) { > + iommu_domain_free(domain); > + return PTR_ERR(mmu); > + } > aspace = msm_gem_address_space_create(mmu, "dpu1", > 0x1000, 0x100000000 - 0x1000);