From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5547EC43458 for ; Mon, 13 Jul 2026 07:19:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AE88810E80A; Mon, 13 Jul 2026 07:19:29 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="d23nhjKj"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6166410E7FF for ; Mon, 13 Jul 2026 07:19:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1783927168; x=1815463168; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=jjkX6skS1BnhEPp8swizUU2qdy7wtOhKZC1/ORcIUy8=; b=d23nhjKjJdb/Xgt2AnlZFj3WT3MYX7fI9PE8UARxphNiVH1LpiHyzpW4 H0WEPqx98zidCiVWiAlgNrm6QToQiEybelq5sZGgsoxQYa7wVX5Hzl9Q7 rdl/0xDenJL7ykSARiVYw+k8XjpLX/48j4sPro0SdUQX2NCYyxOMmwIsI BH+4fW9LfZv7xZSVs2fqMwd1fKhkZZ1CAcAm1wAxMvcqrBgVzotV90W+L 3Fa+NfcOop3UhpbLv5mUl5VmDBsyUR5xeJed9rfVpeHgbZ33pJcD8sP5K 4JZndYrfcusVjOWv2TvMDnsqpwEb/PJjc5J+MURZEiXnExIQreZkLbl5R A==; X-CSE-ConnectionGUID: LhzWv93RSy6PUzUfizr1TQ== X-CSE-MsgGUID: kUyvy6sbQfyCVB26k0vk1g== X-IronPort-AV: E=McAfee;i="6800,10657,11841"; a="95129563" X-IronPort-AV: E=Sophos;i="6.25,154,1779174000"; d="scan'208";a="95129563" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2026 00:19:28 -0700 X-CSE-ConnectionGUID: 9RdXpTHCQJ+jdHmJswiwhg== X-CSE-MsgGUID: p5zreXVITDmzmjg1x8mGNg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,154,1779174000"; d="scan'208";a="249106622" Received: from soc-5cg43972ff.clients.intel.com (HELO [10.102.88.196]) ([10.102.88.196]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2026 00:19:27 -0700 Message-ID: Date: Mon, 13 Jul 2026 09:18:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] accel/ivpu: Fix wrong register read in LNL failure diagnostics To: Karol Wachowski , dri-devel@lists.freedesktop.org References: <20260710101331.1899505-1-karol.wachowski@linux.intel.com> Content-Language: en-US From: Andrzej Kacprowski In-Reply-To: <20260710101331.1899505-1-karol.wachowski@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 10-Jul-26 12:13 PM, Karol Wachowski wrote: > diagnose_failure_lnl() read VPU_HW_BTRS_MTL_INTERRUPT_STAT instead of > VPU_HW_BTRS_LNL_INTERRUPT_STAT, which on LNL and newer parts is a > different register with a different bit layout, so failure diagnostics > decoded the wrong register and reported a bogus error cause. > Read the LNL interrupt status register instead. > > Fixes: 8a27ad81f7d3 ("accel/ivpu: Split IP and buttress code") > Signed-off-by: Karol Wachowski > --- > drivers/accel/ivpu/ivpu_hw_btrs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/accel/ivpu/ivpu_hw_btrs.c b/drivers/accel/ivpu/ivpu_hw_btrs.c > index dac935164e11..a17c829adb89 100644 > --- a/drivers/accel/ivpu/ivpu_hw_btrs.c > +++ b/drivers/accel/ivpu/ivpu_hw_btrs.c > @@ -927,7 +927,7 @@ static void diagnose_failure_mtl(struct ivpu_device *vdev) > > static void diagnose_failure_lnl(struct ivpu_device *vdev) > { > - u32 reg = REGB_RD32(VPU_HW_BTRS_MTL_INTERRUPT_STAT) & BTRS_LNL_IRQ_MASK; > + u32 reg = REGB_RD32(VPU_HW_BTRS_LNL_INTERRUPT_STAT) & BTRS_LNL_IRQ_MASK; > > if (REG_TEST_FLD(VPU_HW_BTRS_LNL_INTERRUPT_STAT, ATS_ERR, reg)) { > ivpu_err(vdev, "ATS_ERR_LOG1 0x%08x ATS_ERR_LOG2 0x%08x\n", Reviewed-by: Andrzej Kacprowski