From: Danilo Krummrich <dakr@kernel.org>
To: Fanhua Li <lifanhua5@huawei.com>
Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
liuyongqiang13@huawei.com, lyude@redhat.com, airlied@gmail.com,
simona@ffwll.ch, airlied@redhat.com,
linux-kernel@vger.kernel.org, suhui@nfschina.com
Subject: Re: [PATCH] drm/nouveau/nvif: Fix potential memory leak in nvif_vmm_ctor().
Date: Sat, 9 Aug 2025 14:38:21 +0200 [thread overview]
Message-ID: <a657ead8-7f2c-4165-9a4c-ce4d82ea2adc@kernel.org> (raw)
In-Reply-To: <20250728115027.50878-1-lifanhua5@huawei.com>
On 7/28/25 1:50 PM, Fanhua Li wrote:
> When the nvif_vmm_type is invalid, we will return error directly
> without freeing the args in nvif_vmm_ctor(), which leading a memory
> leak. Fix it by setting the ret -EINVAL and goto done.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/all/202312040659.4pJpMafN-lkp@intel.com/
> Fixes: 6b252cf42281 ("drm/nouveau: nvkm/vmm: implement raw ops to manage uvmm")
> Signed-off-by: Fanhua Li <lifanhua5@huawei.com>
Applied to drm-misc-fixes, thanks!
prev parent reply other threads:[~2025-08-09 12:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 11:50 [PATCH] drm/nouveau/nvif: Fix potential memory leak in nvif_vmm_ctor() Fanhua Li
2025-08-09 12:38 ` Danilo Krummrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a657ead8-7f2c-4165-9a4c-ce4d82ea2adc@kernel.org \
--to=dakr@kernel.org \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lifanhua5@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyongqiang13@huawei.com \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
--cc=simona@ffwll.ch \
--cc=suhui@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).