From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [Intel-gfx] [PATCH] drm/atomic: Try to preserve the crtc enabled state in drm_atomic_remove_fb, v2. Date: Thu, 2 Nov 2017 09:55:40 +0100 Message-ID: References: <20171101150433.10777-1-maarten.lankhorst@linux.intel.com> <20171101152903.GF10981@intel.com> <20171101170019.GG10981@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20171101170019.GG10981@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T3AgMDEtMTEtMTcgb20gMTg6MDAgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gT24gV2VkLCBO b3YgMDEsIDIwMTcgYXQgMDQ6NTU6MDZQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6 Cj4+IE9wIDAxLTExLTE3IG9tIDE2OjI5IHNjaHJlZWYgVmlsbGUgU3lyasOkbMOkOgo+Pj4gT24g V2VkLCBOb3YgMDEsIDIwMTcgYXQgMDQ6MDQ6MzNQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9yc3Qg d3JvdGU6Cj4+Pj4gVGhpcyBpbnRyb2R1Y2VzIGEgc2xpZ2h0IGJlaGF2aW9yYWwgY2hhbmdlIHRv IHJtZmIuIEluc3RlYWQgb2YKPj4+PiBkaXNhYmxpbmcgYSBjcnRjIHdoZW4gdGhlIHByaW1hcnkg cGxhbmUgaXMgZGlzYWJsZWQsIHdlIHRyeSB0bwo+Pj4+IHByZXNlcnZlIGl0Lgo+Pj4+Cj4+Pj4g QXBhcnQgZnJvbSBvbGQgdmVyc2lvbnMgb2YgdGhlIHZtd2dmeCB4b3JnIGRyaXZlciwgdGhlcmUg aXMKPj4+PiBub3RoaW5nIGRlcGVuZGluZyBvbiBybWZiIGRpc2FibGluZyBhIGNydGMuCj4+Pj4K Pj4+PiBWbXdnZngnIGFuZCBzaW1wbGUga21zIGhlbHBlciBhdG9taWMgaW1wbGVtZW50YXRpb24g cmVqZWN0cyBDUlRDCj4+Pj4gZW5hYmxlZCB3aXRob3V0IHBsYW5lLCBzbyB3ZSBjYW4gZG8gdGhp cyBzYWZlbHkuCj4gVGhlIGNvZGUgZm9yIHRob3NlIHNlZW1zIGEgYml0IGluY29uc2lzdGVudC4g VGhlIGNydGMgY2hlY2sgcmVxdWlyZXMKPiB0aGF0IHRoZSBjcnRjIHN0YXRlIGFuZCBwbGFuZSBz dGF0ZSBtYXRjaC4gQnV0IHRoZSBwbGFuZSBjaGVjayBhbGxvd3MKPiB0aGUgcGxhbmUgdG8gYmUg ZW5hYmxlZCB3L28gdGhlIGNydGMgYmVpbmcgZW5hYmxlZC4gSSBndWVzcyBpdCBkb2Vzbid0Cj4g bWF0dGVyIHJlYWxseSBzaW5jZSB5b3UgY2FuJ3QgZW5hYmxlIHRoZSBwbGFuZSB3aXRob3V0IGEg Y3J0YywgYW5kIHRoZQo+IGNydGMgY2hlY2sgd291bGQgdGhlbiBjYXRjaCB0aGUgY2FzZSB3aGVy ZSB0aGUgY3J0YyB3b3VsZCBiZSBkaXNhYmxlZC4KCkV4YWN0bHkuIDotKSBPbmx5IHdoZW4gYSBw bGFuZSBpcyB1bmJvdW5kIGFuZCBzdGF5cyB1bmJvdW5kLCB0aGUgY3J0YyBjaGVjayB3b24ndApi ZSBpbnZva2VkLiBIZW5jZSBpdCdzIHRoZSBtb3N0IGFjY3VyYXRlIHdheSBvZiBtYWtpbmcgc3Vy ZSB0aGF0CmNydGMgZW5hYmxlZCA8PT4gcHJpbWFyeSBwbGFuZSBib3VuZC4KCklmIHRoZSBjaGVj ayB3YXMgZG9uZSBpbiB0aGUgcHJpbWFyeSBwbGFuZSwgYW4gYXRvbWljIG1vZGVzZXQgY291bGQg ZW5hYmxlCnRoZSBjcnRjIHdpdGhvdXQgZW5hYmxpbmcgdGhlIHByaW1hcnkgcGxhbmUsIHdoaWNo IHNob3VsZG4ndCBiZSBhbGxvd2VkIGJ1dAphIHBsYW5lIGNoZWNrIHdvbid0IGNhdGNoIGl0LgoK VGhpcyBoYXMgYmVlbiBhIGJ1ZyBpbiBzaW1wbGUta21zLWhlbHBlciwgZml4ZWQgaW4gdGhlIGJl bG93IGNvbW1pdDoKCmNvbW1pdCA3NjU4MzFkYzI3YWIxNDFiM2EwYmUxYWI1NWI5MjJiMDEyNDI3 OTAyCkF1dGhvcjogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4Lmlu dGVsLmNvbT4KRGF0ZTogICBXZWQgSnVsIDEyIDEwOjEzOjI5IDIwMTcgKzAyMDAKCiAgICBkcm0v c2ltcGxlLWttcy1oZWxwZXI6IEZpeCB0aGUgY2hlY2sgZm9yIHRoZSBtaXNtYXRjaCBiZXR3ZWVu IHBsYW5lIGFuZCBDUlRDIGVuYWJsZWQuCgo+IE9oIGFuZCBsb29rcyBsaWtlIGRybV9wbGFuZV9o ZWxwZXJfY2hlY2tfc3RhdGUoKSBpcyBhIGJpdCBidWdneS4gSXQKPiBzdGlsbCB1c2VzIGNydGMt PmVuYWJsZWQgaW5zdGVhZCBvZiBjcnRjX3N0YXRlLT5lbmFibGUgdG8gY2hlY2sgdGhlCj4gc3Rh dGUgb2YgdGhlIGNydGMuIEkgZ3Vlc3MgdG8ga2VlcCBkcm1fcGxhbmVfaGVscGVyX2NoZWNrX3Vw ZGF0ZSgpCj4gd29ya2luZyB3ZSBtYXkgaGF2ZSB0byBwYXNzIGluIHRoZSBjcnRjIHN0YXRlIG1h bnVhbGx5Lgo+Cj4gVGhlIHZtd2dmeCBwbGFuZSBjaGVjayBsb29rcyBhIGJpdCBib2d1cyBpbiBv dGhlciB3YXlzIHRvby4gSSBndWVzcwo+IEknbGwgaGF2ZSB0byBmaXJlIG9mZiBhIGNvdXBsZSBv ZiBwYXRjaGVzLgo+Cj4+Pj4gSWYgdGhlIGF0b21pYyBjb21taXQgaXMgcmVqZWN0ZWQgYnkgdGhl IGRyaXZlciB0aGVuIHdlIHdpbGwgc3RpbGwKPj4+PiBmYWxsIGJhY2sgdG8gdGhlIG9sZCBiZWhh dmlvciBhbmQgdHVybiBvZmYgdGhlIGNydGMuCj4+Pj4KPj4+PiBDaGFuZ2VzIHNpbmNlIHYxOgo+ Pj4+IC0gUmVzdGFydCBjb21wbGV0ZWx5IHdoZW4gcm1mYiB3aXRoIGNydGMgb24gZmFpbHMgKFNl YW4gUGF1bCkuCj4+Pj4KPj4+PiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFh cnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+Pj4+IENjOiBTZWFuIFBhdWwgPHNlYW5w YXVsQGNocm9taXVtLm9yZz4KPj4+PiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBm ZndsbC5jaD4KPj4+PiAtLS0KPj4+PiAgZHJpdmVycy9ncHUvZHJtL2RybV9mcmFtZWJ1ZmZlci5j IHwgMjMgKysrKysrKysrKysrKysrKystLS0tLS0KPj4+PiAgMSBmaWxlIGNoYW5nZWQsIDE3IGlu c2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4+Pj4KPj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2RybV9mcmFtZWJ1ZmZlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9mcmFtZWJ1 ZmZlci5jCj4+Pj4gaW5kZXggMmFmZmU1M2YzZmRhLi5mMDY3OTQ2OGY0MjEgMTAwNjQ0Cj4+Pj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9mcmFtZWJ1ZmZlci5jCj4+Pj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2RybV9mcmFtZWJ1ZmZlci5jCj4+Pj4gQEAgLTc2NSwxNCArNzY1LDE4IEBAIHN0 YXRpYyBpbnQgYXRvbWljX3JlbW92ZV9mYihzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYikKPj4+ PiAgCXN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lOwo+Pj4+ICAJc3RydWN0IGRybV9jb25uZWN0b3Ig KmNvbm47Cj4+Pj4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqY29ubl9zdGF0ZTsKPj4+ PiAtCWludCBpLCByZXQgPSAwOwo+Pj4+ICsJaW50IGksIHJldDsKPj4+PiAgCXVuc2lnbmVkIHBs YW5lX21hc2s7Cj4+Pj4gKwlib29sIGRpc2FibGVfY3J0Y3MgPSBmYWxzZTsKPj4+PiAgCj4+Pj4g LQlzdGF0ZSA9IGRybV9hdG9taWNfc3RhdGVfYWxsb2MoZGV2KTsKPj4+PiAtCWlmICghc3RhdGUp Cj4+Pj4gLQkJcmV0dXJuIC1FTk9NRU07Cj4+Pj4gLQo+Pj4+ICtyZXRyeV9kaXNhYmxlOgo+Pj4+ ICAJZHJtX21vZGVzZXRfYWNxdWlyZV9pbml0KCZjdHgsIDApOwo+Pj4+ICsKPj4+PiArCXN0YXRl ID0gZHJtX2F0b21pY19zdGF0ZV9hbGxvYyhkZXYpOwo+Pj4+ICsJaWYgKCFzdGF0ZSkgewo+Pj4+ ICsJCXJldCA9IC1FTk9NRU07Cj4+Pj4gKwkJZ290byBvdXQ7Cj4+Pj4gKwl9Cj4+Pj4gIAlzdGF0 ZS0+YWNxdWlyZV9jdHggPSAmY3R4Owo+Pj4+ICAKPj4+PiAgcmV0cnk6Cj4+Pj4gQEAgLTc5Myw3 ICs3OTcsNyBAQCBzdGF0aWMgaW50IGF0b21pY19yZW1vdmVfZmIoc3RydWN0IGRybV9mcmFtZWJ1 ZmZlciAqZmIpCj4+Pj4gIAkJCWdvdG8gdW5sb2NrOwo+Pj4+ICAJCX0KPj4+PiAgCj4+Pj4gLQkJ aWYgKHBsYW5lX3N0YXRlLT5jcnRjLT5wcmltYXJ5ID09IHBsYW5lKSB7Cj4+Pj4gKwkJaWYgKGRp c2FibGVfY3J0Y3MgJiYgcGxhbmVfc3RhdGUtPmNydGMtPnByaW1hcnkgPT0gcGxhbmUpIHsKPj4+ PiAgCQkJc3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRlOwo+Pj4+ICAKPj4+PiAgCQkJ Y3J0Y19zdGF0ZSA9IGRybV9hdG9taWNfZ2V0X2V4aXN0aW5nX2NydGNfc3RhdGUoc3RhdGUsIHBs YW5lX3N0YXRlLT5jcnRjKTsKPj4+PiBAQCAtODE4LDYgKzgyMiw3IEBAIHN0YXRpYyBpbnQgYXRv bWljX3JlbW92ZV9mYihzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYikKPj4+PiAgCQlwbGFuZS0+ b2xkX2ZiID0gcGxhbmUtPmZiOwo+Pj4+ICAJfQo+Pj4+ICAKPj4+PiArCS8qIFRoaXMgbGlzdCBp cyBvbmx5IGZpbGxlZCB3aGVuIGRpc2FibGVfY3J0Y3MgaXMgc2V0LiAqLwo+Pj4+ICAJZm9yX2Vh Y2hfbmV3X2Nvbm5lY3Rvcl9pbl9zdGF0ZShzdGF0ZSwgY29ubiwgY29ubl9zdGF0ZSwgaSkgewo+ Pj4gV0FSTl9PTighZGlzYWJsZV9jcnRjcykgbWF5YmU/Cj4+IFdvdWxkIGJlIG92ZXJraWxsLCBu b3RoaW5nIGJlZm9yZSBpdCBhZGRzIGNvbm5lY3RvciBzdGF0ZSwgYW5kIGlmIGF0b21pYyBjaGVj ayBkb2VzIHRoZW4gdGhhdCdzIGZpbmUsIGJ1dCBpdCB3b24ndCBiZSBydW4gaGVyZS4gOikKPiBJ dCB3b3VsZCBzZXJ2ZSBhcyBhIHdheSB0byBkb2N1bWVudCB0aGF0IGZhY3QsIGV2ZW4gd2l0aG91 dCB0aGUgY29tbWVudC4KPiBCdXQgSSB3b24ndCBpbnNpc3Qgb24gaXQuCj4KPj4+PiAgCQlyZXQg PSBkcm1fYXRvbWljX3NldF9jcnRjX2Zvcl9jb25uZWN0b3IoY29ubl9zdGF0ZSwgTlVMTCk7Cj4+ Pj4gIAo+Pj4+IEBAIC04NDAsOSArODQ1LDE1IEBAIHN0YXRpYyBpbnQgYXRvbWljX3JlbW92ZV9m YihzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYikKPj4+PiAgCj4+Pj4gIAlkcm1fYXRvbWljX3N0 YXRlX3B1dChzdGF0ZSk7Cj4+Pj4gIAo+Pj4+ICtvdXQ6Cj4+Pj4gIAlkcm1fbW9kZXNldF9kcm9w X2xvY2tzKCZjdHgpOwo+Pj4+ICAJZHJtX21vZGVzZXRfYWNxdWlyZV9maW5pKCZjdHgpOwo+Pj4+ ICAKPj4+PiArCWlmIChyZXQgPT0gLUVJTlZBTCAmJiAhZGlzYWJsZV9jcnRjcykgewo+Pj4gSG1t LiAtRUlOVkFMIHNlZW1zIHJhdGhlciBzcGVjaWZpYy4gTm90IHN1cmUgaWYgd2UgY291bGQganVz dCBjaGVjayBmb3IKPj4+IGFueSBlcnJvcj8KPj4+Cj4+PiBPci4uLiBJJ20gbm90IHN1cmUgaWYg d2UgaGF2ZSBhbnkgY2VudHJhbCBwbGFjZSB3aGVyZSB3ZSBkbyB0aGUKPj4+ICJjYW4gSSBkaXNh YmxlIHRoZSBwcmltYXJ5IHBsYW5lIHcvbyBkaXNhYmxpbmcgdGhlIGNydGM/IiBjaGVjay4gSWYg d2UKPj4+IGRvIHRoZW4gd2UgY291bGQgYWxzbyBhZGQgYSBjb21tZW50IHRoZXJlIGluZm9ybWlu ZyBwZW9wbGUgdGhhdCB0aGUKPj4+IC1FSU5WQUwgaXMgaW1wb3J0YW50Lgo+PiBXZSBkb24ndCBo YXZlIGEgY2VudHJhbCBwbGFjZSwgSSBjaGVjayBmb3IgRUlOVkFMIHNpbmNlIHRoYXQgaXMgdGhl IGdlbmVyaWMgYXRvbWljX2NoZWNrKCkgZmFpbGVkIGVycm9yLiBJZiBpdCBmYWlscyBmb3IgYW55 IG90aGVyIHJlYXNvbiB0aGVuIHdlIGRvbid0IGhhdmUgdG8gcmV0cnksIGJ1dCBwYXNzIGl0IGFs b25nLiA6KQo+IE9oIHdlbGwuIEkgZ3Vlc3MgcGVvcGxlIGp1c3QgaGF2ZSB0byBiZSBjYXJlZnVs IHdpdGggdGhlaXIgZXJyb3IKPiB2YWx1ZXMuIEkgc3VwcG9lIGFueW9uZSBkZXBlbmRpbmcgb24g dGhlIHJldHJ5IHdpbGwgbm90aWNlIHRoaXMKPiBpc3N1ZSByYXRoZXIgcXVpY2tseS4KPgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==