From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23965CD1284 for ; Tue, 9 Apr 2024 09:26:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0699F10EC5C; Tue, 9 Apr 2024 09:26:33 +0000 (UTC) Received: from riemann.telenet-ops.be (riemann.telenet-ops.be [195.130.137.80]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0F17610EC5C for ; Tue, 9 Apr 2024 09:26:29 +0000 (UTC) Received: from andre.telenet-ops.be (andre.telenet-ops.be [IPv6:2a02:1800:120:4::f00:15]) by riemann.telenet-ops.be (Postfix) with ESMTPS id 4VDLF05Dflz4wx7B for ; Tue, 09 Apr 2024 11:26:28 +0200 (CEST) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed80:76d0:2bff:fec8:549]) by andre.telenet-ops.be with bizsmtp id 8xSR2C00c0SSLxL01xSRx9; Tue, 09 Apr 2024 11:26:28 +0200 Received: from geert (helo=localhost) by ramsan.of.borg with local-esmtp (Exim 4.95) (envelope-from ) id 1ru7kH-00D2QY-KH; Tue, 09 Apr 2024 11:26:25 +0200 Date: Tue, 9 Apr 2024 11:26:25 +0200 (CEST) From: Geert Uytterhoeven To: Maxime Ripard cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jani Nikula , dri-devel@lists.freedesktop.org, Jani Nikula , Lucas De Marchi , kernel test robot , linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 00/13] drm/display: Convert helpers Kconfig symbols to depends on In-Reply-To: <20240327-kms-kconfig-helpers-v3-0-eafee11b84b3@kernel.org> Message-ID: References: <20240327-kms-kconfig-helpers-v3-0-eafee11b84b3@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Maxime, On Wed, 27 Mar 2024, Maxime Ripard wrote: > Jani recently pointed out that the Kconfig symbols are a bit difficult > to work with at the moment when they depend on each other, and that > using depends on would be a better idea, but no one really did the work > so far. > > So here it goes :) > > It's been tested by comparing the riscv defconfig, arm > multi_v7_defconfig, arm64 defconfig, drm-misc-arm, drm-misc-arm64 and > drm-misc-x86 before and after this series and making sure they are > identical. That is not true: comparing drm-misc/for-linux-next to v6.9-rc2, arm/multi_v7_defconfig, arm64/defconfig, and riscv/defconfig lost several of: - CONFIG_DRM_DW_HDMI, - CONFIG_DRM_DW_HDMI_AHB_AUDIO, - CONFIG_DRM_DW_HDMI_CEC, - CONFIG_DRM_DW_HDMI_I2S_AUDIO, - CONFIG_DRM_IMX_HDMI. - CONFIG_DRM_MESON_DW_HDMI, - CONFIG_DRM_RCAR_DW_HDMI, - CONFIG_DRM_SUN8I_DW_HDMI, - CONFIG_ROCKCHIP_DW_HDMI, - CONFIG_SND_MESON_G12A_TOHDMITX, > Let me know what you think, IMHO this series looks like a big usuability issue for anyone configuring the kernel, and you try to work around this by sprinkling "default y" around. The user should not need to know which helpers are needed for the driver he is interested in. When a symbol selects another symbol, it should just make sure the dependencies of the target symbol are met. Thanks for reverting ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds