Re: [PATCH v13 1/8] mm/gup: Introduce unpin_folio/unpin_folios helpers

[David Hildenbrand <david@redhat.com>]

On 04.04.24 09:26, Vivek Kasireddy wrote:
> These helpers are the folio versions of unpin_user_page/unpin_user_pages.
> They are currently only useful for unpinning folios pinned by
> memfd_pin_folios() or other associated routines. However, they could
> find new uses in the future, when more and more folio-only helpers
> are added to GUP.
> 
> We should probably sanity check the folio as part of unpin similar
> to how it is done in unpin_user_page/unpin_user_pages but we cannot
> cleanly do that at the moment without also checking the subpage.
> Therefore, sanity checking needs to be added to these routines once
> we have a way to determine if any given folio is anon-exclusive (via
> a per folio AnonExclusive flag).
> 
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Christoph Hellwig <hch@infradead.org>
> Cc: Jason Gunthorpe <jgg@nvidia.com>
> Cc: Peter Xu <peterx@redhat.com>
> Suggested-by: David Hildenbrand <david@redhat.com>
> Signed-off-by: Vivek Kasireddy <vivek.kasireddy@intel.com>
> ---

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb