From: Lizhi Hou <lizhi.hou@amd.com>
To: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>,
<dri-devel@lists.freedesktop.org>
Cc: <jeff.hugo@oss.qualcomm.com>
Subject: Re: [PATCH] accel/ivpu: Make function parameter names consistent
Date: Fri, 8 Aug 2025 09:58:01 -0700 [thread overview]
Message-ID: <a87b5e17-2219-96fc-31d1-cdac3db8f1fb@amd.com> (raw)
In-Reply-To: <20250808111014.328607-1-jacek.lawrynowicz@linux.intel.com>
On 8/8/25 04:10, Jacek Lawrynowicz wrote:
> Make ivpu_hw_btrs_dct_set_status() and ivpu_fw_boot_params_setup()
> declaration and definition parameter names consistent.
>
> Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
> ---
> drivers/accel/ivpu/ivpu_fw.h | 2 +-
> drivers/accel/ivpu/ivpu_hw_btrs.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/accel/ivpu/ivpu_fw.h b/drivers/accel/ivpu/ivpu_fw.h
> index 9a3935be1c057..7081913fb0dde 100644
> --- a/drivers/accel/ivpu/ivpu_fw.h
> +++ b/drivers/accel/ivpu/ivpu_fw.h
> @@ -45,7 +45,7 @@ struct ivpu_fw_info {
> int ivpu_fw_init(struct ivpu_device *vdev);
> void ivpu_fw_fini(struct ivpu_device *vdev);
> void ivpu_fw_load(struct ivpu_device *vdev);
> -void ivpu_fw_boot_params_setup(struct ivpu_device *vdev, struct vpu_boot_params *bp);
> +void ivpu_fw_boot_params_setup(struct ivpu_device *vdev, struct vpu_boot_params *boot_params);
>
> static inline bool ivpu_fw_is_cold_boot(struct ivpu_device *vdev)
> {
> diff --git a/drivers/accel/ivpu/ivpu_hw_btrs.h b/drivers/accel/ivpu/ivpu_hw_btrs.h
> index d2d82651976d1..032c384ac3d4d 100644
> --- a/drivers/accel/ivpu/ivpu_hw_btrs.h
> +++ b/drivers/accel/ivpu/ivpu_hw_btrs.h
> @@ -36,7 +36,7 @@ u32 ivpu_hw_btrs_dpu_freq_get(struct ivpu_device *vdev);
> bool ivpu_hw_btrs_irq_handler_mtl(struct ivpu_device *vdev, int irq);
> bool ivpu_hw_btrs_irq_handler_lnl(struct ivpu_device *vdev, int irq);
> int ivpu_hw_btrs_dct_get_request(struct ivpu_device *vdev, bool *enable);
> -void ivpu_hw_btrs_dct_set_status(struct ivpu_device *vdev, bool enable, u32 dct_percent);
> +void ivpu_hw_btrs_dct_set_status(struct ivpu_device *vdev, bool enable, u32 active_percent);
Reviewed-by: Lizhi Hou <lizhi.hou@amd.com>
> u32 ivpu_hw_btrs_telemetry_offset_get(struct ivpu_device *vdev);
> u32 ivpu_hw_btrs_telemetry_size_get(struct ivpu_device *vdev);
> u32 ivpu_hw_btrs_telemetry_enable_get(struct ivpu_device *vdev);
next prev parent reply other threads:[~2025-08-08 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 11:10 [PATCH] accel/ivpu: Make function parameter names consistent Jacek Lawrynowicz
2025-08-08 16:58 ` Lizhi Hou [this message]
2025-09-01 10:36 ` Jacek Lawrynowicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a87b5e17-2219-96fc-31d1-cdac3db8f1fb@amd.com \
--to=lizhi.hou@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.lawrynowicz@linux.intel.com \
--cc=jeff.hugo@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).