From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B2A6C87FCF for ; Mon, 4 Aug 2025 15:16:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E2B8910E370; Mon, 4 Aug 2025 15:16:21 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="eDGYdjow"; dkim-atps=neutral Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by gabe.freedesktop.org (Postfix) with ESMTPS id D014D10E370 for ; Mon, 4 Aug 2025 15:16:20 +0000 (UTC) Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-458a84e2917so38272395e9.1 for ; Mon, 04 Aug 2025 08:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1754320579; x=1754925379; darn=lists.freedesktop.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=ifdQYtMoMbUhaDaLztKpCS+6vqQS+9SK4PGyB6S6f3U=; b=eDGYdjowppG+aDlcOCj3W4CeMXpMkXwL8xXQq1YbVGb5ioKpxGU4UnOn90RxhPpUoR ge4XFptfue+aRcWO0jnIUo0dsncNp/nYEnWeCEm4GgR9g2KOAIP6yvf2+W+VONvYjv5F cKVmvKFNe0cJfre4xhBOT/WmHyF5RPQ6dVMh6o9KdNIcRJvFsDtiQHGRBjcGFBNx754r 0aFCfDSAboUVVB49zBpXkcH9PuxUFMzlLwiBMi5lP05/+8aLXRLs30tY+Y7+ZW6XA3cO 0XkwaAPR4w3mUars+mwXnnqFu5xye5F8UVaXBN9QlyGYRWTSBZqpdUGfONaLKc9oBXa5 6i2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754320579; x=1754925379; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ifdQYtMoMbUhaDaLztKpCS+6vqQS+9SK4PGyB6S6f3U=; b=joysgFlhU45T9QmC4vxrpya9U3VGRcxuwYKuckxjH3nEh744R8coh0FoMKVZTnJ7Bh Gr2g84uMpqlXFqwoJm6FqJTW3C2/xOPHkkC8ff7aTFu2zrLypiYzbmEtWE1kv5jCKktR HEgYJ4salszNRd2h/rmG97cOq2txo3H8K2LyPl7CXRxu/et4o1PxW4/Ji/Uev6cW3bbx 2Nga0uo/VqacL8F9bWQ8SbLw9GP+OLdeAr3dKQH+6bQ3SzTAuf8u0zS2WFw1/vmZ0Jip DB2cUF/fPmnDQIUeiDNs8/ulweu5bldyeGH7/X7aTCw6X473f2KQaGLKKInNRBmGWwmd 5d5g== X-Forwarded-Encrypted: i=1; AJvYcCWTZOOb8PDxX4aq2zp4oSgdG/84wdgiAaIPLjTJ48sHqK3b89eKNqXmhebpZ8OL1l5nlkSu7furPIM=@lists.freedesktop.org X-Gm-Message-State: AOJu0YxJeEoCWyGjbE7F4PCCczwAhBpeUUMnoD4Mf8gDC2wEE+gDO1X3 RfzvhNIpWs6NAQS7FPEaBSN/fIPreanDEP14+psDwgyahsDcXDqYSAePCWNK+K0VRVA= X-Gm-Gg: ASbGncvRzi3vfdP2inRyhB3aLHrMbwPWHGs2zJ/yfXM8yxWYnCuvntmqNiHRm1ewIUH D/4loTpI3BUPdKDMmoYwoTY0OwpUgiX2Lf86iQj8k+29goLoaytTEtXNy8ts0qdqHQ9lOsDPv9c nZVODnv1L4SYSMM/KSTOKoBjyOd380Iz0jcuQlO+GNiwsbmkIUZTlKjv7PwIRmPkVTTaGCyrma2 M3GEgP2t0h5zzIbQQEeux+rYEtqSK1D4h45JljC2pVWcMVS3DfR7KSiO5syX514SY1WAjdZgRB+ UZOGx2JJIkW8f4kGzPxRm4n860F0MgctIILg0x2gejWiYTBkbo8Cbcl7jqnm+UCk99XW8HMCTqI piO3kkjhiPWX1H0n963HQUpdWOrr3uQPk34E0wdafJOYmeOIZRXUktx/NVvTGMJfIYi+Q/qefg2 0= X-Google-Smtp-Source: AGHT+IHPPDD9D0qxXu9jHrNySpU2UAtNfOEP8mZOWyrtTy6JCiloSri0pkmDPr9668JfOlIhW9A5cA== X-Received: by 2002:a05:6000:2881:b0:3b7:8146:4642 with SMTP id ffacd0b85a97d-3b8d9472439mr6472193f8f.20.1754320579282; Mon, 04 Aug 2025 08:16:19 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:3030:f63e:fedd:700f? ([2a01:e0a:3d9:2080:3030:f63e:fedd:700f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-458b73868a4sm99448145e9.11.2025.08.04.08.16.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Aug 2025 08:16:18 -0700 (PDT) Message-ID: Date: Mon, 4 Aug 2025 17:16:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Subject: Re: [PATCH 03/13] drm/panel: ilitek-ili9881c: convert (un-)prepare to mipi_dsi_multi_context To: Heiko Stuebner Cc: quic_jesszhan@quicinc.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, hjc@rock-chips.com, andy.yan@rock-chips.com, andyshrk@163.com, nicolas.frattaroli@collabora.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org References: <20250707164906.1445288-1-heiko@sntech.de> <20250707164906.1445288-4-heiko@sntech.de> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20250707164906.1445288-4-heiko@sntech.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Neil Armstrong Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 07/07/2025 18:48, Heiko Stuebner wrote: > This saves some lines for error handling. > > For the address mode change, that value is always an u8, so switching > to dcs_write_buffer function should be appropriate. > > Signed-off-by: Heiko Stuebner > --- > drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 66 ++++++------------- > 1 file changed, 21 insertions(+), 45 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c > index a20b52181ea0..154eea5f4d77 100644 > --- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c > +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c > @@ -1239,33 +1239,24 @@ static inline struct ili9881c *panel_to_ili9881c(struct drm_panel *panel) > * So before any attempt at sending a command or data, we have to be > * sure if we're in the right page or not. > */ > -static int ili9881c_switch_page(struct ili9881c *ctx, u8 page) > +static void ili9881c_switch_page(struct mipi_dsi_multi_context *mctx, u8 page) > { > u8 buf[4] = { 0xff, 0x98, 0x81, page }; > - int ret; > - > - ret = mipi_dsi_dcs_write_buffer(ctx->dsi, buf, sizeof(buf)); > - if (ret < 0) > - return ret; > > - return 0; > + mipi_dsi_dcs_write_buffer_multi(mctx, buf, sizeof(buf)); > } > > -static int ili9881c_send_cmd_data(struct ili9881c *ctx, u8 cmd, u8 data) > +static void ili9881c_send_cmd_data(struct mipi_dsi_multi_context *mctx, u8 cmd, u8 data) > { > u8 buf[2] = { cmd, data }; > - int ret; > > - ret = mipi_dsi_dcs_write_buffer(ctx->dsi, buf, sizeof(buf)); > - if (ret < 0) > - return ret; > - > - return 0; > + mipi_dsi_dcs_write_buffer_multi(mctx, buf, sizeof(buf)); > } > > static int ili9881c_prepare(struct drm_panel *panel) > { > struct ili9881c *ctx = panel_to_ili9881c(panel); > + struct mipi_dsi_multi_context mctx = { .dsi = ctx->dsi }; > unsigned int i; > int ret; > > @@ -1286,54 +1277,39 @@ static int ili9881c_prepare(struct drm_panel *panel) > const struct ili9881c_instr *instr = &ctx->desc->init[i]; > > if (instr->op == ILI9881C_SWITCH_PAGE) > - ret = ili9881c_switch_page(ctx, instr->arg.page); > + ili9881c_switch_page(&mctx, instr->arg.page); > else if (instr->op == ILI9881C_COMMAND) > - ret = ili9881c_send_cmd_data(ctx, instr->arg.cmd.cmd, > - instr->arg.cmd.data); > - > - if (ret) > - goto disable_power; > - } > - > - ret = ili9881c_switch_page(ctx, 0); > - if (ret) > - return ret; > - > - if (ctx->address_mode) { > - ret = mipi_dsi_dcs_write(ctx->dsi, MIPI_DCS_SET_ADDRESS_MODE, > - &ctx->address_mode, > - sizeof(ctx->address_mode)); > - if (ret < 0) > - goto disable_power; > + ili9881c_send_cmd_data(&mctx, instr->arg.cmd.cmd, > + instr->arg.cmd.data); > } > > - ret = mipi_dsi_dcs_set_tear_on(ctx->dsi, MIPI_DSI_DCS_TEAR_MODE_VBLANK); > - if (ret) > - goto disable_power; > - > - ret = mipi_dsi_dcs_exit_sleep_mode(ctx->dsi); > - if (ret) > - goto disable_power; > + ili9881c_switch_page(&mctx, 0); > > - msleep(120); > + if (ctx->address_mode) > + ili9881c_send_cmd_data(&mctx, MIPI_DCS_SET_ADDRESS_MODE, > + ctx->address_mode); > > - ret = mipi_dsi_dcs_set_display_on(ctx->dsi); > - if (ret) > + mipi_dsi_dcs_set_tear_on_multi(&mctx, MIPI_DSI_DCS_TEAR_MODE_VBLANK); > + mipi_dsi_dcs_exit_sleep_mode_multi(&mctx); > + mipi_dsi_msleep(&mctx, 120); > + mipi_dsi_dcs_set_display_on_multi(&mctx); > + if (mctx.accum_err) > goto disable_power; > > return 0; > > disable_power: > regulator_disable(ctx->power); > - return ret; > + return mctx.accum_err; > } > > static int ili9881c_unprepare(struct drm_panel *panel) > { > struct ili9881c *ctx = panel_to_ili9881c(panel); > + struct mipi_dsi_multi_context mctx = { .dsi = ctx->dsi }; > > - mipi_dsi_dcs_set_display_off(ctx->dsi); > - mipi_dsi_dcs_enter_sleep_mode(ctx->dsi); > + mipi_dsi_dcs_set_display_off_multi(&mctx); > + mipi_dsi_dcs_enter_sleep_mode_multi(&mctx); > regulator_disable(ctx->power); > gpiod_set_value_cansleep(ctx->reset, 1); > Reviewed-by: Neil Armstrong