* [PATCH] gpu: drm: selftests: drop unexpected word 'for' in comments
@ 2022-06-23 10:06 Jiang Jian
2022-06-28 21:32 ` Lyude Paul
0 siblings, 1 reply; 4+ messages in thread
From: Jiang Jian @ 2022-06-23 10:06 UTC (permalink / raw)
To: airlied, daniel
Cc: javierm, dri-devel, linux-kernel, jiangjian, alexander.deucher,
jose.exposito89
there is an unexpected word 'for' in the comments that need to be dropped
file - ./drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
line - 3
* Test cases for for the DRM DP MST helpers
changed to:
* Test cases for the DRM DP MST helpers
Signed-off-by: Jiang Jian <jiangjian@cdjrlc.com>
---
drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
index 967c52150b67..4caa9be900ac 100644
--- a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
+++ b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
- * Test cases for for the DRM DP MST helpers
+ * Test cases for the DRM DP MST helpers
*/
#define PREFIX_STR "[drm_dp_mst_helper]"
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] gpu: drm: selftests: drop unexpected word 'for' in comments
2022-06-23 10:06 [PATCH] gpu: drm: selftests: drop unexpected word 'for' in comments Jiang Jian
@ 2022-06-28 21:32 ` Lyude Paul
2022-06-28 21:35 ` Lyude Paul
0 siblings, 1 reply; 4+ messages in thread
From: Lyude Paul @ 2022-06-28 21:32 UTC (permalink / raw)
To: Jiang Jian, airlied, daniel
Cc: alexander.deucher, jose.exposito89, javierm, dri-devel,
linux-kernel
Reviewed-by: Lyude Paul <lyude@redhat.com>
Going to change the name of the patch slightly so it's more obvious this is
just about the MST selftests
On Thu, 2022-06-23 at 18:06 +0800, Jiang Jian wrote:
> there is an unexpected word 'for' in the comments that need to be dropped
>
> file - ./drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> line - 3
>
> * Test cases for for the DRM DP MST helpers
>
> changed to:
>
> * Test cases for the DRM DP MST helpers
>
> Signed-off-by: Jiang Jian <jiangjian@cdjrlc.com>
> ---
> drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> index 967c52150b67..4caa9be900ac 100644
> --- a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> +++ b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0-only
> /*
> - * Test cases for for the DRM DP MST helpers
> + * Test cases for the DRM DP MST helpers
> */
>
> #define PREFIX_STR "[drm_dp_mst_helper]"
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpu: drm: selftests: drop unexpected word 'for' in comments
2022-06-28 21:32 ` Lyude Paul
@ 2022-06-28 21:35 ` Lyude Paul
2022-06-28 22:51 ` Lyude Paul
0 siblings, 1 reply; 4+ messages in thread
From: Lyude Paul @ 2022-06-28 21:35 UTC (permalink / raw)
To: Jiang Jian, airlied, daniel
Cc: alexander.deucher, jose.exposito89, javierm, dri-devel,
linux-kernel
…ah, I totally forgot that gitlab happens to be down right now which part of
the DRM maintainer scripts rely on - so I can't actually push this patch
upstream right away. I will set this email as unread so hopefully I don't lose
track of this, but please feel free to ping me if I do end up forgetting.
On Tue, 2022-06-28 at 17:32 -0400, Lyude Paul wrote:
> Reviewed-by: Lyude Paul <lyude@redhat.com>
>
> Going to change the name of the patch slightly so it's more obvious this is
> just about the MST selftests
>
> On Thu, 2022-06-23 at 18:06 +0800, Jiang Jian wrote:
> > there is an unexpected word 'for' in the comments that need to be dropped
> >
> > file - ./drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> > line - 3
> >
> > * Test cases for for the DRM DP MST helpers
> >
> > changed to:
> >
> > * Test cases for the DRM DP MST helpers
> >
> > Signed-off-by: Jiang Jian <jiangjian@cdjrlc.com>
> > ---
> > drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> > b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> > index 967c52150b67..4caa9be900ac 100644
> > --- a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> > +++ b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> > @@ -1,6 +1,6 @@
> > // SPDX-License-Identifier: GPL-2.0-only
> > /*
> > - * Test cases for for the DRM DP MST helpers
> > + * Test cases for the DRM DP MST helpers
> > */
> >
> > #define PREFIX_STR "[drm_dp_mst_helper]"
>
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpu: drm: selftests: drop unexpected word 'for' in comments
2022-06-28 21:35 ` Lyude Paul
@ 2022-06-28 22:51 ` Lyude Paul
0 siblings, 0 replies; 4+ messages in thread
From: Lyude Paul @ 2022-06-28 22:51 UTC (permalink / raw)
To: Jiang Jian, airlied, daniel
Cc: alexander.deucher, jose.exposito89, javierm, dri-devel,
linux-kernel
Oh-it's back up now! will push now :)
On Tue, 2022-06-28 at 17:35 -0400, Lyude Paul wrote:
> …ah, I totally forgot that gitlab happens to be down right now which part of
> the DRM maintainer scripts rely on - so I can't actually push this patch
> upstream right away. I will set this email as unread so hopefully I don't
> lose
> track of this, but please feel free to ping me if I do end up forgetting.
>
> On Tue, 2022-06-28 at 17:32 -0400, Lyude Paul wrote:
> > Reviewed-by: Lyude Paul <lyude@redhat.com>
> >
> > Going to change the name of the patch slightly so it's more obvious this
> > is
> > just about the MST selftests
> >
> > On Thu, 2022-06-23 at 18:06 +0800, Jiang Jian wrote:
> > > there is an unexpected word 'for' in the comments that need to be
> > > dropped
> > >
> > > file - ./drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> > > line - 3
> > >
> > > * Test cases for for the DRM DP MST helpers
> > >
> > > changed to:
> > >
> > > * Test cases for the DRM DP MST helpers
> > >
> > > Signed-off-by: Jiang Jian <jiangjian@cdjrlc.com>
> > > ---
> > > drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> > > b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> > > index 967c52150b67..4caa9be900ac 100644
> > > --- a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> > > +++ b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
> > > @@ -1,6 +1,6 @@
> > > // SPDX-License-Identifier: GPL-2.0-only
> > > /*
> > > - * Test cases for for the DRM DP MST helpers
> > > + * Test cases for the DRM DP MST helpers
> > > */
> > >
> > > #define PREFIX_STR "[drm_dp_mst_helper]"
> >
>
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-28 22:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-23 10:06 [PATCH] gpu: drm: selftests: drop unexpected word 'for' in comments Jiang Jian
2022-06-28 21:32 ` Lyude Paul
2022-06-28 21:35 ` Lyude Paul
2022-06-28 22:51 ` Lyude Paul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).