From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77310C2D0CD for ; Wed, 21 May 2025 13:12:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2BA03112891; Wed, 21 May 2025 13:06:18 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="WQrD2BfL"; dkim-atps=neutral Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0500712BBFF; Wed, 21 May 2025 12:43:28 +0000 (UTC) Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-47691d82bfbso131187961cf.0; Wed, 21 May 2025 05:43:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747831408; x=1748436208; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=hgjwFdM2k5sCslQZdWwlZbIspHEoXzqe2FcVDJivI+o=; b=WQrD2BfLb7xgYSsuJ83dg2UPLqYzcJqz28V9iOBg7XznJou387i79UdViIvxVvI6dx tLOWSx1DKGdrrbe9BncyTgFyZS4DJmGYLN24PpVCs/99Us//3DzCp81DG/KXPdVflqLI cwYJ9RROMirJz7Zeu+YF9u4wJySjnZPfV/y5C4aRBzTmRts32xcc9y2NPS41zQ3orqSt nCpPjDI+LN4nYoSOWCffGZe3VDp6TB9WhBQtBI9ZcAiMGggC9IQKeZV/7QAI8fuJ4SHL r4vl11GgKdIDijWAP94qrr5Z+KUYBvrl5BjPwJPqTIUxNnr/UNJm4DPFQCLM7bY631gH rUJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747831408; x=1748436208; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hgjwFdM2k5sCslQZdWwlZbIspHEoXzqe2FcVDJivI+o=; b=A3oufzoI4y3DZX6D9/5VylbrwkwgexXgb5/ebDAte5epEjeKoAnb3VQ8Ittladm8h1 VScICaBgHQt+MujbMAXwgnNJgbr22ibY1vM6og39qfr6IS67XPz1HMspxSKRBQnzmO2N NawrY6KmloFt718OVPJwVdsSXQ/azJjSAWFD9RQ9gqURi9RNMJL/dkhYJVOUv+6Z1tQu qBaz0Gj4p5ZUSCYU+c4E2nh417XRaibiiZ6Vqkj5pIjC7YP/XSETA2ufHBG9bvht5TCa b133i23jrotOpDcFXWfA3//PmAtTO0m8N6Pdz5AboAJO/+GsJPZZRSemIffTxyEjGWyt y/Ig== X-Forwarded-Encrypted: i=1; AJvYcCUQGd6dxFoBfGHImZOoUvccI7x+IcC08K+R5Ccd79TOPXfIai4GIoQCtVY5A4jqKCFULOKyfqILM8o=@lists.freedesktop.org, AJvYcCXVK3/pXLLj6c6mtQTB2+F53QnOD5LYaXY8lFFtQMFoDL38KWGz33EIIss6q+qT6FcpF0gLMZyYrA==@lists.freedesktop.org X-Gm-Message-State: AOJu0YwXlY6AS0Hwh1jhlACdkwiKx+CP46smVB2vcSpyZJrWqYg8hEpZ G5bRzf0nGJ8FUXv60TaJWYESI8OShxN7nuoLjc8m9SBHN68dEZwHo00m X-Gm-Gg: ASbGncuY6LMSNJShDoCqgPX4b2deytelUoov95NzR3pr67i7TlB7co9Ob6f/+o/Hkqx CiRePIlTKJsC5Xd9Jz/jh5PTtY1JFvvNPPmazXH6fH5kaIjzzFjAANXvfAuV6UIWUyZnvsF7Ctb zVpqUv8bJysx8cICHTu6UBYBj3aoncVtCVHiXH5MjN7lkfBWXMOSq6kCIADhh/J/pCJn/Z7azNh xrVMT257VSUnzkM9FbKRss/lMxJmwpyKmyMtV4Q4oWwZrBTpP4V5HZ5JlTT+ql05eIkLmJAJGqY IMP+8s6Kbr4U0+Q89uVAkfDSuoQCL4wNOkH7pOK3P3Y2bfm9EMEPqXFFc0nYwVW+veoLC1cqjzy lzj06xuWqojIZrcxGi/kePSdYVrhfn7lm2sYUJwDu6K47RPv0yOw2 X-Google-Smtp-Source: AGHT+IErCuCfRGil1ejhob4xg9yF6HudkK+JCsZ+ou6hegKIPEwSjezrXHPPDMBGZDMU5QdCutpJMw== X-Received: by 2002:a05:622a:5a92:b0:474:fee1:7915 with SMTP id d75a77b69052e-494b0804fccmr351306121cf.31.1747831408000; Wed, 21 May 2025 05:43:28 -0700 (PDT) Received: from fauth-a1-smtp.messagingengine.com (fauth-a1-smtp.messagingengine.com. [103.168.172.200]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-494b2de7adesm78612461cf.17.2025.05.21.05.43.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 May 2025 05:43:27 -0700 (PDT) Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfauth.phl.internal (Postfix) with ESMTP id C0F0E120007A; Wed, 21 May 2025 08:43:26 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-09.internal (MEProxy); Wed, 21 May 2025 08:43:26 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgdefudduucdltddurdegfedvrddttd dmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgf nhhsuhgsshgtrhhisggvpdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttd enucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkfhgg tggujgesthdtredttddtvdenucfhrhhomhepuehoqhhunhcuhfgvnhhguceosghoqhhunh drfhgvnhhgsehgmhgrihhlrdgtohhmqeenucggtffrrghtthgvrhhnpeehudfgudffffet uedtvdehueevledvhfelleeivedtgeeuhfegueevieduffeivdenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegsohhquhhnodhmvghsmhhtphgr uhhthhhpvghrshhonhgrlhhithihqdeiledvgeehtdeigedqudejjeekheehhedvqdgsoh hquhhnrdhfvghngheppehgmhgrihhlrdgtohhmsehfihigmhgvrdhnrghmvgdpnhgspghr tghpthhtohepvdehpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegrtghouhhrsg hothesnhhvihguihgrrdgtohhmpdhrtghpthhtohepohhjvggurgeskhgvrhhnvghlrdho rhhgpdhrtghpthhtoheprghlvgigrdhgrgihnhhorhesghhmrghilhdrtghomhdprhgtph htthhopehgrghrhiesghgrrhihghhuohdrnhgvthdprhgtphhtthhopegsjhhorhhnfegp ghhhsehprhhothhonhhmrghilhdrtghomhdprhgtphhtthhopegsvghnnhhordhlohhssh hinhesphhrohhtohhnrdhmvgdprhgtphhtthhopegrrdhhihhnuggsohhrgheskhgvrhhn vghlrdhorhhgpdhrtghpthhtoheprghlihgtvghrhihhlhesghhoohhglhgvrdgtohhmpd hrtghpthhtohepthhmghhrohhsshesuhhmihgthhdrvgguuh X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 21 May 2025 08:43:25 -0400 (EDT) Date: Wed, 21 May 2025 05:43:24 -0700 From: Boqun Feng To: Alexandre Courbot Cc: Miguel Ojeda , Alex Gaynor , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , John Hubbard , Ben Skeggs , Joel Fernandes , Timur Tabi , Alistair Popple , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v4 01/20] rust: dma: expose the count and size of CoherentAllocation Message-ID: References: <20250521-nova-frts-v4-0-05dfd4f39479@nvidia.com> <20250521-nova-frts-v4-1-05dfd4f39479@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250521-nova-frts-v4-1-05dfd4f39479@nvidia.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, May 21, 2025 at 03:44:56PM +0900, Alexandre Courbot wrote: > These properties are very useful to have and should be accessible. > > Signed-off-by: Alexandre Courbot > --- > rust/kernel/dma.rs | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/rust/kernel/dma.rs b/rust/kernel/dma.rs > index 605e01e35715667f93297fd9ec49d8e7032e0910..2a60eefa47dfc1f836c30ee342e26c6ff3e9b13a 100644 > --- a/rust/kernel/dma.rs > +++ b/rust/kernel/dma.rs > @@ -129,6 +129,10 @@ pub mod attrs { > // > // Hence, find a way to revoke the device resources of a `CoherentAllocation`, but not the > // entire `CoherentAllocation` including the allocated memory itself. > +// > +// # Invariants > +// > +// The size in bytes of the allocation is equal to `size_of:: * count()`. > pub struct CoherentAllocation { > dev: ARef, > dma_handle: bindings::dma_addr_t, > @@ -201,6 +205,20 @@ pub fn alloc_coherent( > CoherentAllocation::alloc_attrs(dev, count, gfp_flags, Attrs(0)) > } > > + /// Returns the number of elements `T` in this allocation. > + /// > + /// Note that this is not the size of the allocation in bytes, which is provided by > + /// [`Self::size`]. > + pub fn count(&self) -> usize { > + self.count > + } > + > + /// Returns the size in bytes of this allocation. > + pub fn size(&self) -> usize { > + // As per the invariants of `CoherentAllocation`. > + self.count * core::mem::size_of::() I think we need a comment or even an invariant saying this multiply cannot overflow. Regards, Boqun > + } > + > /// Returns the base address to the allocated region in the CPU's virtual address space. > pub fn start_ptr(&self) -> *const T { > self.cpu_addr > > -- > 2.49.0 >