From: Danilo Krummrich <dakr@kernel.org>
To: Pierre-Eric Pelloux-Prayer <pierre-eric@damsy.net>
Cc: "Christian König" <christian.koenig@amd.com>,
"Pierre-Eric Pelloux-Prayer" <pierre-eric.pelloux-prayer@amd.com>,
alexander.deucher@amd.com, amd-gfx@lists.freedesktop.org,
"Philipp Stanner" <phasta@kernel.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v1] drm/amdgpu: give each kernel job a unique id
Date: Fri, 13 Jun 2025 10:31:35 +0200 [thread overview]
Message-ID: <aEvh5zYXqR6t2OqR@pollux> (raw)
In-Reply-To: <0783c4ab-e26e-4c90-93f5-342e761cee29@damsy.net>
On Fri, Jun 13, 2025 at 09:51:27AM +0200, Pierre-Eric Pelloux-Prayer wrote:
> If the theoretical overlap with client drm id is a concern, adding code to
> drm_file_alloc() to not use the last 0xff ids would be easy.
Not the theoretical overlap is not of any concern for me. What I dislike is
drivers silently relying on DRM API internals.
> btw maybe other drivers also use kernel jobs with the same semantics, in
> which case we might want to move the special IDs definition to a shared
> place.
Exactly, if kernel IDs are a thing we agree makes sense, we should provide a
common API to properly obtain a kernel ID, regardless of whether it's an atomic
or IDA.
next prev parent reply other threads:[~2025-06-13 8:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2cefb0f5-3820-4828-8360-ff8c92e21aa6@amd.com>
2025-06-11 14:25 ` [PATCH v1] drm/amdgpu: give each kernel job a unique id Danilo Krummrich
2025-06-11 14:57 ` Christian König
2025-06-11 15:11 ` Danilo Krummrich
2025-06-12 7:00 ` Christian König
2025-06-12 23:48 ` Danilo Krummrich
2025-06-13 7:51 ` Pierre-Eric Pelloux-Prayer
2025-06-13 8:31 ` Danilo Krummrich [this message]
2025-06-13 8:23 ` Christian König
2025-06-13 8:29 ` Philipp Stanner
2025-06-13 8:42 ` Danilo Krummrich
2025-06-13 8:35 ` Danilo Krummrich
2025-06-13 9:27 ` Pierre-Eric Pelloux-Prayer
2025-06-13 11:48 ` Danilo Krummrich
2025-06-18 9:18 ` Pierre-Eric Pelloux-Prayer
2025-07-02 9:23 ` Pierre-Eric Pelloux-Prayer
2025-07-02 9:42 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEvh5zYXqR6t2OqR@pollux \
--to=dakr@kernel.org \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=phasta@kernel.org \
--cc=pierre-eric.pelloux-prayer@amd.com \
--cc=pierre-eric@damsy.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox