From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E34FC71157 for ; Tue, 17 Jun 2025 20:14:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ED41910E101; Tue, 17 Jun 2025 20:14:22 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="S/ViDK5R"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 166D110E101; Tue, 17 Jun 2025 20:14:22 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id B9C2D4A284; Tue, 17 Jun 2025 20:14:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BBC7C4CEE3; Tue, 17 Jun 2025 20:14:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750191252; bh=oLvbT+kATQP0niwsl8Ion+MRezBTBGDHphjSJvl1ykY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S/ViDK5R04yKbjdvPIPz4/BNAf4yzkDlToY5S8CwWpHwbVWDHzCK7ZAe4tJnURvr0 hc4QS5ZPDiWFMK6ZLA2fCwKb5EZvmgftWSgtQfSWND9d5fQzMXCP23ffUMbVaQNjxl mh7AuPF3M5CYBbZQTApdJ3HFvcRXvSCfmfdSh2S+/Yz0csJJJLP0FdI69cHs/DsmDl AktoECLMXQrAhCD1PQ1BYBrYdxD9PMqmS1DKajFz8/qhaC9TVy4dGfttH7hfbUr4of zM1sI/P5V5Ze5oIhU3z9Ayj+MKPcyZaiKZ+J80LXdYYrZ7hhkMNW5Tm+o9N4z9D21m gUAR1B/HPXD0g== Date: Tue, 17 Jun 2025 22:14:04 +0200 From: Danilo Krummrich To: Alexandre Courbot Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Andreas Hindborg , Alice Ryhl , Trevor Gross , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Benno Lossin , John Hubbard , Ben Skeggs , Joel Fernandes , Timur Tabi , Alistair Popple , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Lyude Paul , Shirish Baskaran Subject: Re: [PATCH v5 00/23] nova-core: run FWSEC-FRTS to perform first stage of GSP initialization Message-ID: References: <20250612-nova-frts-v5-0-14ba7eaf166b@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250612-nova-frts-v5-0-14ba7eaf166b@nvidia.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jun 12, 2025 at 11:01:28PM +0900, Alexandre Courbot wrote: > Hi everyone, > > The feedback on v4 has been (hopefully) addressed. I guess the main > remaining unknown is the direction of the `num` module ; for this > iteration, following the received feedback I have eschewed the extension > trait and implemented the alignment functions as methods of the new > `PowerOfTwo` type. This has the benefit of making it impossible to call > them with undesirable (i.e. non-power of two) values. The `fls` function > is now provided as a series of const functions for each supported type, > generated by a macro. > > It feels like the `num` module could be its own series though, so if > there is still discussion about it, I can also extract it and implement > the functionality we need in nova-core as local helper functions until > it gets merged at its own pace. > > As previously, this series only successfully probes Ampere GPUs, but > support for other generations is on the way. > > Upon successful probe, the driver will display the range of the WPR2 > region constructed by FWSEC-FRTS with debug priority: > > [ 95.436000] NovaCore 0000:01:00.0: WPR2: 0xffc00000-0xffce0000 > [ 95.436002] NovaCore 0000:01:00.0: GPU instance built > > This series is based on v6.16-rc1 with no other dependencies. > > There are bits of documentation still missing, these are addressed by > Joel in his own documentation patch series [1]. I'll also double-check > and send follow-up patches if anything is still missing after that. > > [1] https://lore.kernel.org/rust-for-linux/20250503040802.1411285-1-joelagnelf@nvidia.com/ I think this series collected quite a few TODOs to follow up on once the corresponding abstractions are in place, etc. This is fine and expected. However, I think we should list those things in a central place, e.g. our TODO list, in order to make it easier to follow up. Additionally, it might get us more contributors who might be interested in following up on those things. @Alex: Can you please add such a list?