[PATCH 1/1] drm/nouveau/disp: Use dev->dev to get the device

[PATCH 1/1] drm/nouveau/disp: Use dev->dev to get the device

[Sakari Ailus]

The local variable dev points to drm->dev already, use dev directly.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
Hi folks,

The background is that I'll be using a Coccinelle spatch soon to remove
(most) pm_runtime_mark_last_busy() calls. That won't work if the arguments
aren't the same.

- Sakari

 drivers/gpu/drm/nouveau/nouveau_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
index add006fc8d81..c50ec347b30a 100644
--- a/drivers/gpu/drm/nouveau/nouveau_display.c
+++ b/drivers/gpu/drm/nouveau/nouveau_display.c
@@ -495,7 +495,7 @@ nouveau_display_hpd_work(struct work_struct *work)
 	if (first_changed_connector)
 		drm_connector_put(first_changed_connector);
 
-	pm_runtime_mark_last_busy(drm->dev->dev);
+	pm_runtime_mark_last_busy(dev->dev);
 noop:
 	pm_runtime_put_autosuspend(dev->dev);
 }
-- 
2.39.5

Re: [PATCH 1/1] drm/nouveau/disp: Use dev->dev to get the device

[Sakari Ailus]

On Wed, Apr 09, 2025 at 01:33:44PM +0300, Sakari Ailus wrote:
> The local variable dev points to drm->dev already, use dev directly.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Ping.

-- 
Sakari Ailus

Re: [PATCH 1/1] drm/nouveau/disp: Use dev->dev to get the device

[Danilo Krummrich]

On 4/9/25 12:33 PM, Sakari Ailus wrote:
> The local variable dev points to drm->dev already, use dev directly.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> Hi folks,
> 
> The background is that I'll be using a Coccinelle spatch soon to remove
> (most) pm_runtime_mark_last_busy() calls. That won't work if the arguments
> aren't the same.

If you want to submit / merge it together with your rework:

Acked-by: Danilo Krummrich <dakr@kernel.org>

If I should pick it up, please let me know.

Re: [PATCH 1/1] drm/nouveau/disp: Use dev->dev to get the device

[Sakari Ailus]

Hi Danilo,

On Wed, Jun 25, 2025 at 10:20:07AM +0200, Danilo Krummrich wrote:
> On 4/9/25 12:33 PM, Sakari Ailus wrote:
> > The local variable dev points to drm->dev already, use dev directly.
> > 
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > ---
> > Hi folks,
> > 
> > The background is that I'll be using a Coccinelle spatch soon to remove
> > (most) pm_runtime_mark_last_busy() calls. That won't work if the arguments
> > aren't the same.
> 
> If you want to submit / merge it together with your rework:
> 
> Acked-by: Danilo Krummrich <dakr@kernel.org>
> 
> If I should pick it up, please let me know.

Either is definitely possible. However I'd prefer you to take this in order
to avoid potential conflicts with merging larger patches later on.

Thanks.

-- 
Kind regards,

Sakari Ailus

Re: [PATCH 1/1] drm/nouveau/disp: Use dev->dev to get the device

[Danilo Krummrich]

On 4/9/25 12:33 PM, Sakari Ailus wrote:
> The local variable dev points to drm->dev already, use dev directly.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Applied to drm-misc-next, thanks!