From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Badal Nilawar <badal.nilawar@intel.com>
Cc: <intel-xe@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<anshuman.gupta@intel.com>, <alexander.usyskin@intel.com>,
<gregkh@linuxfoundation.org>, <daniele.ceraolospurio@intel.com>
Subject: Re: [PATCH v5 07/10] drm/xe/xe_late_bind_fw: Reload late binding fw during system resume
Date: Wed, 2 Jul 2025 17:46:35 -0400 [thread overview]
Message-ID: <aGWooERKYBmoCBM9@intel.com> (raw)
In-Reply-To: <20250702165216.557074-8-badal.nilawar@intel.com>
On Wed, Jul 02, 2025 at 10:22:13PM +0530, Badal Nilawar wrote:
> Reload late binding fw during resume from system suspend
>
> v2:
> - Unconditionally reload late binding fw (Rodrigo)
> - Flush worker during system suspend
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/xe/xe_pm.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
> index 734fe259600e..13afaf97d831 100644
> --- a/drivers/gpu/drm/xe/xe_pm.c
> +++ b/drivers/gpu/drm/xe/xe_pm.c
> @@ -127,6 +127,8 @@ int xe_pm_suspend(struct xe_device *xe)
> if (err)
> goto err;
>
> + xe_late_bind_wait_for_worker_completion(&xe->late_bind);
> +
> for_each_gt(gt, xe, id)
> xe_gt_suspend_prepare(gt);
>
> @@ -205,6 +207,8 @@ int xe_pm_resume(struct xe_device *xe)
>
> xe_pxp_pm_resume(xe->pxp);
>
> + xe_late_bind_fw_load(&xe->late_bind);
> +
> drm_dbg(&xe->drm, "Device resumed\n");
> return 0;
> err:
> --
> 2.34.1
>
next prev parent reply other threads:[~2025-07-02 21:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 16:52 [PATCH v5 00/10] Introducing firmware late binding Badal Nilawar
2025-07-02 16:52 ` [PATCH v5 01/10] mei: bus: add mei_cldev_mtu interface Badal Nilawar
2025-07-02 16:52 ` [PATCH v5 02/10] mei: late_bind: add late binding component driver Badal Nilawar
2025-07-02 16:52 ` [PATCH v5 03/10] drm/xe/xe_late_bind_fw: Introducing xe_late_bind_fw Badal Nilawar
2025-07-02 16:52 ` [PATCH v5 04/10] drm/xe/xe_late_bind_fw: Initialize late binding firmware Badal Nilawar
2025-07-02 23:55 ` Daniele Ceraolo Spurio
2025-07-02 16:52 ` [PATCH v5 05/10] drm/xe/xe_late_bind_fw: Load " Badal Nilawar
2025-07-02 16:52 ` [PATCH v5 06/10] drm/xe/xe_late_bind_fw: Reload late binding fw in rpm resume Badal Nilawar
2025-07-02 21:46 ` Rodrigo Vivi
2025-07-02 16:52 ` [PATCH v5 07/10] drm/xe/xe_late_bind_fw: Reload late binding fw during system resume Badal Nilawar
2025-07-02 21:46 ` Rodrigo Vivi [this message]
2025-07-02 16:52 ` [PATCH v5 08/10] drm/xe/xe_late_bind_fw: Introduce debug fs node to disable late binding Badal Nilawar
2025-07-03 0:12 ` Daniele Ceraolo Spurio
2025-07-02 16:52 ` [PATCH v5 09/10] drm/xe/xe_late_bind_fw: Extract and print version info Badal Nilawar
2025-07-02 16:52 ` [PATCH v5 10/10] drm/xe/xe_late_bind_fw: Select INTEL_MEI_LATE_BIND for CI Badal Nilawar
2025-07-02 21:48 ` Rodrigo Vivi
2025-07-03 17:06 ` Daniele Ceraolo Spurio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGWooERKYBmoCBM9@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=alexander.usyskin@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=badal.nilawar@intel.com \
--cc=daniele.ceraolospurio@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).