From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D3D7C83F1A for ; Wed, 23 Jul 2025 12:28:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D285210E16C; Wed, 23 Jul 2025 12:28:10 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="n0oRYKzX"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1463D10E7C2 for ; Wed, 23 Jul 2025 12:28:10 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1A3045C5D06; Wed, 23 Jul 2025 12:28:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01C9FC4CEE7; Wed, 23 Jul 2025 12:28:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753273688; bh=AU+ZIa1G6D9rjfQjIunyEIntuf2L1dafuWtnlP0A0Pc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n0oRYKzXdwPTrCEm2QRJLSnz9cuRDx/l0eBkDKDbxwoZNNrDW4AluzB+hvEtQBUNL ak3lp+UelHKS+uCQ9HN6NpPvaIb/nMVT8LHrw4HHejvu9A4ncAYEaBeIUML6zvDxJs +o5/FbTVAZMiaL3zoeTufZhN4EjozDAD9sVEcMHEWhk7/p8rw7WOvuwnm7hD829n3x xxmgwjVsfExCyBCdAsR7GzjesrLC98Iqt/EXKORQTxSvk9ouIhtHl1jimjYrc3gtlq gXYNf30B6pRllQQqJkD5rqDX3LWZj5rWP5Vr0Y6sMaWmUJck3gvXnzhTGXhW692twC hMO91kswwrrAQ== Date: Wed, 23 Jul 2025 17:58:05 +0530 From: Vinod Koul To: Tomi Valkeinen Cc: Jyri Sarha , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Kishon Vijay Abraham I , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Jayesh Choudhary , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, Francesco Dolcini , Aradhya Bhatia , Devarsh Thakkar , Parth Pancholi Subject: Re: [PATCH v4 05/17] phy: cdns-dphy: Remove leftover code Message-ID: References: <20250618-cdns-dsi-impro-v4-0-862c841dbe02@ideasonboard.com> <20250618-cdns-dsi-impro-v4-5-862c841dbe02@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 23-07-25, 11:49, Tomi Valkeinen wrote: > Hi Vinod, > > (I accidentally sent my mail only to you. List added here). > > On 23/07/2025 10:36, Tomi Valkeinen wrote: > > Hi Vinod, > > > > On 27/06/2025 02:32, Vinod Koul wrote: > >> On 18-06-25, 12:59, Tomi Valkeinen wrote: > >>> The code in cdns-dphy has probably been part of a DSI driver in the > >>> past. Remove DSI defines and variables which are not used or do not > >>> actually do anything. Also rename cdns_dsi_get_dphy_pll_cfg() to > >>> cdns_dphy_get_pll_cfg(), i.e. drop the "dsi", as it's not relevant here. > >> > >> Acked-by: Vinod Koul > >> > > > > Are you fine merging the two cdns-dphy patches (this and 4/17) via drm > > tree? I think that's the easiest way to merge this. > > > > I could also drop the 5/17 patch from the series, as it's just a > > cleanup, and it could be merged at some later point via phy tree. > > Actually, I take that back. Devarsh also has some cdns-dphy patches, > which depend on my patches. It could get messy. > > There's no compile-time dependency, and my DRM series doesn't depend on > the dphy changes even at runtime. I think it's best if I drop the dphy > changes from my series and send them separately. Okay sounds good to me.. Easier to handle that way -- ~Vinod