Re: [PATCH 2/3] drm/nouveau: Pass along the format info from .fb_create() to drm_helper_mode_fill_fb_struct()

[Imre Deak <imre.deak@intel.com>]

On Tue, Aug 12, 2025 at 07:04:44PM +0200, Danilo Krummrich wrote:
> On 8/1/25 11:08 AM, Danilo Krummrich wrote:
> > On 7/28/25 12:16 PM, Imre Deak wrote:
> > > Plumb the format info from .fb_create() all the way to
> > > drm_helper_mode_fill_fb_struct() to avoid the redundant
> > > lookup.
> > > 
> > > The patch is based on the driver parts of the patchset at Link:
> > > below, which missed converting the nouveau driver.
> > > 
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Cc: Lyude Paul <lyude@redhat.com>
> > > Cc: Danilo Krummrich <dakr@kernel.org>
> > > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > > Cc: Maxime Ripard <mripard@kernel.org>
> > > Fixes: 41ab92d35ccd ("drm: Make passing of format info to
> > > drm_helper_mode_fill_fb_struct() mandatory")
> > > Link: https://lore.kernel.org/all/20250701090722.13645-1-
> > > ville.syrjala@linux.intel.com
> > > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > 
> > Acked-by: Danilo Krummrich <dakr@kernel.org>
> 
> Any concerns if I just pick this one? It's a bit annoying to not have this fixed
> in drm-misc-fixes and -next. I'd hope for -rc2 getting backmerged.

Yes, this got delayed and didn't get to -rc1, maybe I could've merged
the fixes already reviewed earlier.

The fix is in drm-misc-next-fixes atm and Thomas has sent already

https://lore.kernel.org/all/20250812064712.GA14554@2a02-2454-fd5e-fd00-2c49-c639-c55f-a125.dyn6.pyur.net

which should get pulled to drm-fixes and then to -rc2, AFAIU, not sure
if that's enough for you. I let the maintainers comment about
cherry-picking it if not, I suppose the concern could be the duplicated
commits that Linus would see.

--Imre