* [PATCH] drm/panel: visionox-rm69299: Fix clock frequency for SHIFT6mq
@ 2025-08-30 15:29 Guido Günther
2025-09-01 12:24 ` Neil Armstrong
0 siblings, 1 reply; 3+ messages in thread
From: Guido Günther @ 2025-08-30 15:29 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
linux-kernel, Casey Connolly, phone-devel
Make the clock frequency match what the sdm845 downstream kernel
uses. Otherwise we're seeing timeouts like
```
msm_dsi ae94000.dsi: [drm:dsi_cmds2buf_tx] *ERROR* wait for video done timed out
dsi_cmds2buf_tx: cmd dma tx failed, type=0x5, data0=0x28, len=4, ret=-110
panel-visionox-rm69299 ae94000.dsi.0: sending DCS SET_DISPLAY_OFF failed: -110
```
Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
drivers/gpu/drm/panel/panel-visionox-rm69299.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/drm/panel/panel-visionox-rm69299.c
index 909c280eab1fb..e65697ce6f51c 100644
--- a/drivers/gpu/drm/panel/panel-visionox-rm69299.c
+++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c
@@ -247,7 +247,7 @@ static const struct drm_display_mode visionox_rm69299_1080x2248_60hz = {
};
static const struct drm_display_mode visionox_rm69299_1080x2160_60hz = {
- .clock = 158695,
+ .clock = 149360,
.hdisplay = 1080,
.hsync_start = 1080 + 26,
.hsync_end = 1080 + 26 + 2,
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel: visionox-rm69299: Fix clock frequency for SHIFT6mq
2025-08-30 15:29 [PATCH] drm/panel: visionox-rm69299: Fix clock frequency for SHIFT6mq Guido Günther
@ 2025-09-01 12:24 ` Neil Armstrong
2025-09-01 14:26 ` Guido Günther
0 siblings, 1 reply; 3+ messages in thread
From: Neil Armstrong @ 2025-09-01 12:24 UTC (permalink / raw)
To: Guido Günther, Jessica Zhang, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
dri-devel, linux-kernel, Casey Connolly, phone-devel
On 30/08/2025 17:29, Guido Günther wrote:
> Make the clock frequency match what the sdm845 downstream kernel
> uses. Otherwise we're seeing timeouts like
>
> ```
> msm_dsi ae94000.dsi: [drm:dsi_cmds2buf_tx] *ERROR* wait for video done timed out
> dsi_cmds2buf_tx: cmd dma tx failed, type=0x5, data0=0x28, len=4, ret=-110
> panel-visionox-rm69299 ae94000.dsi.0: sending DCS SET_DISPLAY_OFF failed: -110
> ```
>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
> drivers/gpu/drm/panel/panel-visionox-rm69299.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/drm/panel/panel-visionox-rm69299.c
> index 909c280eab1fb..e65697ce6f51c 100644
> --- a/drivers/gpu/drm/panel/panel-visionox-rm69299.c
> +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c
> @@ -247,7 +247,7 @@ static const struct drm_display_mode visionox_rm69299_1080x2248_60hz = {
> };
>
> static const struct drm_display_mode visionox_rm69299_1080x2160_60hz = {
> - .clock = 158695,
> + .clock = 149360,
> .hdisplay = 1080,
> .hsync_start = 1080 + 26,
> .hsync_end = 1080 + 26 + 2,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel: visionox-rm69299: Fix clock frequency for SHIFT6mq
2025-09-01 12:24 ` Neil Armstrong
@ 2025-09-01 14:26 ` Guido Günther
0 siblings, 0 replies; 3+ messages in thread
From: Guido Günther @ 2025-09-01 14:26 UTC (permalink / raw)
To: Neil Armstrong
Cc: Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
linux-kernel, Casey Connolly, phone-devel
Hi Neil,
On Mon, Sep 01, 2025 at 02:24:48PM +0200, Neil Armstrong wrote:
> On 30/08/2025 17:29, Guido Günther wrote:
> > Make the clock frequency match what the sdm845 downstream kernel
> > uses. Otherwise we're seeing timeouts like
> >
> > ```
> > msm_dsi ae94000.dsi: [drm:dsi_cmds2buf_tx] *ERROR* wait for video done timed out
> > dsi_cmds2buf_tx: cmd dma tx failed, type=0x5, data0=0x28, len=4, ret=-110
> > panel-visionox-rm69299 ae94000.dsi.0: sending DCS SET_DISPLAY_OFF failed: -110
> > ```
> >
> > Signed-off-by: Guido Günther <agx@sigxcpu.org>
> > ---
> > drivers/gpu/drm/panel/panel-visionox-rm69299.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/drm/panel/panel-visionox-rm69299.c
> > index 909c280eab1fb..e65697ce6f51c 100644
> > --- a/drivers/gpu/drm/panel/panel-visionox-rm69299.c
> > +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c
> > @@ -247,7 +247,7 @@ static const struct drm_display_mode visionox_rm69299_1080x2248_60hz = {
> > };
> > static const struct drm_display_mode visionox_rm69299_1080x2160_60hz = {
> > - .clock = 158695,
> > + .clock = 149360,
> > .hdisplay = 1080,
> > .hsync_start = 1080 + 26,
> > .hsync_end = 1080 + 26 + 2,
>
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks! I noticed I made a small mistake: the timeouts in the log were
unrelated but the clock change in itself is correct and needed to make
the panel show an actual picture. I've corrected that in the commit
message and folded the patch into more changes for the driver:
https://lore.kernel.org/phone-devel/20250901-shift6mq-panel-v1-0-444b4abbfaea@sigxcpu.org/T/#t
Cheers,
-- Guido
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-01 14:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-30 15:29 [PATCH] drm/panel: visionox-rm69299: Fix clock frequency for SHIFT6mq Guido Günther
2025-09-01 12:24 ` Neil Armstrong
2025-09-01 14:26 ` Guido Günther
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).