From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0847CCD1AB for ; Fri, 24 Oct 2025 07:43:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ECC6210E050; Fri, 24 Oct 2025 07:43:53 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="PwZYx6WA"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 016F410E050 for ; Fri, 24 Oct 2025 07:43:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1761291833; x=1792827833; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=7zI+yHusBy8iTPtjWgljU0yIp25yZuoATyi6HBS0Rz0=; b=PwZYx6WAWv2V5Ky8UJl6ZGJlBkjEYMMzfJAI6F1cuBBzvNxY/uMBsYYE lSFcyKtKQ9tbzDc07HZ+lvi0eDLv3+znzBCFEublDoKoI64VaMxGDoIFX zWJz+wJE/QCmyC5YlL3QX1nciCvSgStiBqw5Pt4DjwyRn7OlGbA9YQFnJ L9DIwpC0VKEbZqmWQuFHVgWeqVMFXsePTXenqtIby3yZ6LqHzYwQfhThn UuCs6gBlNcVEhYW4UdVpMYrYdAQ3Fy/E/9C+Tc8TGAJnI6PXvBxPeAc67 Y+fhOXGwuBxjDbGqjCvIFa7JzdfG4xoqOIsOxhurpP9QWAVIxckdhtvaf g==; X-CSE-ConnectionGUID: 3v6gzYt2QwSaX9HyGoPyIg== X-CSE-MsgGUID: XPHbgb8lSQicgaYcEqc6gQ== X-IronPort-AV: E=McAfee;i="6800,10657,11586"; a="63376644" X-IronPort-AV: E=Sophos;i="6.19,251,1754982000"; d="scan'208";a="63376644" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2025 00:43:52 -0700 X-CSE-ConnectionGUID: u3ao3ZWfTCKvdTwCgNOZbQ== X-CSE-MsgGUID: i6w9uVJtSDy1AqasQ83mFQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,251,1754982000"; d="scan'208";a="188756837" Received: from mjruhl-desk.amr.corp.intel.com (HELO kuha.fi.intel.com) ([10.124.221.255]) by fmviesa005.fm.intel.com with SMTP; 24 Oct 2025 00:43:42 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Fri, 24 Oct 2025 10:43:41 +0300 Date: Fri, 24 Oct 2025 10:43:41 +0300 From: Heikki Krogerus To: Chaoyi Chen Cc: Chaoyi Chen , Greg Kroah-Hartman , Dmitry Baryshkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Dragan Simic , Johan Jonker , Diederik de Haas , Peter Robinson , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v7 1/9] usb: typec: Add notifier functions Message-ID: References: <20251023033009.90-1-kernel@airkyi.com> <20251023033009.90-2-kernel@airkyi.com> <3a24bd7f-c247-4541-8cf5-c1e66e2af5a0@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3a24bd7f-c247-4541-8cf5-c1e66e2af5a0@rock-chips.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > I noticed the following statement in typec_register_altmode(): > > ``` > >     /* The partners are bind to drivers */ >     if (is_typec_partner(parent)) >         alt->adev.dev.bus = &typec_bus; > > ``` > > If the condition is not met, the bus will not be set, which means bus_notify() > won't be able to take effect. Did I miss something? Right, that would be the condition that I was talking about. Only partner altmodes are used in the bus. Hold on! Do you need the port altmode instead of the partner altmode? If that's the case, then we can't use the bus notifier. So we'll need the separate notifier chain after all. Let me take a closer look at patch 2/9. Sorry about the hassle. -- heikki