From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08260E8FDA2 for ; Fri, 26 Dec 2025 14:16:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E2DD1112124; Fri, 26 Dec 2025 14:16:32 +0000 (UTC) Received: from relay07.th.seeweb.it (relay07.th.seeweb.it [5.144.164.168]) by gabe.freedesktop.org (Postfix) with ESMTPS id DA20D112124 for ; Fri, 26 Dec 2025 14:16:31 +0000 (UTC) Received: from SoMainline.org (94-211-6-86.cable.dynamic.v4.ziggo.nl [94.211.6.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 579113EA9E; Fri, 26 Dec 2025 15:16:29 +0100 (CET) Date: Fri, 26 Dec 2025 15:16:28 +0100 From: Marijn Suijten To: Linus Walleij Cc: Neil Armstrong , Sam Ravnborg , David Airlie , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Simona Vetter , Casey Connolly , Rob Herring , Krzysztof Kozlowski , Simona Vetter , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Martin Botka , Jami Kettunen , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abhinav Kumar , Kuogee Hsieh , Jessica Zhang , AngeloGioacchino Del Regno , Konrad Dybcio , Konrad Dybcio , Dmitry Baryshkov Subject: Re: [PATCH v2 05/11] drm/panel: Add panel driver for Samsung SOFEF01 DDIC Message-ID: References: <20251222-drm-panels-sony-v2-0-82a87465d163@somainline.org> <20251222-drm-panels-sony-v2-5-82a87465d163@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2025-12-26 14:21:37, Linus Walleij wrote: ... > Only nitpicks follow: > > > + if (ctx->panel_type == PANEL_TYPE_TC01 || > > + ctx->panel_type == PANEL_TYPE_UT01 || > > + ctx->panel_type == PANEL_TYPE_UT04) { > > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0x5a, 0x5a); > > The sofef00 driver tell us exactly what this sequence is: > > #define sofef00_test_key_on_lvl2(ctx) \ > mipi_dsi_dcs_write_seq_multi(ctx, 0xf0, 0x5a, 0x5a) > #define sofef00_test_key_off_lvl2(ctx) \ > mipi_dsi_dcs_write_seq_multi(ctx, 0xf0, 0xa5, 0xa5) > > I would just rename these two to sofef01_test_key_on/off_lvl2() > and use the same helpers in this driver to follow the sofef00 pattern. Right, yes. I think I already brought this up in V1, that some existing Samsung drivers call this (the 0xf0 part) the MCS PASSWORD, others call it the LEVEL_2_KEY or USER_KEY or ACCESSPROT. I'm curious (though should probably look up the patch history) where these names come from, which of these names match the sofef01/03/souxp00 DDICs provided here, and what they're supposed to mean (MCS: Magic Command Sequence?). Then there are possibly a lot more constants we can glean from other drivers, though again without confirmation that it's identical on this DDIC. - Marijn