From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 196A0E75445 for ; Wed, 24 Dec 2025 09:43:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5CD8910E7E0; Wed, 24 Dec 2025 09:43:48 +0000 (UTC) Received: from m-r1.th.seeweb.it (m-r1.th.seeweb.it [5.144.164.170]) by gabe.freedesktop.org (Postfix) with ESMTPS id 74A8C10E7E0 for ; Wed, 24 Dec 2025 09:43:46 +0000 (UTC) Received: from SoMainline.org (94-211-6-86.cable.dynamic.v4.ziggo.nl [94.211.6.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 0537A1F6CD; Wed, 24 Dec 2025 10:43:42 +0100 (CET) Date: Wed, 24 Dec 2025 10:43:41 +0100 From: Marijn Suijten To: Neil Armstrong , Sam Ravnborg , David Airlie , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Simona Vetter , Casey Connolly , Rob Herring , Krzysztof Kozlowski , Simona Vetter Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Martin Botka , Jami Kettunen , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abhinav Kumar , Kuogee Hsieh , Jessica Zhang , AngeloGioacchino Del Regno , Konrad Dybcio , Konrad Dybcio , Dmitry Baryshkov Subject: Re: [PATCH v2 07/11] drm/panel: Add panel driver for Samsung SOFEF03-M DDIC Message-ID: References: <20251222-drm-panels-sony-v2-0-82a87465d163@somainline.org> <20251222-drm-panels-sony-v2-7-82a87465d163@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251222-drm-panels-sony-v2-7-82a87465d163@somainline.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2025-12-22 00:32:13, Marijn Suijten wrote: ... > +static int samsung_sofef03_m_probe(struct mipi_dsi_device *dsi) > +{ ... > + ctx->vddio = devm_regulator_get(dev, "vddio"); > + if (IS_ERR(ctx->vddio)) > + return dev_err_probe(dev, PTR_ERR(ctx->vddio), > + "Failed to get vddio regulator\n"); > + > + ctx->vci = devm_regulator_get(dev, "vci"); > + if (IS_ERR(ctx->vci)) > + return dev_err_probe(dev, PTR_ERR(ctx->vci), > + "Failed to get vci regulator\n"); > + In case someone wonders why this is inconsistently *NOT* using regulator_bulk while the other patches are; this was a last-minute clean-up whose fixup! commit I seem to have lost in a separate branch. This will be incorporated in v3 together with the whitespace fix in the comment. - Marijn