From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E09CD3B7E5 for ; Sun, 28 Dec 2025 09:34:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 66B5C10E091; Sun, 28 Dec 2025 09:34:26 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="tmFIC89h"; dkim-atps=neutral Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by gabe.freedesktop.org (Postfix) with ESMTPS id A0EB210E091 for ; Sun, 28 Dec 2025 09:34:25 +0000 (UTC) Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-47d3c9b8c56so34867005e9.0 for ; Sun, 28 Dec 2025 01:34:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1766914464; x=1767519264; darn=lists.freedesktop.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=SyDoBKLlFDm6X7YvWEPRli00m3Js5BcrRAsHwDYOeh8=; b=tmFIC89hG0QQbVOn26zJRdcTKqUUCFQBI0Yo/qtboEba33x9WoEijnhpDlfRDpStfQ 3tpwsvGB+ZqCqoYIb4i2PXyh9QVcbj3kAbt5CN8g10cKRV8az4M1faUnhuWG428YVtg/ tFYCcVWZz+AbyukqZDH0FdDBwGSQgtpdFTeu9LhtjYWCCK14fek/2x+d39iitCvJOdOO No5kxbUoiqKWrHT9j3hSkRpL8AgfwH5LfZleHNkinEHTFhbcqBV4Lm1BAHIHD7AnsH+r ItMCWYf38Xf/ToQGiYlsAq17ovHPWlHXZekP8nuVjea6Z8J2ijsH83elGv0Rrffo331p 4ixw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766914464; x=1767519264; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SyDoBKLlFDm6X7YvWEPRli00m3Js5BcrRAsHwDYOeh8=; b=fg2FC+nb6yOt6A+qQJOARPv244nOeCvOxH2tSmWjOuBYJT3NnncUMdaxhYLjKPi7JQ BUTA9RFOBewocmucJH2De3k50CnEkSBncraOzCA/8Zm/PMT8/0EG7/fBpfppkeidC3vN GtuHOxW0FsT/pHLfRnXpGCmXyfiUwfSx3GIz/HWVBNb6IF+iuTqQR5dr724O19gfLiSX 9GQHbM5ljBNW0qS/qWUdQpBx5oIcrZyf9ysPAWEztEDJATs5cq7L5FWIAfHd6eFUq9+z 2mvfRAWVBIhP/yRa23CcSQ0/LpxJAAlSG6MMtZaiMeSPBrDTGqBDDrdsvasTTDI6XmsR xWnA== X-Forwarded-Encrypted: i=1; AJvYcCWJ3XBWNQ/f2rvrbHmpyC8bUfTYj39C30ZedJ+5Opj8cfymY4ZFDcC0xM1ExoMDczFyAIHwYQ7FlXw=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwkRTJIubIHWsqPSebzdMiGjVDopVOU90MJQXN/79RzmhPNqPi6 1Gl0S9qCl14ZSSn86ML/XySNlemM1nnmWitQzAvfdAGV9Cd7bIzPaaaVmzmgdHRPFyXJVUjkKAt +JrQPGCp7Mf6rsLuWIQ== X-Google-Smtp-Source: AGHT+IHo7pCHMAblDTgfHFeEja9soRj4lOWXPk5g3V/fIQz7xk3TJoKa3VyvAsLqN/oKHDmyKURQ3hBGHwEaI0o= X-Received: from wrbgv17.prod.google.com ([2002:a05:6000:4611:b0:430:f5d7:f015]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:4711:b0:47a:9560:5944 with SMTP id 5b1f17b1804b1-47d195c1a71mr339326945e9.34.1766914464172; Sun, 28 Dec 2025 01:34:24 -0800 (PST) Date: Sun, 28 Dec 2025 09:34:23 +0000 In-Reply-To: <20251226-drm-gem-safety-comment-v1-1-5ae56d8194b9@ik.me> Mime-Version: 1.0 References: <20251226-drm-gem-safety-comment-v1-1-5ae56d8194b9@ik.me> Message-ID: Subject: Re: [PATCH] rust: drm: Improve safety comment when using `Pin::into_inner_unchecked` From: Alice Ryhl To: ewan.chorynski@ik.me Cc: David Airlie , Simona Vetter , Danilo Krummrich , Miguel Ojeda , Boqun Feng , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Andreas Hindborg , Trevor Gross , dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thanks for the patch! On Fri, Dec 26, 2025 at 06:22:36PM +0100, Ewan Chorynski via B4 Relay wrote: > From: Ewan Chorynski > > The safety requirements for `Pin::into_inner_unchecked` state that the > returned pointer must be treated as pinned until it is dropped. Such a > guarantee is provided by the `ARef` type. This patch improve the safety > comment to to better reflect this. typo: This patch improves typo: word "to" is duplicated twice > --- > Signed-off-by: Ewan Chorynski The Signed-off-by needs to go above the --- line. Otherwise it's not included in the commit message. Alice