From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21EAEE9271B for ; Mon, 29 Dec 2025 11:53:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 78B8610E40D; Mon, 29 Dec 2025 11:53:00 +0000 (UTC) Received: from relay05.th.seeweb.it (relay05.th.seeweb.it [5.144.164.166]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7803A10E40D for ; Mon, 29 Dec 2025 11:52:59 +0000 (UTC) Received: from SoMainline.org (94-211-6-86.cable.dynamic.v4.ziggo.nl [94.211.6.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 3DD973F65A; Mon, 29 Dec 2025 12:52:57 +0100 (CET) Date: Mon, 29 Dec 2025 12:52:55 +0100 From: Marijn Suijten To: Linus Walleij Cc: Neil Armstrong , Sam Ravnborg , David Airlie , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Simona Vetter , Casey Connolly , Rob Herring , Krzysztof Kozlowski , Simona Vetter , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Martin Botka , Jami Kettunen , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abhinav Kumar , Kuogee Hsieh , Jessica Zhang , AngeloGioacchino Del Regno , Konrad Dybcio , Konrad Dybcio , Dmitry Baryshkov Subject: Re: [PATCH v2 04/11] dt-bindings: display: panel: Describe Samsung SOFEF01-M DDIC Message-ID: References: <20251222-drm-panels-sony-v2-0-82a87465d163@somainline.org> <20251222-drm-panels-sony-v2-4-82a87465d163@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2025-12-26 18:38:56, Linus Walleij wrote: > On Fri, Dec 26, 2025 at 2:48 PM Marijn Suijten > wrote: > > On 2025-12-26 14:25:04, Linus Walleij wrote: > > > > They are clearly using the S0FEF01-M display controller. > > > > So you're implying or certain that these panel names here are always bundled > > with exactly the same controller (making the SOFEF01 part "redundant" in the > > compatible)? > > Yes that's what I suspect. Do you still want me to drop it from the compatible, but definitely keep it in the driver filename unless we unify all of the drivers (hopefully in a later patch)? > > Also, divergence of the driver commands got significant with the last two panels > > / three phones, though that might be down to vendor configuration/calibration. > > That's kind of normal. The defaults suffice for a while, then engineers > want to start poking at different voltages to the display to improve > and tweak things. Makes one wonder if the changes are down to the panel used, or vendor tuning when they started using these panels in their phones. To note, I think I booted all these phones on the "original" SOFEF01 driver without problems, before ultimately implementing all diverging commands because I don't know if they're defaults, related to color tuning, timings, thermals, manufacturer tolerances or anything else. - Marijn