From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE15AD31A25 for ; Wed, 14 Jan 2026 08:56:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CC5C010E562; Wed, 14 Jan 2026 08:56:20 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="WysZdHt5"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1790A10E3AA; Wed, 14 Jan 2026 08:56:20 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id B540243C3A; Wed, 14 Jan 2026 08:56:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A930C4CEF7; Wed, 14 Jan 2026 08:56:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768380979; bh=za4xTPWPWUHIXHkvsKZBi5B8uKsVvVpFvxtO49NYT50=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WysZdHt5vhuNsDQwGfAAf6lFLKcLvjYpEiZibWBXcfRmpKxMy/MISzgPiklw6n2a9 EYN8iCMUsYFuVSIeALm4nsQ9lpl8hQR1irii0HCVFuHgg69M9QiLozEqoVkjF4Y+AU aldxqkX3makv0a84TIohE7NRzOnPq2/IUrnYApitZ2KhtqQ7rXvjIcAvzpsUJ1vFiI Uwtf7rRYDsAaTdOmTZB2CJ4fkQ8BWhH3EXvwOce1m//83ngrge59uS7uV0h/FzOsmw GG320eEWEiRG2Q3GFRRFSs2mjLU+h3lT1eyNReOCD3AFLadRDyxvzKuiSZZPOFBRGH 8mWqZ7CXWENwQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vfwfk-000000006r2-25Dm; Wed, 14 Jan 2026 09:56:12 +0100 Date: Wed, 14 Jan 2026 09:56:12 +0100 From: Johan Hovold To: Rob Clark , Sean Paul Cc: Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , Bjorn Andersson , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] drm/msm/a6xx: fix bogus hwcg register updates Message-ID: References: <20251221164552.19990-1-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251221164552.19990-1-johan@kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Dec 21, 2025 at 05:45:52PM +0100, Johan Hovold wrote: > The hw clock gating register sequence consists of register value pairs > that are written to the GPU during initialisation. > > The a690 hwcg sequence has two GMU registers in it that used to amount > to random writes in the GPU mapping, but since commit 188db3d7fe66 > ("drm/msm/a6xx: Rebase GMU register offsets") they trigger a fault as > the updated offsets now lie outside the mapping. This in turn breaks > boot of machines like the Lenovo ThinkPad X13s. > > Note that the updates of these GMU registers is already taken care of > properly since commit 40c297eb245b ("drm/msm/a6xx: Set GMU CGC > properties on a6xx too"), but for some reason these two entries were > left in the table. > > Fixes: 5e7665b5e484 ("drm/msm/adreno: Add Adreno A690 support") > Cc: stable@vger.kernel.org # 6.5 > Cc: Bjorn Andersson > Cc: Konrad Dybcio > Signed-off-by: Johan Hovold > --- This one does not seem to have been applied yet despite fixing a critical regression in 6.19-rc1. I guess I could have highlighted that further by also including: Fixes: 188db3d7fe66 ("drm/msm/a6xx: Rebase GMU register offsets") I realise some delays are expected around Christmas, but can you please try to get this fix to Linus now that everyone should be back again? Johan