From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F031D3CCAB for ; Fri, 16 Jan 2026 09:51:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F99D10E840; Fri, 16 Jan 2026 09:51:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="jMRYqRa1"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 28A4810E840 for ; Fri, 16 Jan 2026 09:51:26 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id D913C43391; Fri, 16 Jan 2026 09:51:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16DEEC116C6; Fri, 16 Jan 2026 09:51:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768557085; bh=G0lAoXNnE8zHbc7Q4sP6bIThkQm+fl35P4QPoHmhG5c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jMRYqRa1lzkXrJsLQTDXxWE7gIOkK/AZR3GEY3WR4k5DbqQo9Yxav5qlMduZpOWck ap5IP7rG5NJD5ET7kr9xQUuQokctiIC/II4Ds+Fo+f9MQlLpk0ckKGRZd5x2iStQEF VSgqz4wyvSVCf6J8Z1k+TMW35ob5fxlnokkFnufEprvIaIiHvUm34oUNp/lDfiY05G LqFdiSxFVxjVWUlYHvf6QH2cRmcVH6PJU3CJTFTv8wKOSIxVnh1ZP3NzjRfc7nzQgf S3e0/MdWBvhPWWrAlqVKTZDixAm05nK0/+DPzBSDHSChqjTxgw2tKhjsNhNQiG1SqI sFZFdgxV7YzBw== Date: Fri, 16 Jan 2026 09:51:21 +0000 From: Tzung-Bi Shih To: Thomas Zimmermann Cc: briannorris@chromium.org, jwerner@chromium.org, javierm@redhat.com, samuel@sholland.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@gmail.com, simona@ffwll.ch, chrome-platform@lists.linux.dev, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 00/12] drm, coreboot: Add DRM coreboot driver Message-ID: References: <20260115082128.12460-1-tzimmermann@suse.de> <07efafb2-30bf-4d45-a53f-114272c1a1b1@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <07efafb2-30bf-4d45-a53f-114272c1a1b1@suse.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jan 16, 2026 at 10:19:03AM +0100, Thomas Zimmermann wrote: > Hi > > Am 16.01.26 um 10:13 schrieb Tzung-Bi Shih: > > On Thu, Jan 15, 2026 at 08:57:10AM +0100, Thomas Zimmermann wrote: > > > Coreboot implements framebuffer support via simple-framebuffer. Provide a > > > dedicated DRM driver. Keep the simple-framebuffer code for now. > > > > > > For each firmware's provided framebuffer, we prefer a dedicated DRM driver > > > tailored towards the platform's feature set. The coreboot framebuffer > > > device currently creates a simple-framebuffer device for the provided > > > framebuffer aperture. But simple-framebuffer is for DeviceTree nodes; not > > > for coreboot. The simple-framebuffer infrastructure should be phased out > > > for non-DT use cases. Coreboot is one of the final users of the code > > > (besides n64). > > > > > > Patches 1 to 5 start by fixing problems in the coreboot framebuffer > > > implementation. There is a possible dangling pointer, the memory is > > > marked as busy, the device hierarchy is incorrect, and a few minor things. > > > > > > Patches 6 to 9 prepare the coreboot support for use by external drivers. > > > Specifically, structures for the entries os the coreboot payload table > > > have to be exported. > > > > > > Patches 10 to 12 add corebootdrm, a DRM driver for the new > > > coreboot-framebuffer platform device. Corebootdrm follows the pattern > > > established by similar drivers. It also uses the same sysfb helpers. It > > > is therefore fairly small. With patch 11, it has feature parity with > > > simpledrm on the old simple-framebuffer. Patch 12 adds support for panel- > > > orientation flags that coreboot makes available. > > What would you suggest to submit the patches (e.g., which patches submit > > through which tree)? Do they have build-time dependencies? > > The patches have no dependencies besides the coreboot and DRM frameworks > they operate in. DRM moves a lot faster than coreboot, and you likely don't > have the latest DRM in the coreboot tree. So I'd take them via DRM, if > possible. Let's take this way. I'll try to review the patches and provide my A-b tag too if possible. > Note that there will be at least one more update to this series to address > review comments. Sure, no rush.