From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FA6FC88E6F for ; Mon, 26 Jan 2026 08:28:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 73E1110E3A8; Mon, 26 Jan 2026 08:28:29 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="cLbaMKG2"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id AB52F10E3A8 for ; Mon, 26 Jan 2026 08:28:28 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 5532443432; Mon, 26 Jan 2026 08:28:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F048C116C6; Mon, 26 Jan 2026 08:28:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769416108; bh=usa0U3J/t7rWhIRFX+n7Ph/rpD+CzdJPl76FuUsIbac=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cLbaMKG2HqHjC04DLKVtYluLnUfTTSbSWRr1mBIcuzHf3uaJZ8BNjyFc4ct6qZtLN v3STGt0FH9SOZ6fEMyLxlQlsbfQyXS+RwXeukVCA5ZaAZM3vww5ygd61H7YS4lGV5y cZM4nszFqTeA8M0c061Use+X9L1XgzHXBqeyePVb4AEs8k+sYrpsflmeZeJUYWiKif BG3mDW2UgaPiGy37QZgsi0SVMLijQ3oc4/F2GzegPmBPMWw1dtiOnF/6LHg+yTimcz C2DbteJeXEjLNu6XX/L6yeuL3s4FokDEBDgk1krl3hLTmcXjRbTP4dHWdQuKxSYbux 7SzQHZVPl6zzA== Date: Mon, 26 Jan 2026 08:28:23 +0000 From: Tzung-Bi Shih To: Thomas Zimmermann Cc: briannorris@chromium.org, jwerner@chromium.org, javierm@redhat.com, samuel@sholland.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@gmail.com, simona@ffwll.ch, chrome-platform@lists.linux.dev, dri-devel@lists.freedesktop.org, Hans de Goede , linux-fbdev@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 01/12] firmware: google: framebuffer: Do not unregister platform device Message-ID: References: <20260115082128.12460-1-tzimmermann@suse.de> <20260115082128.12460-2-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260115082128.12460-2-tzimmermann@suse.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jan 15, 2026 at 08:57:11AM +0100, Thomas Zimmermann wrote: > The native driver takes over the framebuffer aperture by removing the > system- framebuffer platform device. Afterwards the pointer in drvdata > is dangling. Remove the entire logic around drvdata and let the kernel's > aperture helpers handle this. The platform device depends on the native > hardware device instead of the coreboot device anyway. > > When commit 851b4c14532d ("firmware: coreboot: Add coreboot framebuffer > driver") added the coreboot framebuffer code, the kernel did not support > device-based aperture management. Instead native driviers only removed > the conflicting fbdev device. At that point, unregistering the framebuffer > device most likely worked correctly. It was definitely broken after > commit d9702b2a2171 ("fbdev/simplefb: Do not use struct > fb_info.apertures"). So take this commit for the Fixes tag. Earlier > releases might work depending on the native hardware driver. > > Signed-off-by: Thomas Zimmermann > Fixes: d9702b2a2171 ("fbdev/simplefb: Do not use struct fb_info.apertures") Acked-by: Tzung-Bi Shih