From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8CF2C88E6F for ; Mon, 26 Jan 2026 08:29:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 41A9810E3AB; Mon, 26 Jan 2026 08:29:08 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="R+QAmRBq"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8B11610E3AB for ; Mon, 26 Jan 2026 08:29:06 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 0A8C6600C3; Mon, 26 Jan 2026 08:29:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07773C116C6; Mon, 26 Jan 2026 08:29:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769416145; bh=duv63FSna/7UJJZ/FsHnyQa6lqZbbd1PPZS3QmcNnrc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R+QAmRBqjxBgW1zExN8CFs4irRmp9XHTWSdmyaACeX+KIVQ+agtMRIakolZn8cy4s lDx9Uxng0aegOT6V2/OgTfsFy2eg0A/cQ5WtrOsI+LrTTJiLiMfc+fMj19Em/VHL9/ 4j+hT9kHLxHb7ZKnnHxKyY9sEhIBjKAhB5w/BLkU9F7mfJqyED3uOT5KGfloHbDoY8 +nrJDKGgJrqoTOBRU0+jJOSS8uiE4p/V6VhM4hT2NaflpoCe0t8FHWh3FoiZ0WYwSb H4qmjBn1rLB+ZfLjBz9EcOs6Wiq1yGl2+JSYI+VIFPx1aRskOKHoaSiw7i7pjX5HVc cnQl76LzmhPkw== Date: Mon, 26 Jan 2026 08:29:02 +0000 From: Tzung-Bi Shih To: Thomas Zimmermann Cc: briannorris@chromium.org, jwerner@chromium.org, javierm@redhat.com, samuel@sholland.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@gmail.com, simona@ffwll.ch, chrome-platform@lists.linux.dev, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 04/12] firmware: google: framebuffer: Tie platform device to PCI hardware Message-ID: References: <20260115082128.12460-1-tzimmermann@suse.de> <20260115082128.12460-5-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260115082128.12460-5-tzimmermann@suse.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jan 15, 2026 at 08:57:14AM +0100, Thomas Zimmermann wrote: > Use the PCI device as parent of the system-framebuffer device instead > of the coreboot device. Prevents SIGBUS or SIGSEG after hot-unplug of > the PCI device while the framebuffer is active. > > The simple-framebuffer device depends on the PCI hardware, so this > device needs to be its parent. The current coreboot parent is no > longer needed after the system-framebuffer evice has been created. ^ d? > > On systems without PCI or if no PCI parent device could be found, > the platform device hangs on the platform bus directly. > > The fix here is similar to code in sysfb, which contained that same > bug. > > Signed-off-by: Thomas Zimmermann With some minor comments, Acked-by: Tzung-Bi Shih > + if (parent) > + put_device(parent); > + > + return 0; Or maybe just: ret = 0;