From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5701D25958 for ; Tue, 27 Jan 2026 07:49:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1BF6610E4C9; Tue, 27 Jan 2026 07:49:52 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="qQQ9e4TL"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id C3B8510E4C6 for ; Tue, 27 Jan 2026 07:49:50 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 8351E40BCF; Tue, 27 Jan 2026 07:49:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5B6FC116C6; Tue, 27 Jan 2026 07:49:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769500190; bh=hIQjKfwqD6iueffzFaX/iK+4wHuIaRycJj0c9qB8dXI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qQQ9e4TLL6lXBE3KikiTVxvZgT99i2VNqcT96wbUu/sl3qWat++dUHP/NQHVVKUWv RiCdx/DWNvRhlNzcBUcT2rCAGN5X7jPUd9B4mjbkg+b7W3NpzQpkTGhK0+fTdJRbNz 0fF4v1pXBIDhK8L3eUq4oMKodlaxyfmYnV8ao67G37Sm2D216q36057BBw/rpX/kk8 CEIoWoypB1I2K9EsPNjc9H85Hk3vTAECFwNbV0d6RijwAsOLpDuEVCYXkDPAYBZSH9 vQBBnwU4Gwb4u6M6DsrK3JZ66f4Ud9QbMsYltxSzvyi8JHV0tWrUB6Ob1PEwREutX8 /AuzsVNxJOEtg== Date: Tue, 27 Jan 2026 07:49:46 +0000 From: Tzung-Bi Shih To: Thomas Zimmermann Cc: briannorris@chromium.org, jwerner@chromium.org, javierm@redhat.com, samuel@sholland.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@gmail.com, simona@ffwll.ch, chrome-platform@lists.linux.dev, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 12/12] drm/corebotdrm: Support panel orientation Message-ID: References: <20260115082128.12460-1-tzimmermann@suse.de> <20260115082128.12460-13-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260115082128.12460-13-tzimmermann@suse.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jan 15, 2026 at 08:57:22AM +0100, Thomas Zimmermann wrote: > diff --git a/include/linux/coreboot.h b/include/linux/coreboot.h > [...] > @@ -63,9 +68,13 @@ struct lb_framebuffer { > u8 blue_mask_size; > u8 reserved_mask_pos; > u8 reserved_mask_size; > + u8 orientation; > } __packed; > > #define LB_FRAMEBUFFER_HAS_LFB(__fb) \ > ((__fb)->size >= offsetofend(struct lb_framebuffer, reserved_mask_size)) > > +#define LB_FRAMEBUFFER_HAS_ORIENTATION(__fb) \ > + ((__fb)->size >= offsetofend(struct lb_framebuffer, orientation)) Wouldn't the new field in struct lb_framebuffer break LB_FRAMEBUFFER_HAS_LFB()? E.g., fb->size == offsetofend(struct lb_framebuffer, reserved_mask_size) -> LB_FRAMEBUFFER_HAS_LFB(fb) == true -> LB_FRAMEBUFFER_HAS_ORIENTATION(fb) == false?